From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24040 invoked from network); 28 Jun 2009 17:50:10 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 Received: from new-brage.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.254.104) by ns1.primenet.com.au with SMTP; 28 Jun 2009 17:50:10 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 66062 invoked from network); 28 Jun 2009 17:49:57 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 28 Jun 2009 17:49:57 -0000 Received: (qmail 6286 invoked by alias); 28 Jun 2009 17:49:48 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 27066 Received: (qmail 6259 invoked from network); 28 Jun 2009 17:49:46 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 28 Jun 2009 17:49:46 -0000 Received: from QMTA02.westchester.pa.mail.comcast.net (qmta02.westchester.pa.mail.comcast.net [76.96.62.24]) by bifrost.dotsrc.org (Postfix) with ESMTP id B77EC80307FA for ; Sun, 28 Jun 2009 19:49:42 +0200 (CEST) Received: from OMTA10.westchester.pa.mail.comcast.net ([76.96.62.28]) by QMTA02.westchester.pa.mail.comcast.net with comcast id 9Ve61c0060cZkys52VpioZ; Sun, 28 Jun 2009 17:49:42 +0000 Received: from smtp.klanderman.net ([98.217.254.247]) by OMTA10.westchester.pa.mail.comcast.net with comcast id 9Vpi1c0095M2Np63WVpiEp; Sun, 28 Jun 2009 17:49:42 +0000 Received: from lwm.klanderman.net (unknown [192.168.100.50]) by smtp.klanderman.net (Postfix) with ESMTP id 08EDCB3014A for ; Sun, 28 Jun 2009 13:49:41 -0400 (EDT) Received: by lwm.klanderman.net (Postfix, from userid 500) id D24099FC61E; Sun, 28 Jun 2009 13:49:40 -0400 (EDT) From: Greg Klanderman To: zsh-workers@sunsite.dk Subject: Re: need help debugging cvs completion problem Reply-To: gak@klanderman.net Date: Sun, 28 Jun 2009 13:49:40 -0400 In-Reply-To: <20090628113802.GA3707@primenet.com.au> (Geoff Wing's message of "Sun, 28 Jun 2009 21:38:02 +1000") Message-ID: User-Agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.17 (linux) References: <19013.18790.978774.551126@gargle.gargle.HOWL> <20090627212418.36848701@pws-pc> <20090628113802.GA3707@primenet.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: ClamAV 0.94.2/9515/Sun Jun 28 05:42:49 2009 on bifrost X-Virus-Status: Clean >>>>> Geoff Wing writes: > It's incorrectly listed. It's really 18796 (on zsh-workers). Thank you Geoff! Peter, I now see why _path_files was being used prior to your change to _cvs_existing_entries back in 2003 - your form (with compadd, since otherwise it doesn't do anything) does not handle completing files in a subdirectory of the current directory, i.e. % cvs annotate foo/bar The directory prefix is getting removed in _cvs_existing_entries, is it safe to just paste '$linedir' back on the front of the resulting filenames? Once I figure that out, I'll resume my plan to make the analogous fix to _cvs_modified_entries. Would anyone be opposed to my starting by using Bart's equivalent series of substitutions (in his followup to 18796) rather than the mother-of-all substitutions currently found there? I presume we're not striving to unmaintainable obfuscation, is there some efficiency reason for the single substitution? thanks, Greg