From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16029 invoked by alias); 11 Aug 2010 17:15:38 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 28148 Received: (qmail 20522 invoked from network); 11 Aug 2010 17:15:33 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received-SPF: none (ns1.primenet.com.au: domain at klanderman.net does not designate permitted sender hosts) From: Greg Klanderman To: zsh-workers@zsh.org Subject: Re: ztcp should not pick fd 0 Reply-To: gak@klanderman.net Date: Wed, 11 Aug 2010 13:09:55 -0400 In-Reply-To: <20100811174454.5923a2fc@csr.com> (Peter Stephenson's message of "Wed, 11 Aug 2010 17:44:54 +0100") Message-ID: User-Agent: Gnus/5.1008 (Gnus v5.10.8) XEmacs/21.4.17 (linux) References: <19554.52743.499270.657398@gargle.gargle.HOWL> <20100811174454.5923a2fc@csr.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >>>>> On August 11, 2010 Peter Stephenson wrote: > There's nothing very special about fdtable; adding "fdtable[sess->fd] = > FDT_EXTERNAL" to the patch on success should be OK, OK, that should be easy but since the fdtable stuff is completely unabstracted, and since the redup case also needs that, and since redup only sets max_zsh_fd when the old fdtable entry is nonzero, I need to either make several more copies of the fdtable resizing code or actually abstract it. I should have a patch in a little bit... but first need lunch. thanks, Greg