From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18032 invoked from network); 21 Apr 2009 15:49:27 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=ham version=3.2.5 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 21 Apr 2009 15:49:27 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 17048 invoked from network); 21 Apr 2009 15:49:23 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 21 Apr 2009 15:49:23 -0000 Received: (qmail 26167 invoked by alias); 21 Apr 2009 15:49:17 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 26861 Received: (qmail 26149 invoked from network); 21 Apr 2009 15:49:16 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 21 Apr 2009 15:49:16 -0000 Received: from QMTA02.westchester.pa.mail.comcast.net (qmta02.westchester.pa.mail.comcast.net [76.96.62.24]) by bifrost.dotsrc.org (Postfix) with ESMTP id 7BA728028C72 for ; Tue, 21 Apr 2009 17:48:15 +0200 (CEST) Received: from OMTA11.westchester.pa.mail.comcast.net ([76.96.62.36]) by QMTA02.westchester.pa.mail.comcast.net with comcast id iB0R1b0050mv7h052FomQx; Tue, 21 Apr 2009 15:48:46 +0000 Received: from smtp.klanderman.net ([98.217.254.247]) by OMTA11.westchester.pa.mail.comcast.net with comcast id iFpC1b00m5M2Np63XFpCEn; Tue, 21 Apr 2009 15:49:13 +0000 Received: from lwm.klanderman.net (unknown [192.168.100.50]) by smtp.klanderman.net (Postfix) with ESMTP id 85AC8B3014B for ; Tue, 21 Apr 2009 11:49:11 -0400 (EDT) Received: by lwm.klanderman.net (Postfix, from userid 500) id 620999FC5F9; Tue, 21 Apr 2009 11:49:11 -0400 (EDT) From: Greg Klanderman To: zsh-workers@sunsite.dk Subject: Re: PATCH: _read_comp widget broken by 'setopt nounset' Reply-To: gak@klanderman.net Date: Tue, 21 Apr 2009 11:49:11 -0400 In-Reply-To: <18831.51704.292282.667241@gargle.gargle.HOWL> (Greg Klanderman's message of "Mon, 9 Feb 2009 01:15:20 -0500") Message-ID: User-Agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.17 (linux) References: <18831.51704.292282.667241@gargle.gargle.HOWL> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: ClamAV 0.92.1/9267/Tue Apr 21 14:59:05 2009 on bifrost X-Virus-Status: Clean Hi, I submitted this back in February, but it has not been applied or commented on. Could someone take a look please? thanks, greg >>>>> Greg Klanderman writes: > [~] phl| zsh -f > phl% > phl% autoload compinit > phl% compinit > phl% setopt nounset > phl% > _read_comp:29: _read_comp: parameter not set > phl% > Index: Completion/Base/Widget/_read_comp > =================================================================== > RCS file: /cvsroot/zsh/zsh/Completion/Base/Widget/_read_comp,v > retrieving revision 1.1 > diff -u -r1.1 _read_comp > --- Completion/Base/Widget/_read_comp 2 Apr 2001 11:17:07 -0000 1.1 > +++ Completion/Base/Widget/_read_comp 9 Feb 2009 06:12:22 -0000 > @@ -23,7 +23,7 @@ > # _read_comp Last completion string read from user > # emulate -L zsh > -setopt localoptions extendedglob nobadpattern # xtrace promptsubst > +setopt localoptions extendedglob nobadpattern unset # xtrace promptsubst > # local PS4='%N:%i:$((#key))> ' > if [[ ${+NUMERIC} = 0 && -n $_read_comp ]]; then