* universal argument regression
@ 2005-11-02 4:07 Vin Shelton
2005-11-02 10:08 ` Peter Stephenson
0 siblings, 1 reply; 3+ messages in thread
From: Vin Shelton @ 2005-11-02 4:07 UTC (permalink / raw)
To: zsh-workers
Greetings -
While empirically determing if copy-prev-word followed the universal
prefix (see my posting to zsh-users), I came across a regression in
the current shell vs. 4.2.1.
xterm -e zsh-4.2.1 -f
asdfg^A<ESC>4^F
does what is expected - it moves the cursor from the 'a' to the 'g'.
xterm -e zsh-2005-11-01 -f
asdfg^A<ESC>4^F
doesn't behave in the same way. ^A moves to the 'a', but then <ESC>4
flashes the screen (and is ignored) and the ^F moves forward 1
character to the 's'. It looks like the universal prefix argument is
ignored in the latest CVS sources.
(Upon further testing, this regression is fairly recent - a version of
the shell build on 2005-10-01 does not exhibit this bug. HTH.)
Regards,
Vin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: universal argument regression
2005-11-02 4:07 universal argument regression Vin Shelton
@ 2005-11-02 10:08 ` Peter Stephenson
2005-11-03 3:24 ` Vin Shelton
0 siblings, 1 reply; 3+ messages in thread
From: Peter Stephenson @ 2005-11-02 10:08 UTC (permalink / raw)
To: zsh-workers
Vin Shelton <acs@alumni.princeton.edu> wrote:
> It looks like the universal prefix argument is
> ignored in the latest CVS sources.
This wasn't hard to spot when I started looking...
Index: Src/Zle/zle_misc.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/zle_misc.c,v
retrieving revision 1.31
diff -u -r1.31 zle_misc.c
--- Src/Zle/zle_misc.c 1 Nov 2005 03:26:52 -0000 1.31
+++ Src/Zle/zle_misc.c 2 Nov 2005 10:07:07 -0000
@@ -532,11 +532,11 @@
* of digits. We are assuming ASCII is a subset of the multibyte
* encoding.
*/
- if (idigit(lastchar))
+ if (!idigit(lastchar))
return 1;
#else
/* allow metafied as well as ordinary digits */
- if (idigit(lastchar & 0x7f))
+ if (!idigit(lastchar & 0x7f))
return 1;
#endif
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
This message has been scanned for viruses by BlackSpider MailControl - www.blackspider.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: universal argument regression
2005-11-02 10:08 ` Peter Stephenson
@ 2005-11-03 3:24 ` Vin Shelton
0 siblings, 0 replies; 3+ messages in thread
From: Vin Shelton @ 2005-11-03 3:24 UTC (permalink / raw)
To: Peter Stephenson; +Cc: zsh-workers
Peter Stephenson <pws@csr.com> writes:
> Vin Shelton <acs@alumni.princeton.edu> wrote:
>> It looks like the universal prefix argument is
>> ignored in the latest CVS sources.
>
> This wasn't hard to spot when I started looking...
>
> Index: Src/Zle/zle_misc.c
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Src/Zle/zle_misc.c,v
> retrieving revision 1.31
> diff -u -r1.31 zle_misc.c
> --- Src/Zle/zle_misc.c 1 Nov 2005 03:26:52 -0000 1.31
> +++ Src/Zle/zle_misc.c 2 Nov 2005 10:07:07 -0000
> @@ -532,11 +532,11 @@
> * of digits. We are assuming ASCII is a subset of the multibyte
> * encoding.
> */
> - if (idigit(lastchar))
> + if (!idigit(lastchar))
> return 1;
> #else
> /* allow metafied as well as ordinary digits */
> - if (idigit(lastchar & 0x7f))
> + if (!idigit(lastchar & 0x7f))
> return 1;
> #endif
>
Yup, that fixed it.
Thank you, Peter.
- vin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-11-03 3:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-11-02 4:07 universal argument regression Vin Shelton
2005-11-02 10:08 ` Peter Stephenson
2005-11-03 3:24 ` Vin Shelton
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).