Portabilities issues of the completion

Portabilities issues of the completion

[Akim Demaille]

Hi People,

In one word, the regexp (a|) is not portable.  mawk hates, gawk loves.
Completion of make is affected on all the debian systems.

\? is portable.

According to one of the most aesthetic regexp I ever had to write:

share/zsh/functions # egrep '(\(\||\|\))' -- `fgrep awk -il *`   nostromo 18:15
_make:          /^\.include  *<bsd\.port\.(subdir\.|pre\.|)mk>/ || /^\.include  *".*mk\/bsd\.pkg\.(subdir\.|)mk"/ {
_mh:elif [[ "$prev" = -(no|)cc ]]; then
_zftp:  *(get(|at)|gcp|delete|remote))
_zftp:  *(put(|at)|pcp))

Only _make was affected, the others were not awking in the
corresponding section.

Regards,

        Akim

share/zsh/functions # diff -u _make.orig _make                   nostromo 18:16
--- _make.orig  Wed Nov 10 18:13:37 1999
+++ _make       Wed Nov 10 18:14:02 1999
@@ -22,7 +22,7 @@
   [[ -n "$file" ]] &&
     compadd "$expl[@]" - \
       $(awk '/^[a-zA-Z0-9][^\/ \t]+:/ {print $1}
-            /^\.include  *<bsd\.port\.(subdir\.|pre\.|)mk>/ || /^\.include  *".*mk\/bsd\.pkg\.(subdir\.|)mk"/ {
+            /^\.include  *<bsd\.port\.(subdir\.|pre\.)\?mk>/ || /^\.include  *".*mk\/bsd\.pkg\.(subdir\.)\?mk"/ {
               print "fetch fetch-list extract patch configure build install reinstall deinstall package describe checkpatch checksum makesum" }' \
            FS=: $file) && ret=0
   (( ret )) && { compset -P 1 '*\='; _files }

Re: Portabilities issues of the completion

[Tanaka Akira]

In article <mv4hfiuuuf1.fsf@nostromo.lrde.epita.fr>,
  Akim Demaille <akim@epita.fr> writes:

> My previous mail contains a mistake: use ?, not \?.  Though it should
> not make differences, AFAICT.

Thanks. I didn't know that (a|) is not portable.

But 8612 has mistake. It uses \? for second match.
This patch should be applyed over 8612.

Index: Completion/User/_make
===================================================================
RCS file: /projects/zsh/zsh/Completion/User/_make,v
retrieving revision 1.1.1.13
diff -u -r1.1.1.13 _make
--- Completion/User/_make	1999/11/10 19:27:53	1.1.1.13
+++ Completion/User/_make	1999/11/10 19:35:41
@@ -22,7 +22,7 @@
   [[ -n "$file" ]] &&
     compadd "$expl[@]" - \
       $(awk '/^[a-zA-Z0-9][^\/ \t]+:/ {print $1}
-	     /^\.include  *<bsd\.port\.(subdir\.|pre\.)?mk>/ || /^\.include  *".*mk\/bsd\.pkg\.(subdir\.)\?mk"/ {
+	     /^\.include  *<bsd\.port\.(subdir\.|pre\.)?mk>/ || /^\.include  *".*mk\/bsd\.pkg\.(subdir\.)?mk"/ {
 	       print "fetch fetch-list extract patch configure build install reinstall deinstall package describe checkpatch checksum makesum" }' \
 	    FS=: $file) && ret=0
   (( ret )) && { compset -P 1 '*\='; _files }
-- 
Tanaka Akira

Portabilities issues of the completion

[Akim Demaille]

Sorry,

My previous mail contains a mistake: use ?, not \?.  Though it should
not make differences, AFAICT.

        Akim

share/zsh/functions # diff -u _make.orig _make                   nostromo 18:16
--- _make.orig  Wed Nov 10 18:13:37 1999
+++ _make       Wed Nov 10 18:14:02 1999
@@ -22,7 +22,7 @@
   [[ -n "$file" ]] &&
     compadd "$expl[@]" - \
       $(awk '/^[a-zA-Z0-9][^\/ \t]+:/ {print $1}
-            /^\.include  *<bsd\.port\.(subdir\.|pre\.|)mk>/ || /^\.include  *".*mk\/bsd\.pkg\.(subdir\.|)mk"/ {
+            /^\.include  *<bsd\.port\.(subdir\.|pre\.)?mk>/ || /^\.include  *".*mk\/bsd\.pkg\.(subdir\.)\?mk"/ {
               print "fetch fetch-list extract patch configure build install reinstall deinstall package describe checkpatch checksum makesum" }' \
            FS=: $file) && ret=0
   (( ret )) && { compset -P 1 '*\='; _files }