From: Alexandre Duret-Lutz <duret_g@epita.fr>
To: zsh-workers@sunsite.auc.dk
Subject: Re: GNU diff completion problem
Date: 10 Mar 2000 13:52:16 +0100 [thread overview]
Message-ID: <mvbzos7rnr3.fsf@phobos.lrde.epita.fr> (raw)
In-Reply-To: Sven Wischnowsky's message of "Fri, 10 Mar 2000 10:01:09 +0100 (MET)"
>>> "Sven" == Sven Wischnowsky <wischnow@informatik.hu-berlin.de> writes:
[...]
Sven> it makes $words[1] be used as the command if it matches *diff. That
Sven> last part -- or at least the pattern -- may have to be changed
[...]
Isn't this choice better done by the caller of _diff_options?
I mean, _diff could say to _diff_options to use "$words[1]",
_prcs could tell it to use ${PRCS_DIFF_COMMAND:-diff}, and
so on...
This patch passes the command name as the first argument to
_diff_options (or do you prefer options?), and rewrite
_diff_is_gnu as _is_gnu like Bart did in 10035.
Index: Completion/User/_prcs
--- Completion/User/_prcs Mon, 28 Feb 2000 11:29:42 +0100 Alexandre
+++ Completion/User/_prcs Fri, 10 Mar 2000 13:25:35 +0100 Alexandre
@@ -136,7 +136,7 @@
'(--new)-N[compare new files against empty files]' \
"(-P)--exclude-project-file[don't diff the project file]" \
"(--exclude-project-file)-P[don't diff the project file]" \
- '--[introduce diff options]:*::diff options: _diff_options' \
+ '--[introduce diff options]:*::diff options: _diff_options ${PRCS_DIFF_COMMAND:-diff}' \
':project name:_prcs_projects' \
'*:file or directory:_files'
;;
Index: Completion/User/_diff
--- Completion/User/_diff Wed, 02 Feb 2000 23:45:59 +0100 Alexandre
+++ Completion/User/_diff Fri, 10 Mar 2000 13:25:35 +0100 Alexandre
@@ -1,3 +1,3 @@
#compdef diff
-_diff_options ':original file:_files' ':new file:_files'
+_diff_options "$words[1]" ':original file:_files' ':new file:_files'
Index: Completion/User/_diff_options
--- Completion/User/_diff_options Fri, 10 Mar 2000 13:24:57 +0100 Alexandre
+++ Completion/User/_diff_options Fri, 10 Mar 2000 13:29:00 +0100 Alexandre
@@ -2,23 +2,20 @@
local of ofwuc ouc oss ofwy ofwg ofwl cmd
-(( $+_diff_is_gnu )) || typeset -gA _diff_is_gnu
+(( $+_is_gnu )) || typeset -gA _is_gnu
-if (( ! $+_diff_is_gnu[$words[1]] )); then
- if [[ "$words[1]" = *diff ]]; then
- cmd="$words[1]"
- else
- cmd=diff
- fi
+cmd="$1"
+shift
+if (( ! $+_is_gnu[$cmd] )); then
if [[ $(_call version $cmd -v </dev/null 2>/dev/null) = *GNU* ]]; then
- _diff_is_gnu[$words[1]]=yes
+ _is_gnu[$cmd]=yes
else
- _diff_is_gnu[$words[1]]=
+ _is_gnu[$cmd]=
fi
fi
-if [[ -n "$_diff_is_gnu[$words[1]]" ]]; then
+if [[ -n "$_is_gnu[$cmd]" ]]; then
# output formats
of="-y --side-by-side -n --rcs -e -f --ed -q --brief -c -C --context -u -U \
--unified --old-group-format --new-group-format --changed-group-format \
--
Alexandre Duret-Lutz
next prev parent reply other threads:[~2000-03-10 12:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-03-10 9:01 Sven Wischnowsky
2000-03-10 11:24 ` Bart Schaefer
2000-03-10 12:52 ` Alexandre Duret-Lutz [this message]
-- strict thread matches above, loose matches on Subject: below --
2000-03-09 16:45 Andrej Borsenkow
2000-03-09 17:30 ` Alexandre Duret-Lutz
2000-03-09 18:22 ` Bart Schaefer
2000-03-10 7:02 ` Andrej Borsenkow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvbzos7rnr3.fsf@phobos.lrde.epita.fr \
--to=duret_g@epita.fr \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).