From: Peter Stephenson <pws@csr.com>
To: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: PATCH: fix occasional warning
Date: Mon, 6 Jun 2011 10:03:58 +0100 [thread overview]
Message-ID: <op.vwncswxenba3tw@pwspc01.europe.root.pri> (raw)
The code here is actually safe, but some (now old) versions of gcc
produce a warning anyway. Better to rely on more recent versions
optimising out the unused value.
Index: Src/subst.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/subst.c,v
retrieving revision 1.125
diff -u -r1.125 subst.c
--- Src/subst.c 3 Jun 2011 22:03:44 -0000 1.125
+++ Src/subst.c 6 Jun 2011 09:01:59 -0000
@@ -2848,7 +2848,7 @@
char *check_offset = check_colon_subscript(s, &check_offset2);
if (check_offset) {
zlong offset = mathevali(check_offset);
- zlong length;
+ zlong length = 0;
int length_set = 0;
int offset_hack_argzero = 0;
if (errflag)
pws
Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
More information can be found at www.csr.com. Follow CSR on Twitter at http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog
next reply other threads:[~2011-06-06 9:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 9:03 Peter Stephenson [this message]
2011-06-06 11:32 ` Vincent Lefevre
2011-06-06 11:46 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.vwncswxenba3tw@pwspc01.europe.root.pri \
--to=pws@csr.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).