PATCH: _make complete filenames as a last resort.

PATCH: _make complete filenames as a last resort.

[Tanaka Akira]

If targets for makefiles contain variable references, _make can not
generate proper completion candidate.

I think it is useful to complete normal filenames as a last resort.

--- Completion/User/_make-	Mon Jun  7 10:00:59 1999
+++ Completion/User/_make	Mon Jun  7 10:01:07 1999
@@ -1,3 +1,4 @@
 #compdef make gmake pmake
 
-compgen -s "\$(awk '/^[a-zA-Z0-9][^\/ 	]+:/ {print \$1}' FS=: [mM]akefile /dev/null)"
+compgen -s "\$(awk '/^[a-zA-Z0-9][^\/ 	]+:/ {print \$1}' FS=: [mM]akefile /dev/null)" ||
+compgen -f

-- 
Tanaka Akira

Re: PATCH: _make complete filenames as a last resort.

[Bart Schaefer]

On Jun 7, 10:07am, Tanaka Akira wrote:
} Subject: PATCH: _make complete filenames as a last resort.
}
} If targets for makefiles contain variable references, _make can not
} generate proper completion candidate.

Hmm; if targets for makefiles contain anything other than alphanumerics,
_make doesn't generate proper completion candidates.  What's the reason
for leaving [-._] out of the character class?  Maybe [/+,] too.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Re: PATCH: _make complete filenames as a last resort.

[Tanaka Akira]

In article <990607064350.ZM18009@candle.brasslantern.com>,
  "Bart Schaefer" <schaefer@candle.brasslantern.com> writes:

> Hmm; if targets for makefiles contain anything other than alphanumerics,
> _make doesn't generate proper completion candidates.

No. /^[a-zA-Z0-9][^\/ 	]+:/ matches any filename beginning with
alphanumerics.
-- 
Tanaka Akira

Re: PATCH: _make complete filenames as a last resort.

[Sven Wischnowsky]

Tanaka Akira wrote:

> In article <990607064350.ZM18009@candle.brasslantern.com>,
>   "Bart Schaefer" <schaefer@candle.brasslantern.com> writes:
> 
> > Hmm; if targets for makefiles contain anything other than alphanumerics,
> > _make doesn't generate proper completion candidates.
> 
> No. /^[a-zA-Z0-9][^\/ 	]+:/ matches any filename beginning with
> alphanumerics.

Just for the record: this function was in the first example file for
the new completion stuff and hasn't change since then. At that time I
really didn't have the time to write anything more sophisticated -- it 
is a hack.
So we probably should change this function to something better (and
faster, using compadd and only shell-code, no awk) anyway.
However, I explicitly excluded targets with slashes in them because if 
you use makedepend or something like that, you normally end up with
lots of full path names as targets -- and that for every system header 
file (a better solution would probably be to search only lines up the
makedepend marker-comment or something like that...).

Bye
 Sven


--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de