50cd.ztst fails if run from unresolved path

50cd.ztst fails if run from unresolved path

[Adam Spiers]

I just tried `make test' on the latest CVS tree, in a directory
/opt/zsh, which is a symlink to /mnt/hda7/opt/zsh.  50cd.ztst failed,
because the test assumes that $mydir is absolute:

cd Test ; make check
make[1]: Entering directory `/mnt/hda7/opt/zsh/Test'
for f in *.ztst; do \
  ../Src/zsh ztst.zsh $f; \
done
01grammar.ztst: all tests successful.
02alias.ztst: all tests successful.
03quoting.ztst: all tests successful.
*** /tmp/zsh.ztst.out.14109     Tue Dec 14 01:39:01 1999
--- /tmp/zsh.ztst.tout.14109    Tue Dec 14 01:39:01 1999
***************
*** 1,2 ****
! /opt/zsh/Test/cdtst.tmp/real
! /opt/zsh/Test/cdtst.tmp/real
--- 1,2 ----
! /mnt/hda7/opt/zsh/Test/cdtst.tmp/real
! /mnt/hda7/opt/zsh/Test/cdtst.tmp/real
Test 50cd.ztst failed: output differs from expected as shown above for:
 setopt chaselinks
 cd cdtst.tmp/sub/fake &&
 pwd &&
 print $PWD
Was testing: Resolving symbolic links with chaselinks set
50cd.ztst: test failed.
make[1]: *** [check] Error 1
make[1]: Leaving directory `/mnt/hda7/opt/zsh/Test'
make: *** [test] Error 2

Re: 50cd.ztst fails if run from unresolved path

[Peter Stephenson]

Adam Spiers wrote:
> I just tried `make test' on the latest CVS tree, in a directory
> /opt/zsh, which is a symlink to /mnt/hda7/opt/zsh.  50cd.ztst failed,
> because the test assumes that $mydir is absolute:

Tanaka Akira reported this.  Unsetting PWD seemed to fix it.  I haven't had
a patch yet, however, and I'm too lazy to install enough symlinks to try it
out myself.

-- 
Peter Stephenson <pws@pwstephenson.fsnet.co.uk>

Re: 50cd.ztst fails if run from unresolved path

[Tanaka Akira]

In article <E11y1bc-00003y-00.1999-12-14-23-43-45@mail6.svr.pol.co.uk>,
  Peter Stephenson <pws@pwstephenson.fsnet.co.uk> writes:

> Tanaka Akira reported this.  Unsetting PWD seemed to fix it.  I haven't had
> a patch yet, however, and I'm too lazy to install enough symlinks to try it
> out myself.

I think unsetting PWD is not good way to fix the problem because it
must be described outside of 50cd.ztst.  I dislike introducing
individual test specific stuff to Makefile.in.

So, I tried to initialize PWD in 50cd.ztst.

However, I think unsetting *all* environment variables is another way.

Index: Test/50cd.ztst
===================================================================
RCS file: /projects/zsh/zsh/Test/50cd.ztst,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 50cd.ztst
--- Test/50cd.ztst	1999/12/13 19:06:59	1.1.1.1
+++ Test/50cd.ztst	1999/12/15 09:59:10
@@ -38,6 +38,9 @@
 
  ln -s ../real cdtst.tmp/sub/fake
 
+ setopt chaselinks
+ cd .
+ unsetopt chaselinks
  mydir=$PWD
 
 %test
-- 
Tanaka Akira