Re: Diff file for 3.1.6-test-2 available

Re: Diff file for 3.1.6-test-2 available

[Ollivier Robert]

According to Peter Stephenson:
> To apply this, you need the patch programme as well as the test-1
> distribution.  Go to the top level zsh-3.1.6-test-1 directory and do
>   gzip -dc /path/to/zsh-3.1.6-test-1-test-2.diff.gz | patch -p0
>   touch stamp-h.in

Got 5 rejects... 

-rw-r--r--  1 roberto    5766 Jul 19 14:09 ChangeLog.rej
-rw-r--r--  1 roberto     978 Jul 19 14:09 Completion/Core/_main_complete.rej
-rw-r--r--  1 roberto     838 Jul 19 14:09 Completion/Core/compinstall.rej
-rw-r--r--  1 roberto     258 Jul 19 14:09 Completion/User/_ps.rej
-rw-r--r--  1 roberto     413 Jul 19 14:09 Completion/User/_tar.rej

My archive is as below

MD5 (zsh-3.1.6-test-1.tar.gz) = 468a008705bdecff4aeb0162969ce2b9
-- 
Ollivier ROBERT -=- Eurocontrol EEC/TEC -=- roberto@eurocontrol.fr
The Postman hits! The Postman hits! You have new mail.

Re: Diff file for 3.1.6-test-2 available

[Peter Stephenson]

Ollivier Robert wrote:
> Got 5 rejects... 

Dammit.  Why can't things just work?  I've uploaded another version, and
this time retrieved both to test.  There was an old test of the test
sitting on a disk, nonchalantly waiting to cause trouble.  Thanks for
spotting it before too much damage has been caused (I hope).

-- 
Peter Stephenson <pws@ibmth.df.unipi.it>       Tel: +39 050 844536
WWW:  http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy

Re: Diff file for 3.1.6-test-2 available

[Ollivier Robert]

According to Peter Stephenson:
> this time retrieved both to test.  There was an old test of the test
> sitting on a disk, nonchalantly waiting to cause trouble.  Thanks for
> spotting it before too much damage has been caused (I hope).

Patch and compile fine now.

I've seen that we've again gained some weight...

-rwxr-xr-x  1 root  wheel  576426 Sep 28  1998 zsh-3.1.4
-rwxr-xr-x  1 root  wheel  528544 Apr 22 18:13 zsh-3.1.5
-rwxr-xr-x  1 root  wheel  571084 Apr 22 18:13 zsh-3.1.5-pws-15
-rwxr-xr-x  1 root  wheel  578092 May 31 12:51 zsh-3.1.5-pws-19
-rwxr-xr-x  1 root  wheel  605336 Jul 16 12:56 zsh-3.1.6-test-1
-rwxr-xr-x  2 root  wheel  618756 Jul 19 15:26 zsh-3.1.6-test-2

All statically linked and stripped. FreeBSD 4.0 system.
-- 
Ollivier ROBERT -=- Eurocontrol EEC/TEC -=- roberto@eurocontrol.fr
The Postman hits! The Postman hits! You have new mail.

Re: Diff file for 3.1.6-test-2 available

[Peter Stephenson]

Ollivier Robert wrote:
> I've seen that we've again gained some weight...
> 
> -rwxr-xr-x  1 root  wheel  576426 Sep 28  1998 zsh-3.1.4
> -rwxr-xr-x  1 root  wheel  528544 Apr 22 18:13 zsh-3.1.5
> -rwxr-xr-x  1 root  wheel  571084 Apr 22 18:13 zsh-3.1.5-pws-15
> -rwxr-xr-x  1 root  wheel  578092 May 31 12:51 zsh-3.1.5-pws-19
> -rwxr-xr-x  1 root  wheel  605336 Jul 16 12:56 zsh-3.1.6-test-1
> -rwxr-xr-x  2 root  wheel  618756 Jul 19 15:26 zsh-3.1.6-test-2
> 
> All statically linked and stripped. FreeBSD 4.0 system.

complist (originally collist) appeared in pws-24, and is statically linked
in by default, so that might explain much of the difference between pws-19
and test-1.  Why an extra 13k since last week is not so easy to explain ---
even with the diff file right in front of me.  All the big changes are in
functions and documentation.

-- 
Peter Stephenson <pws@ibmth.df.unipi.it>       Tel: +39 050 844536
WWW:  http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy

DEC Alpha - Digital Unix 3.0 - Re: Diff file for 3.1.6-test-2 available

[Irving_Wolfe]

My "make all" ended with:

gcc -c -I.  -DHAVE_CONFIG_H -DMODULE -Wall -Wno-implicit -Wmissing-prototypes -O2 -fpic -o cap..o cap.c
rm -f cap.so
ld  -s -shared -o cap.so   cap..o   -ltermcap -lc
ld:
Warning: Unresolved:
bin_notavail
addbuiltins
deletebuiltins
gcc -c -I.  -DHAVE_CONFIG_H -DMODULE -Wall -Wno-implicit -Wmissing-prototypes -O2 -fpic -o clone..o clone.c
clone.c: In function `bin_clone':
clone.c:64: too few arguments to function `ioctl'
*** Exit 1
Stop.

"uname -a" gives:

OSF1 gonzo V3.0 347 alpha alpha

I had fixed the ypclnt.h file as advertised
in Etc/MACHINES.

I don't know enough to fix anything or
explain anything, but if information
I can provide would help someone more
knowledgeable make things work, I'd be
happy to follow instructions. 

Regards,
 - Irving

Re: DEC Alpha - Digital Unix 3.0 - Re: Diff file for 3.1.6-test-2 available

[Peter Stephenson]

Irving_Wolfe@Happy-Man.com wrote:
> My "make all" ended with:
> 
> gcc -c -I.  -DHAVE_CONFIG_H -DMODULE -Wall -Wno-implicit -Wmissing-prototypes
>  -O2 -fpic -o clone..o clone.c
> clone.c: In function `bin_clone':
> clone.c:64: too few arguments to function `ioctl'
> *** Exit 1
> Stop.

Don't see why ioctl() shouldn't have three arguments, like it does
everywhere else in the code --- some manual pages specify this --- but it's
weird this hasn't shown up before.  Maybe it's got something to do with the
difference between varargs and stdarg?

--- Src/Modules/clone.c.ioc	Thu Dec 17 12:17:01 1998
+++ Src/Modules/clone.c	Mon Jul 19 16:26:35 1999
@@ -61,7 +61,7 @@
 	    zwarnnam(nam, "failed to create new session: %e", NULL, errno);
 #endif
 #ifdef TIOCNOTTY
-	    if (ioctl(SHTTY, TIOCNOTTY))
+	    if (ioctl(SHTTY, TIOCNOTTY, 0))
 		zwarnnam(nam, "%e", NULL, errno);
 	    setpgrp(0L, mypid);
 #endif

-- 
Peter Stephenson <pws@ibmth.df.unipi.it>       Tel: +39 050 844536
WWW:  http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy

Re: Diff file for 3.1.6-test-2 available

[Tanaka Akira]

In article <9907191000.AA13440@ibmth.df.unipi.it>,
  Peter Stephenson <pws@ibmth.df.unipi.it> writes:

> I have uploaded to ftp.zsh.org the file
>   ftp://ftp.zsh.org/pub/testing/zsh-3.1.6-test-1-test-2.diff.gz

Under SunOS 4, make is failed with:

gcc -c -I.  -DHAVE_CONFIG_H -DMODULE -Wall -Wno-implicit -Wmissing-prototypes -O2 -fpic -o mapfile..o mapfile.c
mapfile.c: In function `setpmmapfile':
mapfile.c:146: `MS_SYNC' undeclared (first use in this function)
mapfile.c:146: (Each undeclared identifier is reported only once
mapfile.c:146: for each function it appears in.)
gmake[3]: *** [mapfile..o] Error 1

--- Src/Modules/mapfile.c-	Tue Jul 20 01:17:22 1999
+++ Src/Modules/mapfile.c	Tue Jul 20 01:17:46 1999
@@ -143,6 +143,9 @@
 	 */
 	ftruncate(fd, len);
 	memcpy(mmptr, value, len);
+#ifndef MS_SYNC
+#define MS_SYNC 0
+#endif
 	msync(mmptr, len, MS_SYNC);
 	/*
 	 * Then we need to truncate again, since mmap() always maps complete

> I have only received a couple of pieces of information for Etc/MACHINES.
> Please let us (zsh-workers@sunsite.auc.dk) know if you compile zsh and your
> system configuration (including OS version) is not mentioned there, or
> there are limitations not mentioned there.

I tried to compile 3.1.6-test-2 under some platforms and I sensed:

Under FreeBSD 2.2.8 and BSD/OS 3.0, dynamic loading is disabled
automatically.

Under Solaris 7, there is no problem with egcs-1.1.2 and dynamic
loading. (on my environment at least)
-- 
Tanaka Akira

Re: Diff file for 3.1.6-test-2 available

[Peter Stephenson]

Sven Wischnowsky wrote:
> >   - complist could be made to work better with dynamic loading systems
> >     that don't make symbols in other dynamic modules visible
> 
> Hm, I just had a look at this. If I've counted correctly, there are 38 
> symbols used. Four of them could reasonably be put into minfo. But
> adding 34 pointer variables just to support SunOS 4? And then: other
> modules may rely (now or in the future) on the symbols of other
> modules on which they depend anyway (after all this is one of the
> reasons for the dependency system, isn't it?).

You mean function symbols?  Variable symbols are easy, the definition can
just be shifted.  For the rest, if it can't be simplified it should
probably be left.  I was wondering about the possibility of defining the
pointer to the list of thingies in comp1, and calling any of those via the
list.  But that doesn't seem to cover very many.

However, if it's not going to work there's no point compiling complist.
There needs to be a warning much earlier on, or we need to suggest building
zle into the shell.

-- 
Peter Stephenson <pws@ibmth.df.unipi.it>       Tel: +39 050 844536
WWW:  http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy

Re: Diff file for 3.1.6-test-2 available

[Sven Wischnowsky]

Peter Stephenson wrote:

> Sven Wischnowsky wrote:
> > >   - complist could be made to work better with dynamic loading systems
> > >     that don't make symbols in other dynamic modules visible
> > 
> > Hm, I just had a look at this. If I've counted correctly, there are 38 
> > symbols used. Four of them could reasonably be put into minfo. But
> > adding 34 pointer variables just to support SunOS 4? And then: other
> > modules may rely (now or in the future) on the symbols of other
> > modules on which they depend anyway (after all this is one of the
> > reasons for the dependency system, isn't it?).
> 
> You mean function symbols?  Variable symbols are easy, the definition can
> just be shifted.  For the rest, if it can't be simplified it should
> probably be left.  I was wondering about the possibility of defining the
> pointer to the list of thingies in comp1, and calling any of those via the
> list.  But that doesn't seem to cover very many.

Oops, right. It's 18 functions, 4 widgets (-functions), and 16
variables. Hm.

> However, if it's not going to work there's no point compiling complist.
> There needs to be a warning much earlier on, or we need to suggest building
> zle into the shell.

I was thinking about the latter -- for SunOS 4.

Bye
 Sven


--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de