From: koenig@kulturbox.de (Andreas J. Koenig)
To: zsh-workers@math.gatech.edu
Subject: 3.0.5 Src/Makefile.in doesn't stop after error
Date: 26 Dec 1997 13:17:13 +0100 [thread overview]
Message-ID: <sfcra705meu.fsf@anna.in-berlin.de> (raw)
In-Reply-To: Tuomo Pyhala's message of "Fri, 26 Dec 1997 01:00:15 +0200 (EET)"
The Src/Makefile.in has a buglet in the rule for rlimits.h.
The patch below deletes a quite useless warning that has the
inappropriate side effect of returning TRUE instead of FALSE.
Without the patch a failing awk script (which I will describe in a
separate message) doesn't stop the make from proceeding. In my case,
on a NeXT 3.3, this leads to an empty Src/rlimits.h which leads to a
failing compilation later. It is much easier to find the cause for the
troubles if the error becomes visible immediately when it happens.
The current warning is unlikely to be seen by anybody. It comes quite
early during the first run of a make. It won't be issued again if you
repeat the make. It just gets buried and can only be reproduced by
removing the empty rlimits.h file.
*** /tmp/Makefile.in.~1.1~ Fri Dec 26 13:11:34 1997
--- /tmp/Makefile.in Fri Dec 26 13:11:34 1997
***************
*** 135,142 ****
# silent so the warning doesn't appear unless necessary
rlimits.h: rlimits.awk $(RLIMITS_INC_H)
@echo '$(AWK) -f $(srcdir)/rlimits.awk $(RLIMITS_INC_H) > rlimits.h'; \
! $(AWK) -f $(srcdir)/rlimits.awk $(RLIMITS_INC_H) > rlimits.h || \
! echo WARNING: unknown limits: mail rlimits.h to developers
$(OBJS): $(HDRS)
--- 135,141 ----
# silent so the warning doesn't appear unless necessary
rlimits.h: rlimits.awk $(RLIMITS_INC_H)
@echo '$(AWK) -f $(srcdir)/rlimits.awk $(RLIMITS_INC_H) > rlimits.h'; \
! $(AWK) -f $(srcdir)/rlimits.awk $(RLIMITS_INC_H) > rlimits.h
$(OBJS): $(HDRS)
Enjoy,
--
andreas
reply other threads:[~1997-12-26 12:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sfcra705meu.fsf@anna.in-berlin.de \
--to=koenig@kulturbox.de \
--cc=zsh-workers@math.gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).