Bug in 3.1.2-beta compared with -test1

Bug in 3.1.2-beta compared with -test1

[Bruce Stephens]

I enclose full details, but briefly, with reasonably sane tty settings, after 
"sleep 1&" returns (or some other background job), some stty settings seem 
wrong: eof, susp, etc., get zapped.  I've never noticed this in previous 
versions.

Here's a difference between zsh-3.1.2-test1 and zsh-3.1.2-beta.  There
seems to be something wrong with tty settings in the latter: they seem
to get corrupted when a background job returns.  I don't find this
happening with 3.1.2-test1.  A possibly relevant difference is that I
compiled 3.1.2-beta with dynamic loading enabled (I was tempted too
much by the stat module) but I've never used that previously (so
3.1.2-test1 didn't have it).  On the other hand, I'm using a pretty
common box: Solaris 2.5.1 with the Sparcworks compiler.

snake% exec zsh -f                                                            ~
snake% echo $ZSH_VERSION
3.1.2-test1
snake% stty
speed 38400 baud; -parity
rows = 24; columns = 80; ypixels = 0; xpixels = 0;
swtch = <undef>;
brkint -inpck -istrip icrnl -ixany imaxbel onlcr
echo echoe echok echoctl echoke iexten
snake% sleep 1&
[1] 5364
snake%
[1]  + done       sleep 1
snake% stty
speed 38400 baud; -parity
rows = 24; columns = 80; ypixels = 0; xpixels = 0;
swtch = <undef>;
brkint -inpck -istrip icrnl -ixany imaxbel onlcr
echo echoe echok echoctl echoke iexten
snake% ./zsh -f
snake% echo $ZSH_VERSION
3.1.2
snake% stty
speed 38400 baud; -parity
rows = 24; columns = 80; ypixels = 0; xpixels = 0;
swtch = <undef>;
brkint -inpck -istrip icrnl -ixany imaxbel onlcr
echo echoe echok echoctl echoke iexten
snake% sleep 1&
[1] 5368
snake%
[1]  + done       sleep 1
snake% stty
speed 38400 baud; -parity
rows = 24; columns = 80; ypixels = 0; xpixels = 0;
quit = <undef>; eof = ^a; swtch = <undef>; susp = <undef>; dsusp = <undef>; 
flush = <undef>; lnext = <undef>;
brkint -inpck -istrip inlcr icrnl -ixany imaxbel onlcr
echo echoe echok echoctl echoke iexten

--------------------------------------------------

Output of reporter:

# START zsh saveset
# uname:  SunOS snake.isode.com 5.5.1 Generic sun4m sparc SUNW,SPARCstation-5

# Aliases.

alias run-help=man
alias which-command=whence

# Key bindings.

bindkey -N .safe
bindkey -N emacs
bindkey -N main
bindkey -N vicmd
bindkey -N viins

bindkey -R -M .safe "^@"-"^I" self-insert
bindkey -M .safe "^J" accept-line
bindkey -R -M .safe "^K"-"^L" self-insert
bindkey -M .safe "^M" accept-line
bindkey -R -M .safe "^N"-"\M-^?" self-insert

bindkey -M emacs "^@" set-mark-command
bindkey -M emacs "^A" beginning-of-line
bindkey -M emacs "^B" backward-char
bindkey -M emacs "^D" delete-char-or-list
bindkey -M emacs "^E" end-of-line
bindkey -M emacs "^F" forward-char
bindkey -M emacs "^G" send-break
bindkey -M emacs "^H" backward-delete-char
bindkey -M emacs "^I" expand-or-complete
bindkey -M emacs "^J" accept-line
bindkey -M emacs "^K" kill-line
bindkey -M emacs "^L" clear-screen
bindkey -M emacs "^M" accept-line
bindkey -M emacs "^N" down-line-or-history
bindkey -M emacs "^O" accept-line-and-down-history
bindkey -M emacs "^P" up-line-or-history
bindkey -M emacs "^Q" push-line
bindkey -M emacs "^R" history-incremental-search-backward
bindkey -M emacs "^S" history-incremental-search-forward
bindkey -M emacs "^T" transpose-chars
bindkey -M emacs "^U" kill-whole-line
bindkey -M emacs "^V" quoted-insert
bindkey -M emacs "^W" backward-kill-word
bindkey -M emacs "^X^B" vi-match-bracket
bindkey -M emacs "^X^F" vi-find-next-char
bindkey -M emacs "^X^J" vi-join
bindkey -M emacs "^X^K" kill-buffer
bindkey -M emacs "^X^N" infer-next-history
bindkey -M emacs "^X^O" overwrite-mode
bindkey -M emacs "^X^U" undo
bindkey -M emacs "^X^V" vi-cmd-mode
bindkey -M emacs "^X^X" exchange-point-and-mark
bindkey -M emacs "^X*" expand-word
bindkey -M emacs "^X=" what-cursor-position
bindkey -M emacs "^XG" list-expand
bindkey -M emacs "^Xg" list-expand
bindkey -M emacs "^Xr" history-incremental-search-backward
bindkey -M emacs "^Xs" history-incremental-search-forward
bindkey -M emacs "^Xu" undo
bindkey -M emacs "^Y" yank
bindkey -M emacs "^[^D" list-choices
bindkey -M emacs "^[^G" send-break
bindkey -M emacs "^[^H" backward-kill-word
bindkey -M emacs "^[^I" self-insert-unmeta
bindkey -M emacs "^[^J" self-insert-unmeta
bindkey -M emacs "^[^L" clear-screen
bindkey -M emacs "^[^M" self-insert-unmeta
bindkey -M emacs "^[^_" copy-prev-word
bindkey -M emacs "^[ " expand-history
bindkey -M emacs "^[!" expand-history
bindkey -M emacs "^[\"" quote-region
bindkey -M emacs "^[\$" spell-word
bindkey -M emacs "^['" quote-line
bindkey -M emacs "^[-" neg-argument
bindkey -M emacs "^[." insert-last-word
bindkey -M emacs "^[0" digit-argument
bindkey -M emacs "^[1" digit-argument
bindkey -M emacs "^[2" digit-argument
bindkey -M emacs "^[3" digit-argument
bindkey -M emacs "^[4" digit-argument
bindkey -M emacs "^[5" digit-argument
bindkey -M emacs "^[6" digit-argument
bindkey -M emacs "^[7" digit-argument
bindkey -M emacs "^[8" digit-argument
bindkey -M emacs "^[9" digit-argument
bindkey -M emacs "^[<" beginning-of-buffer-or-history
bindkey -M emacs "^[>" end-of-buffer-or-history
bindkey -M emacs "^[?" which-command
bindkey -M emacs "^[A" accept-and-hold
bindkey -M emacs "^[B" backward-word
bindkey -M emacs "^[C" capitalize-word
bindkey -M emacs "^[D" kill-word
bindkey -M emacs "^[F" forward-word
bindkey -M emacs "^[G" get-line
bindkey -M emacs "^[H" run-help
bindkey -M emacs "^[L" down-case-word
bindkey -M emacs "^[N" history-beginning-search-forward
bindkey -M emacs "^[P" history-beginning-search-backward
bindkey -M emacs "^[Q" push-line
bindkey -M emacs "^[S" spell-word
bindkey -M emacs "^[T" transpose-words
bindkey -M emacs "^[U" up-case-word
bindkey -M emacs "^[W" copy-region-as-kill
bindkey -M emacs "^[[A" up-line-or-history
bindkey -M emacs "^[[B" down-line-or-history
bindkey -M emacs "^[[C" forward-char
bindkey -M emacs "^[[D" backward-char
bindkey -M emacs "^[_" insert-last-word
bindkey -M emacs "^[a" accept-and-hold
bindkey -M emacs "^[b" backward-word
bindkey -M emacs "^[c" capitalize-word
bindkey -M emacs "^[d" kill-word
bindkey -M emacs "^[f" forward-word
bindkey -M emacs "^[g" get-line
bindkey -M emacs "^[h" run-help
bindkey -M emacs "^[l" down-case-word
bindkey -M emacs "^[n" history-beginning-search-forward
bindkey -M emacs "^[p" history-beginning-search-backward
bindkey -M emacs "^[q" push-line
bindkey -M emacs "^[s" spell-word
bindkey -M emacs "^[t" transpose-words
bindkey -M emacs "^[u" up-case-word
bindkey -M emacs "^[w" copy-region-as-kill
bindkey -M emacs "^[x" execute-named-cmd
bindkey -M emacs "^[y" yank-pop
bindkey -M emacs "^[z" execute-last-named-cmd
bindkey -M emacs "^[|" vi-goto-column
bindkey -M emacs "^[^?" backward-kill-word
bindkey -M emacs "^_" undo
bindkey -R -M emacs " "-"~" self-insert
bindkey -M emacs "^?" backward-delete-char
bindkey -R -M emacs "\M-^@"-"\M-^?" self-insert

bindkey -R "^A"-"^C" self-insert
bindkey "^D" list-choices
bindkey -R "^E"-"^F" self-insert
bindkey "^G" list-expand
bindkey "^H" vi-backward-delete-char
bindkey "^I" expand-or-complete
bindkey "^J" accept-line
bindkey "^K" self-insert
bindkey "^L" clear-screen
bindkey "^M" accept-line
bindkey -R "^N"-"^P" self-insert
bindkey "^Q" vi-quoted-insert
bindkey "^R" redisplay
bindkey -R "^S"-"^T" self-insert
bindkey "^U" vi-kill-line
bindkey "^V" vi-quoted-insert
bindkey "^W" vi-backward-kill-word
bindkey -R "^X"-"^Z" self-insert
bindkey "^[" vi-cmd-mode
bindkey -R "^\\\\"-"~" self-insert
bindkey "^?" vi-backward-delete-char
bindkey -R "\M-^@"-"\M-^?" self-insert

bindkey -a "^D" list-choices
bindkey -a "^G" list-expand
bindkey -a "^H" vi-backward-char
bindkey -a "^J" accept-line
bindkey -a "^L" clear-screen
bindkey -a "^M" accept-line
bindkey -a "^N" down-history
bindkey -a "^P" up-history
bindkey -a "^R" redisplay
bindkey -a "^[[A" up-line-or-history
bindkey -a "^[[B" down-line-or-history
bindkey -a "^[[C" forward-char
bindkey -a "^[[D" backward-char
bindkey -a " " vi-forward-char
bindkey -a "\"" vi-set-buffer
bindkey -a "#" pound-insert
bindkey -a "\$" vi-end-of-line
bindkey -a "%" vi-match-bracket
bindkey -a "'" vi-goto-mark-line
bindkey -a "+" vi-down-line-or-history
bindkey -a "," vi-rev-repeat-find
bindkey -a -- "-" vi-up-line-or-history
bindkey -a "." vi-repeat-change
bindkey -a "/" vi-history-search-backward
bindkey -a "0" vi-digit-or-beginning-of-line
bindkey -R -a "1"-"9" digit-argument
bindkey -a ";" vi-repeat-find
bindkey -a "<" vi-unindent
bindkey -a "=" list-choices
bindkey -a ">" vi-indent
bindkey -a "?" vi-history-search-forward
bindkey -a "A" vi-add-eol
bindkey -a "B" vi-backward-blank-word
bindkey -a "C" vi-change-eol
bindkey -a "D" vi-kill-eol
bindkey -a "E" vi-forward-blank-word-end
bindkey -a "F" vi-find-prev-char
bindkey -a "G" vi-fetch-history
bindkey -a "I" vi-insert-bol
bindkey -a "J" vi-join
bindkey -a "N" vi-rev-repeat-search
bindkey -a "O" vi-open-line-above
bindkey -a "P" vi-put-before
bindkey -a "R" vi-replace
bindkey -a "S" vi-change-whole-line
bindkey -a "T" vi-find-prev-char-skip
bindkey -a "W" vi-forward-blank-word
bindkey -a "X" vi-backward-delete-char
bindkey -a "Y" vi-yank-whole-line
bindkey -a "\^" vi-first-non-blank
bindkey -a "\`" vi-goto-mark
bindkey -a "a" vi-add-next
bindkey -a "b" vi-backward-word
bindkey -a "c" vi-change
bindkey -a "d" vi-delete
bindkey -a "e" vi-forward-word-end
bindkey -a "f" vi-find-next-char
bindkey -a "h" vi-backward-char
bindkey -a "i" vi-insert
bindkey -a "j" down-line-or-history
bindkey -a "k" up-line-or-history
bindkey -a "l" vi-forward-char
bindkey -a "m" vi-set-mark
bindkey -a "n" vi-repeat-search
bindkey -a "o" vi-open-line-below
bindkey -a "p" vi-put-after
bindkey -a "r" vi-replace-chars
bindkey -a "s" vi-substitute
bindkey -a "t" vi-find-next-char-skip
bindkey -a "u" vi-undo-change
bindkey -a "w" vi-forward-word
bindkey -a "x" vi-delete-char
bindkey -a "y" vi-yank
bindkey -a "|" vi-goto-column
bindkey -a "~" vi-swap-case
bindkey -a "^?" vi-backward-char

bindkey -R -M viins "^A"-"^C" self-insert
bindkey -M viins "^D" list-choices
bindkey -R -M viins "^E"-"^F" self-insert
bindkey -M viins "^G" list-expand
bindkey -M viins "^H" vi-backward-delete-char
bindkey -M viins "^I" expand-or-complete
bindkey -M viins "^J" accept-line
bindkey -M viins "^K" self-insert
bindkey -M viins "^L" clear-screen
bindkey -M viins "^M" accept-line
bindkey -R -M viins "^N"-"^P" self-insert
bindkey -M viins "^Q" vi-quoted-insert
bindkey -M viins "^R" redisplay
bindkey -R -M viins "^S"-"^T" self-insert
bindkey -M viins "^U" vi-kill-line
bindkey -M viins "^V" vi-quoted-insert
bindkey -M viins "^W" vi-backward-kill-word
bindkey -R -M viins "^X"-"^Z" self-insert
bindkey -M viins "^[" vi-cmd-mode
bindkey -R -M viins "^\\\\"-"~" self-insert
bindkey -M viins "^?" vi-backward-delete-char
bindkey -R -M viins "\M-^@"-"\M-^?" self-insert

# Completions.

compctl -C -c
compctl -D -f
compctl -T

# Undefined functions.


# Defined functions.


# Limits.

limit datasize        2047MB
limit stacksize       2047MB
limit descriptors     1024

# Modules.

zmodload -d zle comp1
zmodload -d compctl comp1

zmodload -a sched

zmodload zle
zmodload compctl
zmodload comp1
zmodload rlimits

# Non-array variables.

TERMCAP=''
TERM='xterm'
\'#\'="0"
\'$\'="5366"
\'?\'="1"
ARGC="0"
AWK="nawk"
BAUD="38400"
CDPATH="\'\'"
COLORTERM="rxvt-xpm"
COLUMNS="80"
CPP="/usr/ccs/lib/cpp"
CVSROOT="/ic/dev/isode/integration"
DISPLAY=":0.0"
EDITOR="vi"
EGID="500"
ENV="/ic/dev/users/brs/.kshrc"
ERRNO="0"
EUID="168"
FCEDIT="vi"
FIGNORE="\'\'"
FPATH="\'\'"
GID="500"
HELPPATH="/usr/openwin/lib/locale:/usr/openwin/lib/help"
HISTCHARS="\'!^#\'"
HISTSIZE="30"
HOME="/ic/dev/users/brs"
HOST="snake.isode.com"
HOSTDISPLAY="snake.isode.com:0.0"
KEYTIMEOUT="40"
LD_LIBRARY_PATH="/ic/dev/users/brs/work/IC/usr/lib:/usr/local/lib:/usr/openwin/
lib"
LINENO="348"
LINES="24"
LISTMAX="100"
LOGCHECK="60"
LOGNAME="brs"
LPDEST="caxton"
LS_COLORS="\'no=00:fi=00:di=01;34:ln=01;36:pi=40;33:so=01;35:bd=40;33;01:cd=40;
33;01:or=40;31;01:ex=01;32:*.tar=01;31:*.tgz=01;31:*.arj=01;31:*.taz=01;31:*.lz
h=01;31:*.zip=01;31:*.z=01;31:*.Z=01;31:*.gz=01;31:*.deb=01;31:*.jpg=01;35:*.gi
f=01;35:*.bmp=01;35:*.ppm=01;35:*.tga=01;35:*.xbm=01;35:*.xpm=01;35:*.tif=01;35
:*.mpg=01;37:*.avi=01;37:*.gl=01;37:*.dl=01;37:\'"
MACHTYPE="sparc"
MAILCHECK="60"
MAILPATH="\'\'"
MANPATH="/ic/dev/users/brs/man:/ic/dev/users/brs/work/IC/usr/man:/ic/dev/users/
brs/man:/usr/openwin/share/man:/usr/man:/usr/local/man:/usr/local/cvs/man:/opt/
purify/man:/usr/openwin/man:/opt/LGTOserv/man:/opt/SUNWspro/man:/usr/local/man"
MODULE_PATH="/ic/dev/users/brs/lib/zsh/3.1.2"
NOSUNVIEW="0"
NULLCMD="cat"
OLDPWD="/ic/dev/users/brs/zsh-3.1.2"
OPENWINHOME="/usr/openwin"
OPTARG="\'\'"
OPTIND="1"
OSTYPE="solaris2.5.1"
PATH="/ic/dev/users/brs/bin:/usr/local/bin:/ic/dev/users/brs/work/bin:/ic/dev/u
sers/brs/work/IC/usr/sbin:/ic/dev/users/brs/work/IC/usr/bin:/usr/openwin/bin:/b
in:/usr/bin:.:/usr/ccs/bin:/opt/SUNWspro/bin:/usr/local/cvs/bin:/opt/purify:/op
t/frame/bin:/opt/SUNWwabi/bin:/usr/local/bin/mh:/opt/LGTOserv/bin:/opt/IC/bin:/
opt/IC/sbin:/usr/sbin:/ic/dev/ddts/bin"
POSTEDIT="\'\'"
PPID="5348"
PRINTER="caxton"
PROMPT="\'%m%# \'"
PROMPT2="\'%_> \'"
PROMPT3="\'?# \'"
PROMPT4="\'+ \'"
PS1="\'%m%# \'"
PS2="\'%_> \'"
PS3="\'?# \'"
PS4="\'+ \'"
PSVAR="\'\'"
PWD="/ic/dev/users/brs/zsh-3.1.2/Util"
RANDOM="26435"
READNULLCMD="more"
RPROMPT="\'\'"
RPS1="\'\'"
SECONDS="139"
SHELL="/ic/dev/users/brs/bin/zsh"
SHLVL="2"
SPROMPT="\'zsh: correct \'\\'\'%R\'\\'\' to \'\\'\'%r\'\\'\' [nyae]? \'"
TIMEFMT="\'%J  %U user %S system %P cpu %*E total\'"
TMPPREFIX="/tmp/zsh"
TTY="/dev/ttyp0"
TTYIDLE="-1"
TZ="GB"
UID="168"
USER="brs"
USERNAME="brs"
VENDOR="sun"
WATCH="\'\'"
WATCHFMT="\'%n has %a %l from %m.\'"
WINDOWID="20971522"
WORDCHARS="\'*?_-.[]~=/&;!#$%^(){}<>\'"
XFILESEARCHPATH="/usr/openwin/lib/locale/%L/%T/%N%S:/usr/openwin/lib/%T/%N%S:/u
sr/local/lib/X11/%T/%N%S"
XRSH_AUTH_TYPE="xauth"
XRSH_ENVS_TO_PASS="PATH"
ZSH_NAME="zsh"
ZSH_VERSION="3.1.2"
each="\'unix"
histchars="\'!^#\'"
reporter_OSVersion="SunOS_5.5.1"
reporter_junkiequotes="no"
status="1"
str="\'SunOS snake.isode.com 5.5.1 Generic sun4m sparc SUNW,SPARCstation-5\'"
prompt='test%'

# Array variables.

argv=()
'*'=()
cdpath=()
fignore=()
fpath=()
mailpath=()
manpath=(/ic/dev/users/brs/man /ic/dev/users/brs/work/IC/usr/man 
/ic/dev/users/brs/man /usr/openwin/share/man /usr/man /usr/local/man 
/usr/local/cvs/man /opt/purify/man /usr/openwin/man /opt/LGTOserv/man 
/opt/SUNWspro/man /usr/local/man)
module_path=(/ic/dev/users/brs/lib/zsh/3.1.2)
path=(/ic/dev/users/brs/bin /usr/local/bin /ic/dev/users/brs/work/bin 
/ic/dev/users/brs/work/IC/usr/sbin /ic/dev/users/brs/work/IC/usr/bin 
/usr/openwin/bin /bin /usr/bin . /usr/ccs/bin /opt/SUNWspro/bin 
/usr/local/cvs/bin /opt/purify /opt/frame/bin /opt/SUNWwabi/bin 
/usr/local/bin/mh /opt/LGTOserv/bin /opt/IC/bin /opt/IC/sbin /usr/sbin 
/ic/dev/ddts/bin)
psvar=()
signals=(EXIT HUP INT QUIT ILL TRAP IOT EMT FPE KILL BUS SEGV SYS PIPE ALRM 
TERM USR1 USR2 CLD PWR WINCH URG POLL STOP TSTP CONT TTIN TTOU VTALRM PROF 
XCPU XFSZ WAITING LWP FREEZE THAW CANCEL RTMIN 38 39 40 41 42 43 RTMAX ZERR 
DEBUG)
watch=()

# Exported variables.

export TERMCAP
export TERM
export COLORTERM=rxvt-xpm
export CVSROOT=/ic/dev/isode/integration
export DISPLAY=:0.0
export EDITOR=vi
export ENV=/ic/dev/users/brs/.kshrc
export HELPPATH=/usr/openwin/lib/locale:/usr/openwin/lib/help
export HOME=/ic/dev/users/brs
export HOSTDISPLAY=snake.isode.com:0.0
export LD_LIBRARY_PATH=/ic/dev/users/brs/work/IC/usr/lib:/usr/local/lib:/usr/op
enwin/lib
export LOGNAME=brs
export LPDEST=caxton
export LS_COLORS='no=00:fi=00:di=01;34:ln=01;36:pi=40;33:so=01;35:bd=40;33;01:c
d=40;33;01:or=40;31;01:ex=01;32:*.tar=01;31:*.tgz=01;31:*.arj=01;31:*.taz=01;31
:*.lzh=01;31:*.zip=01;31:*.z=01;31:*.Z=01;31:*.gz=01;31:*.deb=01;31:*.jpg=01;35
:*.gif=01;35:*.bmp=01;35:*.ppm=01;35:*.tga=01;35:*.xbm=01;35:*.xpm=01;35:*.tif=
01;35:*.mpg=01;37:*.avi=01;37:*.gl=01;37:*.dl=01;37:'
export MANPATH=/ic/dev/users/brs/man:/ic/dev/users/brs/work/IC/usr/man:/ic/dev/
users/brs/man:/usr/openwin/share/man:/usr/man:/usr/local/man:/usr/local/cvs/man
:/opt/purify/man:/usr/openwin/man:/opt/LGTOserv/man:/opt/SUNWspro/man:/usr/loca
l/man
export NOSUNVIEW=0
export OPENWINHOME=/usr/openwin
export PATH=/ic/dev/users/brs/bin:/usr/local/bin:/ic/dev/users/brs/work/bin:/ic
/dev/users/brs/work/IC/usr/sbin:/ic/dev/users/brs/work/IC/usr/bin:/usr/openwin/
bin:/bin:/usr/bin:.:/usr/ccs/bin:/opt/SUNWspro/bin:/usr/local/cvs/bin:/opt/puri
fy:/opt/frame/bin:/opt/SUNWwabi/bin:/usr/local/bin/mh:/opt/LGTOserv/bin:/opt/IC
/bin:/opt/IC/sbin:/usr/sbin:/ic/dev/ddts/bin
export PRINTER=caxton
export PWD=/ic/dev/users/brs/zsh-3.1.2/Util
export SHELL=/ic/dev/users/brs/bin/zsh
export SHLVL=2
export TERM=xterm
export TZ=GB
export USER=brs
export WINDOWID=20971522
export XFILESEARCHPATH=/usr/openwin/lib/locale/%L/%T/%N%S:/usr/openwin/lib/%T/%
N%S:/usr/local/lib/X11/%T/%N%S
export XRSH_AUTH_TYPE=xauth
export XRSH_ENVS_TO_PASS=PATH

# Setopt.

setopt norcs

# END zsh saveset

Re: Bug in 3.1.2-beta compared with -test1

[Peter Stephenson]

Bruce Stephens wrote:
> I enclose full details, but briefly, with reasonably sane tty settings, after
>  
> "sleep 1&" returns (or some other background job), some stty settings seem 
> wrong: eof, susp, etc., get zapped.  I've never noticed this in previous 
> versions.

Any advance on the following patch?  inforeground seems to me to be
the minimum you would need to do before grabbing the tty settings, so
this can't be far wrong.  It seems to do the trick, anyway.

*** ./Src/jobs.c.old	Wed Jun  4 17:51:43 1997
--- ./Src/jobs.c	Wed Jun  4 17:53:39 1997
***************
*** 155,161 ****
  	}
      }
  
!     if (shout && !ttyfrozen && !jn->stty_in_env)
  	gettyinfo(&shttyinfo);
  
      if (isset(MONITOR)) {
--- 155,161 ----
  	}
      }
  
!     if (shout && !ttyfrozen && !jn->stty_in_env && inforeground)
  	gettyinfo(&shttyinfo);
  
      if (isset(MONITOR)) {

-- 
Peter Stephenson <pws@ifh.de>       Tel: +49 33762 77366
WWW:  http://www.ifh.de/~pws/       Fax: +49 33762 77413
Deutsches Elektronen-Synchrotron --- Institut fuer Hochenergiephysik Zeuthen
DESY-IfH, 15735 Zeuthen, Germany.

Re: Bug in 3.1.2-beta compared with -test1

[Bruce Stephens]

pws@ifh.de said:
> Any advance on the following patch?  inforeground seems to me to be
> the minimum you would need to do before grabbing the tty settings, so
> this can't be far wrong.  It seems to do the trick, anyway. 

[patch deleted]

That seems to do it, thanks.

Re: Bug in 3.1.2-beta compared with -test1

[Bart Schaefer]

On Jun 4,  6:01pm, Peter Stephenson wrote:
} Subject: Re: Bug in 3.1.2-beta compared with -test1
}
} Any advance on the following patch?  inforeground

Is this patch likely to be needed in 3.0.3 as well?

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts        http://www.nbn.com/people/lantern

Re: Bug in 3.1.2-beta compared with -test1

[Zoltan T. Hidvegi]

Peter Stephenson wrote:
> Bruce Stephens wrote:
> > "sleep 1&" returns (or some other background job), some stty settings seem
> > wrong: eof, susp, etc., get zapped.  I've never noticed this in previous
>
> Any advance on the following patch?  inforeground seems to me to be
> the minimum you would need to do before grabbing the tty settings, so
> this can't be far wrong.  It seems to do the trick, anyway.

Yes, this patch seems to be OK.  Unfortunately the same bug is in zsh-3.0.3
so I may have to release zsh-3.0.4 with this one line fix.  The original
condition in zsh-3.1.1 was

    pgrp = gettygrp();           /* get process group of tty      */

    /* is this job in the foreground of an interactive shell? */
    if ((jn->gleader == pgrp || (pgrp > 1 && kill(-pgrp, 0) == -1)) &&
        !ttyfrozen && !val && !jn->stty_in_env)
        gettyinfo(&shttyinfo);

Looks horrible, that cannot be right.  I did not notice this bug since I
use ttyctl -f.

That whole job control stuff looks like noone had any clue how it works so
everyone just put in more and more conditions until it seemd to work.  I
still do not fully understand everything here, but hopefully things are
better now.

Zoltan

Re: Bug in 3.1.2-beta compared with -test1

[Geoff Wing]

On 5 Jun 1997 03:21:36 +1000, hzoli@VNET.IBM.COM <hzoli@VNET.IBM.COM> wrote:
:Yes, this patch seems to be OK.  Unfortunately the same bug is in zsh-3.0.3
:so I may have to release zsh-3.0.4 with this one line fix.  The original
:condition in zsh-3.1.1 was

Well, I hope you wait a bit in case other fixes turn up :-)

:That whole job control stuff looks like noone had any clue how it works so
:everyone just put in more and more conditions until it seemd to work.  I
:still do not fully understand everything here, but hopefully things are
:better now.

They probably knew exactly how it worked when they wrote it.  However a week
later ....
-- 
Geoff Wing [mason@primenet.com.au]   Technical Manager
  Phone    : +61-3-9818 2977         PrimeNet - Internet Consultancy
  Facsimile: +61-3-9819 3788         Web : <URL:http://www.primenet.com.au/>
  Mobile   : 0412 162 441