Re: alwayslastprompt bugs in 3.0.6-pre-2 (?)

Re: alwayslastprompt bugs in 3.0.6-pre-2 (?)

[Sven Wischnowsky]

Bart Schaefer wrote:

> On Apr 28,  6:09pm, Greg Badros wrote:
> > Subject: Re: alwayslastprompt bugs in 3.0.6-pre-2 (?)
> > "Bart Schaefer" <schaefer@brasslantern.com> writes:
> > 
> > Can someone justify to me why it's better to not clear the completion
> > listing for Esc-X?
> 
> Probably not, because it's not better.  That's why it changed in 3.1.5+.
> The issue is that there are a number of other commands that don't clear
> the completion list for which that's also sub-optimal, so it's hard to
> justify fixing any one of them, and harder to justify fixing all of them.
> 
> However, if Sven (or anyone else) sends a patch, I'll include it.

Well, unless I've missed a message, we are still waiting for Geoff's
nicefication of the code in zrefresh() that clears the list. If his
version is as simple to use (trigger it by just setting clearlist to
non-zero), I could then easily produce a patch to call this in the
appropriate places.

(Geoff said he didn't like the look of it...)

Bye
 Sven


--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de

Re: alwayslastprompt bugs in 3.0.6-pre-2 (?)

[Geoff Wing]

Sven Wischnowsky <wischnow@informatik.hu-berlin.de> typed:
:Well, unless I've missed a message, we are still waiting for Geoff's
:nicefication of the code in zrefresh() that clears the list. If his
:version is as simple to use (trigger it by just setting clearlist to
:non-zero), I could then easily produce a patch to call this in the
:appropriate places.
:
:(Geoff said he didn't like the look of it...)

BTW, I'm referring to the look on the screen not the look of the code.
Doing something like, history-incremental-search-backward (^R emacs bindings)
is very irritating.

Regards,
-- 
Geoff Wing   <gcw@pobox.com>            Mobile : (Australia) 0413 431 874 <<<new
Work URL: http://www.primenet.com.au/   Ego URL: http://pobox.com/~gcw/

Re: alwayslastprompt bugs in 3.0.6-pre-2 (?)

[Bart Schaefer]

On Apr 28,  6:38pm, Bart Schaefer wrote:
> However, if Sven (or anyone else) sends a patch, I'll include it.

I should qualify that:  I won't include a patch that seems to have the
potential to introduce new bugs just for the sake of fixing these display
anomalies.

Re: alwayslastprompt bugs in 3.0.6-pre-2 (?)

[Bart Schaefer]

On Apr 28,  6:09pm, Greg Badros wrote:
> Subject: Re: alwayslastprompt bugs in 3.0.6-pre-2 (?)
> "Bart Schaefer" <schaefer@brasslantern.com> writes:
> 
> Can someone justify to me why it's better to not clear the completion
> listing for Esc-X?

Probably not, because it's not better.  That's why it changed in 3.1.5+.
The issue is that there are a number of other commands that don't clear
the completion list for which that's also sub-optimal, so it's hard to
justify fixing any one of them, and harder to justify fixing all of them.

However, if Sven (or anyone else) sends a patch, I'll include it.

Re: alwayslastprompt bugs in 3.0.6-pre-2 (?)

[Bart Schaefer]

On Apr 28,  2:47pm, Greg Badros wrote:
> Subject: Re: alwayslastprompt bugs in 3.0.6-pre-2 (?)
> "Bart Schaefer" <schaefer@brasslantern.com> writes:
> 
> ESC-x backward[CTRL-D]-char[ENTER]
>               ^^^^^^^^ this shows the menu under the "execute:" prompt
> 
> After pressing ENTER, only the first line of the menu is erased.  The
> rest disappears after the next prompt, but not while editing the current 
> line.

Oh.  Believe it or not, that's intentional.  It was only changed recently
in 3.1.5-pws-something when a whole slew of other commands were also added
to the set of actions that completely clear the completion listing.

> Also, when at the end of the xterm window (nxterm from RedHat 5.2, or
> the latest xterm96 built from sources) once I hit the "b" in "backward"
> above, a newline and a space get printed causing the text to scroll up
> unnecessarily.

Geoff can say for sure, but I think that's a side-effect of writing code
that works OK on terminals whose termcap/info entries lie about the way
automargin behaves on the last line of the display.

In short, I don't think either of these counts as a bug.

alwayslastprompt bugs in 3.0.6-pre-2 (?)

[Bart Schaefer]

On Apr 28,  1:30am, Greg Badros wrote:
} Subject: colorized completion patch [was Re: Release candidate patch for 3
}
} Also note that there are bugs in 3.0.6-pre-2 (yes, even before my code!
} :-) ) in the erasing of completions in M-x command mode when "setopt
} alwayslastprompt".

Are these problems that didn't exist in 3.0.5?  Can you describe them in
more detail?  I've just spent a few minutes fooling with alwayslastprompt,
listambiguous and autolist, and I don't see any problems.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com