From: Geoff Wing <mason@primenet.com.au>
To: zsh-workers@sunsite.dk
Subject: Re: [bug] completion makes input jump up one line
Date: Fri, 27 Feb 2004 01:09:03 +0000 (UTC) [thread overview]
Message-ID: <slrnc3t65f.l4i.mason@g.primenet.com.au> (raw)
In-Reply-To: <slrnc3t40f.si0.mason@g.primenet.com.au>
Geoff Wing <mason@primenet.com.au> typed:
: Mikael Magnusson <mangosoft@comhem.se> typed:
:: under 4.1, if i tabcomplete, and one of the matches in the list is a=20
:: multiple of $COLUMNS, ie, if the last letter of the match is in the=20
:: rightmost column, the whole thing jumps up one line. i confirmed it with=20
:: caphuso on #zsh, it happens in 4.1, but not 4.0
:
: I can reproduce this with:
: % zsh -f
: % setopt alwayslastprompt
: I'm guessing the calculation in calclist() needs correction.
Does this look right?
--- Zle/compresult.c 6 Feb 2003 10:29:34 -0000 1.48
+++ Zle/compresult.c 27 Feb 2004 01:02:01 -0000
@@ -1573,10 +1573,10 @@
if (!(m->flags & CMF_HIDE)) {
if (m->disp) {
if (!(m->flags & CMF_DISPLINE))
- glines += 1 + (mlens[m->gnum] / columns);
+ glines += 1 + ((mlens[m->gnum] - 1) / columns);
} else if (showall ||
!(m->flags & (CMF_NOLIST | CMF_MULT)))
- glines += 1 + ((mlens[m->gnum]) / columns);
+ glines += 1 + (((mlens[m->gnum]) - 1) / columns);
}
}
}
next prev parent reply other threads:[~2004-02-27 1:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-14 0:56 Mikael Magnusson
2004-02-27 0:32 ` Geoff Wing
2004-02-27 1:09 ` Geoff Wing [this message]
2004-02-27 2:08 ` Bart Schaefer
2004-03-01 2:50 ` Geoff Wing
2004-03-04 0:23 ` Geoff Wing
2004-03-09 14:58 Borzenkov Andrey
2004-03-09 15:35 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=slrnc3t65f.l4i.mason@g.primenet.com.au \
--to=mason@primenet.com.au \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).