From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4519 invoked by alias); 12 Nov 2013 21:43:30 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 31963 Received: (qmail 4000 invoked from network); 12 Nov 2013 21:43:25 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 X-Injected-Via-Gmane: http://gmane.org/ To: zsh-workers@zsh.org From: Martin Vaeth Subject: Re: Install run-help and *.zwc files system wide in build system Date: Tue, 12 Nov 2013 21:42:55 +0000 (UTC) Message-ID: References: <20131110181333.7682d38f@pws-pc.ntlworld.com> <131110183043.ZM21795@torch.brasslantern.com> <131111084228.ZM26372@torch.brasslantern.com> <20131112101139.31d67b73@pwslap01u.europe.root.pri> <20131112174805.26ecab48@pwslap01u.europe.root.pri> <20131112210424.177c035b@pws-pc.ntlworld.com> Reply-To: vaeth@mathematik.uni-wuerzburg.de X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: lounge.imp.fu-berlin.de User-Agent: slrn/pre1.0.0-26 (Linux) Peter Stephenson wrote: > > In particular, I'm not convinced by these... > > open(LOCALE, '-|', 'locale', '-a') || &Die('cannot execute locale -a'); I just realize that this should better be 'locale -a' instead 'locale', '-a': According to perl's manpage, the "list form" is only supported if the underlying system has a real "fork()". > etc... I don't think you find out if locale even failed to start You get an error if there is no "locale" in $PATH (tested on linux, no matter whether list form is used or not). But you are right that one should better also check the return value of "close". However, evenif an error does not get catched, it is not a big problem: Just the heuristics cannot be used, i.e. LC_CTYPE would not be modified. (Maybe one should print a clearer message in this case than just "Using LC_CTYPE=", e.g. the current value of LC_CTYPE which is actually used). > It would be good to make run-help into run-help.in, substitute the help > directory in it when config.status gets run, and install the result If the script should be provided to the user (as it is currently) so that he can create the help-directory wherever he wants later on, it is not good to force a fixed destination directory. Fixing environment variables like e.g. LC_CTYPE has the same problem, because the available locales on the machine where zsh is compiled typically differ from the available locales on the machine where zsh is executed/installed.