From: Martin Vaeth <martin@mvath.de>
To: zsh-workers@zsh.org
Subject: Re: Huge delay for completions when not sorting
Date: Mon, 2 Jul 2018 05:52:03 +0000 (UTC) [thread overview]
Message-ID: <slrnpjjfg6.pci.martin@clover.invalid> (raw)
In-Reply-To: <CAH+w=7ayv2D4LEBmo0Ms7y58tHJH+PHfsazRq-drT_SSOqZQ5A@mail.gmail.com>
Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Sun, Jul 1, 2018 at 1:38 PM, dana <dana@dana.is> wrote:
>
>> For each completion possibility, it performs a series of
>> checks against every subsequent possibility (compcore.c @ 3239)
Quadratic running time; so the result is not surprising.
BTW, the timing came from a real-world application:
Completion of package names for eix (a package database lookup in gentoo):
~20000 packages of the form "category/package" and then
~20000 with only "category/" (i.e. most of the latter are duplicates,
but these duplicates happen to be at the very end).
Unsorted output makes sense in this example since each of the 2 forms
are already added in a sorted manner.
> hash table
When building a temporary hash table it would be enough to store pointers
to the strings there to avoid data duplication.
next prev parent reply other threads:[~2018-07-02 5:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-01 17:56 Martin Vaeth
2018-07-01 20:38 ` Bart Schaefer
2018-07-01 20:38 ` dana
2018-07-01 21:12 ` Bart Schaefer
2018-07-02 5:52 ` Martin Vaeth [this message]
2018-07-02 6:03 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=slrnpjjfg6.pci.martin@clover.invalid \
--to=martin@mvath.de \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).