zsh-workers
 help / color / mirror / code / Atom feed
From: Jason L Tibbitts III <tibbs@math.uh.edu>
To: zsh-workers@zsh.org
Subject: Bug in C02cont.ztst's -N test
Date: Thu, 28 Apr 2016 19:20:55 -0500	[thread overview]
Message-ID: <ufa1t5pl0yg.fsf@epithumia.math.uh.edu> (raw)

C02cont.ztst has a test for -N which tries to disable itself if the
filesystem is mounted with noatime:

  if [[ $OSTYPE == "cygwin" ]]; then
    ZTST_skip="[[ -N file ]] not supported on Cygwin"
  elif (( isnfs )); then
    ZTST_skip="[[ -N file ]] not supported with NFS"
  elif test -f /etc/mtab && { grep $(df . 2>/dev/null| tail -n1 | awk '{print $1}') /etc/mtab | grep -q noatime; }; then
    ZTST_skip="[[ -N file ]] not supported with noatime file system"
  else
    [[ -N $newnewnew && ! -N $unmodified ]]
  fi

When building zsh in a chroot created by the "mock" tool (used in Fedora
and derivatives to build packages in a clean chroot) it's possible for
"df ." to give the following:

Filesystem     1K-blocks      Used Available Use% Mounted on
-              492127564 331926080 135179772  72% /

And, of course, "grep - /etc/mtab" errors out.

I guess the shortest solution is to add "--" in there, but that isn't
going to help the test do what it's supposed to do.

 - J<


             reply	other threads:[~2016-04-29  0:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-29  0:20 Jason L Tibbitts III [this message]
2016-04-29 20:10 ` Bart Schaefer
2016-04-29 20:29   ` Jason L Tibbitts III
2016-04-29 20:31   ` Jason L Tibbitts III
2016-04-30  0:03     ` Bart Schaefer
2016-04-29 22:38   ` Jason L Tibbitts III
2016-04-30  0:46     ` Daniel Shahaf
2016-04-30  1:01       ` Matthew Martin
2016-04-30  1:28         ` Daniel Shahaf
2016-04-30  3:51           ` Bart Schaefer
2016-04-30 17:55             ` Bart Schaefer
2016-04-30 18:11               ` Bart Schaefer
2016-05-01  1:48                 ` Daniel Shahaf
2016-05-01  4:42                   ` Bart Schaefer
2016-05-09 13:42                 ` Jun T.
2016-05-09 16:21                   ` Bart Schaefer
2016-05-09 17:32                     ` Jun T.
2016-05-10  3:33                       ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ufa1t5pl0yg.fsf@epithumia.math.uh.edu \
    --to=tibbs@math.uh.edu \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).