zsh-workers
 help / color / mirror / code / Atom feed
From: joda@pdc.kth.se (Johan Danielsson)
To: Bruce Stephens <stephens@math.ruu.nl>
Cc: zsh-workers@math.gatech.edu
Subject: Re: 3.0-pre3 fails on CRAY-YMP
Date: 24 Jul 1996 19:32:31 +0200	[thread overview]
Message-ID: <xof7mrth80g.fsf@emma.pdc.kth.se> (raw)
In-Reply-To: joda@pdc.kth.se's message of 24 Jul 1996 16:49:19 +0200

[-- Attachment #1: Type: text/plain, Size: 233 bytes --]


> > The second is that there are a couple of calls to setlimits in
> > exec.c which aren't protected with #ifdef's for getrlimits, which
> > the Cray appears to lack.

Ok, this is a new bug in pre2 or pre3. This is the quick patch:

[-- Attachment #2: Type: text/plain, Size: 478 bytes --]

RCS file: RCS/exec.c,v
retrieving revision 1.1
diff -u -r1.1 exec.c
--- exec.c      1996/07/24 17:16:34     1.1
+++ exec.c      1996/07/24 17:16:46
@@ -1686,8 +1686,10 @@
            }
            if (type == SIMPLE) {
                closem(1);
+#ifdef HAVE_GETRLIMIT
                if (!forked)
                    setlimits(NULL);
+#endif
                execute((Cmdnam) hn, cflags & BINF_DASH);
            } else {            /* ( ... ) */
                list_pipe = 0;

[-- Attachment #3: Type: text/plain, Size: 1633 bytes --]


However, shouldn't the ifdef stuff be in zsetlimit? This way you don't
have to add ifdefs in every place you want to change limits.


> One other problem I have is that it fails to change the terminal
> settings (with stty) - it looks like they get reset back when stty
> exits (and no I don't have that option on).

This is the symptoms. I haven't had time to look into this, it is a bit
hard to debug these things without a working debugger :-)

$ stty 
speed 9600 baud; -parity hupcl -cread 
rows = 32; columns = 80; ypixels = 0; xpixels = 0;
erase = ^h; 
brkint -inpck icrnl -ixany onlcr tab3 
echo echoe echok iexten 
$ stty erase '^?'
$ stty
speed 9600 baud; -parity hupcl -cread 
rows = 32; columns = 80; ypixels = 0; xpixels = 0;
erase = ^h; 
brkint -inpck icrnl -ixany onlcr tab3 
echo echoe echok iexten 
$ exec /bin/bash
$ stty erase
$ stty
speed 9600 baud; -parity hupcl -cread 
rows = 32; columns = 80; ypixels = 0; xpixels = 0;
erase = ^h; 
brkint -inpck icrnl -ixany onlcr tab3 
echo echoe echok iexten 
$ stty erase '^?'
$ stty # note that the erase character has changed
speed 9600 baud; -parity hupcl -cread 
rows = 32; columns = 80; ypixels = 0; xpixels = 0;
brkint -inpck icrnl -ixany onlcr tab3 
echo echoe echok iexten 
$ exec ./zsh
/scratch/joda/zsh-3.0-pre3/Src>stty
speed 9600 baud; -parity hupcl -cread 
rows = 32; columns = 80; ypixels = 0; xpixels = 0;
brkint -inpck icrnl -ixany onlcr tab3 
echo echoe echok iexten 
$ stty erase '^h'
$ stty
speed 9600 baud; -parity hupcl -cread 
rows = 32; columns = 80; ypixels = 0; xpixels = 0;
brkint -inpck icrnl -ixany onlcr tab3 
echo echoe echok iexten 

/Johan

      reply	other threads:[~1996-07-24 17:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1996-07-24 14:17 Bruce Stephens
1996-07-24 14:49 ` Johan Danielsson
1996-07-24 17:32   ` Johan Danielsson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xof7mrth80g.fsf@emma.pdc.kth.se \
    --to=joda@pdc.kth.se \
    --cc=stephens@math.ruu.nl \
    --cc=zsh-workers@math.gatech.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).