source@mandoc.bsd.lv
 help / color / mirror / Atom feed
* mdocml: Plug a memory leak in single_search().
@ 2011-12-10 21:46 kristaps
  0 siblings, 0 replies; only message in thread
From: kristaps @ 2011-12-10 21:46 UTC (permalink / raw)
  To: source

Log Message:
-----------
Plug a memory leak in single_search().

Modified Files:
--------------
    mdocml:
        apropos_db.c

Revision Data
-------------
Index: apropos_db.c
===================================================================
RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/apropos_db.c,v
retrieving revision 1.22
retrieving revision 1.23
diff -Lapropos_db.c -Lapropos_db.c -u -p -r1.22 -r1.23
--- apropos_db.c
+++ apropos_db.c
@@ -550,6 +550,7 @@ single_search(struct rectree *tree, cons
 			(rs, (tree->len + 1) * sizeof(struct rec));
 
 		memcpy(&rs[tree->len], &r, sizeof(struct rec));
+		memset(&r, 0, sizeof(struct rec));
 		rs[tree->len].matches =
 			mandoc_calloc(terms, sizeof(int));
 
@@ -565,7 +566,6 @@ single_search(struct rectree *tree, cons
 		} else
 			root = tree->len;
 
-		memset(&r, 0, sizeof(struct rec));
 		tree->len++;
 	}
 
@@ -573,6 +573,7 @@ single_search(struct rectree *tree, cons
 	(*idx->close)(idx);
 
 	free(buf);
+	recfree(&r);
 	return(1 == ch);
 }
 
--
 To unsubscribe send an email to source+unsubscribe@mdocml.bsd.lv

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-12-10 21:47 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-10 21:46 mdocml: Plug a memory leak in single_search() kristaps

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).