Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] xdg-utils: update to 1.2.1.
@ 2024-05-01 14:05 sgn
  2024-05-03  7:17 ` sgn
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: sgn @ 2024-05-01 14:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1252 bytes --]

There is a new pull request by sgn against master on the void-packages repository

https://github.com/sgn/void-packages xdg-utils
https://github.com/void-linux/void-packages/pull/50145

xdg-utils: update to 1.2.1.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/50145.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xdg-utils-50145.patch --]
[-- Type: text/x-diff, Size: 3860 bytes --]

From b26c9b955ac1a9c443fa90e11c470fda17bdc350 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Wed, 1 May 2024 21:04:53 +0700
Subject: [PATCH] xdg-utils: update to 1.2.1.

---
 ...ebb3e6fd9f23e993b8b7fcbd56f92d9c9197.patch | 40 -------------------
 .../xdg-settings-not-sh-compatible.patch      | 11 -----
 srcpkgs/xdg-utils/template                    |  9 +++--
 3 files changed, 5 insertions(+), 55 deletions(-)
 delete mode 100644 srcpkgs/xdg-utils/patches/9816ebb3e6fd9f23e993b8b7fcbd56f92d9c9197.patch
 delete mode 100644 srcpkgs/xdg-utils/patches/xdg-settings-not-sh-compatible.patch

diff --git a/srcpkgs/xdg-utils/patches/9816ebb3e6fd9f23e993b8b7fcbd56f92d9c9197.patch b/srcpkgs/xdg-utils/patches/9816ebb3e6fd9f23e993b8b7fcbd56f92d9c9197.patch
deleted file mode 100644
index 08c2563789472a..00000000000000
--- a/srcpkgs/xdg-utils/patches/9816ebb3e6fd9f23e993b8b7fcbd56f92d9c9197.patch
+++ /dev/null
@@ -1,40 +0,0 @@
-From 9816ebb3e6fd9f23e993b8b7fcbd56f92d9c9197 Mon Sep 17 00:00:00 2001
-From: Andrea Tarocchi <andrea.tarocchi@gmail.com>
-Date: Thu, 20 Feb 2020 22:01:04 +0100
-Subject: [PATCH] fixed #166: xdg-open dose not search correctly in directories
- with spaces in the name
-
----
- scripts/xdg-mime.in | 2 +-
- scripts/xdg-open.in | 2 +-
- 2 files changed, 2 insertions(+), 2 deletions(-)
-
-diff --git a/scripts/xdg-mime.in b/scripts/xdg-mime.in
-index 034d0ef..612d2ce 100644
---- a/scripts/xdg-mime.in
-+++ b/scripts/xdg-mime.in
-@@ -307,7 +307,7 @@ search_desktop_file()
- 
-     grep -l "$MIME;" "$dir/"*.desktop 2>/dev/null
- 
--    for f in $dir/*/; do
-+    for f in "$dir/"*/; do
-       [ -d "$f" ] && search_desktop_file "$MIME" "$f"
-     done
- }
-diff --git a/scripts/xdg-open.in b/scripts/xdg-open.in
-index 202f3e3..8de839a 100644
---- a/scripts/xdg-open.in
-+++ b/scripts/xdg-open.in
-@@ -328,7 +328,7 @@ search_desktop_file()
-         fi
-     fi
- 
--    for d in $dir/*/; do
-+    for d in "$dir/"*/; do
-         [ -d "$d" ] && search_desktop_file "$default" "$d" "$target"
-     done
- }
--- 
-GitLab
-
diff --git a/srcpkgs/xdg-utils/patches/xdg-settings-not-sh-compatible.patch b/srcpkgs/xdg-utils/patches/xdg-settings-not-sh-compatible.patch
deleted file mode 100644
index 996e078914cbb6..00000000000000
--- a/srcpkgs/xdg-utils/patches/xdg-settings-not-sh-compatible.patch
+++ /dev/null
@@ -1,11 +0,0 @@
-xdg-settings uses the ${parameter:offset} substring expansion,
-which is not available in posix shell
-
---- a/scripts/xdg-settings.in	2018-05-10 17:02:31.000000000 +0200
-+++ b/scripts/xdg-settings.in	2018-05-10 17:02:31.000000000 +0200
-@@ -1,4 +1,4 @@
--#!/bin/sh
-+#!/bin/bash
- #---------------------------------------------
- #   xdg-settings
- #
diff --git a/srcpkgs/xdg-utils/template b/srcpkgs/xdg-utils/template
index 5969b6c494556e..96caebc1a1e617 100644
--- a/srcpkgs/xdg-utils/template
+++ b/srcpkgs/xdg-utils/template
@@ -1,18 +1,19 @@
 # Template file for 'xdg-utils'
 pkgname=xdg-utils
-version=1.1.3
-revision=5
+version=1.2.1
+revision=1
 build_style=gnu-configure
 make_check_target=test
 hostmakedepends="xmlto lynx"
-depends="bash xset"
+depends="xset"
 short_desc="Tools to assist applications with various desktop integration tasks"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="MIT"
 homepage="https://www.freedesktop.org/wiki/Software/xdg-utils/"
 changelog="https://cgit.freedesktop.org/xdg/xdg-utils/plain/ChangeLog"
 distfiles="https://portland.freedesktop.org/download/${pkgname}-${version}.tar.gz"
-checksum=d798b08af8a8e2063ddde6c9fa3398ca81484f27dec642c5627ffcaa0d4051d9
+distfiles="https://gitlab.freedesktop.org/xdg/xdg-utils/-/archive/v${version}/xdg-utils-v${version}.tar.bz2"
+checksum=93d510dccf328378f012fe195b4574c2fac1cd65a74d0852d6eaa72e5a2065a7
 
 post_install() {
 	vlicense LICENSE

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: xdg-utils: update to 1.2.1.
  2024-05-01 14:05 [PR PATCH] xdg-utils: update to 1.2.1 sgn
@ 2024-05-03  7:17 ` sgn
  2024-05-16  0:12 ` classabbyamp
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 8+ messages in thread
From: sgn @ 2024-05-03  7:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/50145#issuecomment-2092445263

Comment:
Checked those failures, it seems like they can be tested in chrooted environment!!

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: xdg-utils: update to 1.2.1.
  2024-05-01 14:05 [PR PATCH] xdg-utils: update to 1.2.1 sgn
  2024-05-03  7:17 ` sgn
@ 2024-05-16  0:12 ` classabbyamp
  2024-05-16 19:37 ` [PR REVIEW] " classabbyamp
  2024-05-16 20:26 ` [PR PATCH] [Closed]: " classabbyamp
  3 siblings, 0 replies; 8+ messages in thread
From: classabbyamp @ 2024-05-16  0:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 386 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/50145#issuecomment-2113681831

Comment:
arch disables check because it needs X/browser/interactive: https://gitlab.archlinux.org/archlinux/packaging/packages/xdg-utils/-/blob/main/PKGBUILD?ref_type=heads#L55-56

alpine also disables check

i think `make_check=no` is the way 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] xdg-utils: update to 1.2.1.
  2024-05-01 14:05 [PR PATCH] xdg-utils: update to 1.2.1 sgn
  2024-05-03  7:17 ` sgn
  2024-05-16  0:12 ` classabbyamp
@ 2024-05-16 19:37 ` classabbyamp
  2024-05-16 20:26 ` [PR PATCH] [Closed]: " classabbyamp
  3 siblings, 0 replies; 8+ messages in thread
From: classabbyamp @ 2024-05-16 19:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/50145#discussion_r1603941367

Comment:
```suggestion
```

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Closed]: xdg-utils: update to 1.2.1.
  2024-05-01 14:05 [PR PATCH] xdg-utils: update to 1.2.1 sgn
                   ` (2 preceding siblings ...)
  2024-05-16 19:37 ` [PR REVIEW] " classabbyamp
@ 2024-05-16 20:26 ` classabbyamp
  3 siblings, 0 replies; 8+ messages in thread
From: classabbyamp @ 2024-05-16 20:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]

There's a closed pull request on the void-packages repository

xdg-utils: update to 1.2.1.
https://github.com/void-linux/void-packages/pull/50145

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: xdg-utils: update to 1.2.1
  2024-05-16 19:01 [PR PATCH] " bvdeenen
  2024-05-16 19:01 ` classabbyamp
  2024-05-16 19:22 ` bvdeenen
@ 2024-05-16 19:22 ` bvdeenen
  2 siblings, 0 replies; 8+ messages in thread
From: bvdeenen @ 2024-05-16 19:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

New comment by bvdeenen on void-packages repository

https://github.com/void-linux/void-packages/pull/50374#issuecomment-2116019532

Comment:
I can't reproduce the test failures locally. I have a timeout on `./xbps-src check xdg-utils` on test 1-37 (`generic_no_arg`) and another on `test_default_mime_launch`. They seem to be environment and architecture related.



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: xdg-utils: update to 1.2.1
  2024-05-16 19:01 [PR PATCH] " bvdeenen
  2024-05-16 19:01 ` classabbyamp
@ 2024-05-16 19:22 ` bvdeenen
  2024-05-16 19:22 ` bvdeenen
  2 siblings, 0 replies; 8+ messages in thread
From: bvdeenen @ 2024-05-16 19:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

New comment by bvdeenen on void-packages repository

https://github.com/void-linux/void-packages/pull/50374#issuecomment-2116019532

Comment:
I can't reproduce the test failures locally. I have a timeout on `./xbps-src check xdg-utils` on test 1-37 (`generic_no_arg`) and another on `test_default_mime_launch`.



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: xdg-utils: update to 1.2.1
  2024-05-16 19:01 [PR PATCH] " bvdeenen
@ 2024-05-16 19:01 ` classabbyamp
  2024-05-16 19:22 ` bvdeenen
  2024-05-16 19:22 ` bvdeenen
  2 siblings, 0 replies; 8+ messages in thread
From: classabbyamp @ 2024-05-16 19:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/50374#issuecomment-2115986492

Comment:
duplicate of #50145 

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2024-05-16 20:26 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-01 14:05 [PR PATCH] xdg-utils: update to 1.2.1 sgn
2024-05-03  7:17 ` sgn
2024-05-16  0:12 ` classabbyamp
2024-05-16 19:37 ` [PR REVIEW] " classabbyamp
2024-05-16 20:26 ` [PR PATCH] [Closed]: " classabbyamp
2024-05-16 19:01 [PR PATCH] " bvdeenen
2024-05-16 19:01 ` classabbyamp
2024-05-16 19:22 ` bvdeenen
2024-05-16 19:22 ` bvdeenen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).