[PR PATCH] python3-mpv-1.0.6_1

[PR PATCH] python3-mpv-1.0.6_1

[kshade]

[-- Attachment #1: Type: text/plain, Size: 388 bytes --]

There is a new pull request by kshade against master on the void-packages repository

https://github.com/kshade/void-packages python3-mpv-1.0.6
https://github.com/void-linux/void-packages/pull/50099

python3-mpv-1.0.6_1
#### Testing the changes
- I tested the changes in this PR: **briefly**



A patch file from https://github.com/void-linux/void-packages/pull/50099.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-mpv-1.0.6-50099.patch --]
[-- Type: text/x-diff, Size: 1568 bytes --]

From 11da657922f3a7850caa1b0e7e89d17f3312fbd3 Mon Sep 17 00:00:00 2001
From: kshade <kshade@crct.de>
Date: Sun, 28 Apr 2024 18:47:07 +0200
Subject: [PATCH] Bump because mpv-0.38.0_1 broke python3-mpv-1.0.3_2, also
 added missing dependencies

---
 srcpkgs/python3-mpv/template | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/python3-mpv/template b/srcpkgs/python3-mpv/template
index eb94673d7ca188..49ea4b3b63399b 100644
--- a/srcpkgs/python3-mpv/template
+++ b/srcpkgs/python3-mpv/template
@@ -1,17 +1,17 @@
 # Template file for 'python3-mpv'
 pkgname=python3-mpv
-version=1.0.3
-revision=2
+version=1.0.6
+revision=1
 build_style=python3-pep517
 # this test takes too long and has a low chance of failure
 # https://github.com/jaseg/python-mpv/issues/209#issuecomment-1180248112
 make_check_args="--deselect tests/test_mpv.py::TestLifecycle::test_wait_for_prooperty_event_overflow"
 hostmakedepends="python3-wheel"
-depends="python3 mpv"
-checkdepends="python3-pytest python3-xvfbwrapper mpv-devel"
+depends="python3 mpv python3-Pillow"
+checkdepends="python3-pytest python3-xvfbwrapper mpv-devel python3-PyVirtualDisplay"
 short_desc="Python3 interface to the MPV media player"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://github.com/jaseg/python-mpv"
 distfiles="https://github.com/jaseg/python-mpv/archive/v${version}.tar.gz"
-checksum=fe14008723fd3c380098e87a0fec811fca6e8885dd9501e20ee1db29aa4920a0
+checksum=652a4c35829f1faaa308314d1297911fdfdcd33c77dfac32d47a6f4dd958f11d

Re: [PR PATCH] [Updated] python3-mpv-1.0.6_1

[kshade]

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]

There is an updated pull request by kshade against master on the void-packages repository

https://github.com/kshade/void-packages python3-mpv-1.0.6
https://github.com/void-linux/void-packages/pull/50099

python3-mpv-1.0.6_1
#### Testing the changes
- I tested the changes in this PR: **briefly**



A patch file from https://github.com/void-linux/void-packages/pull/50099.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-mpv-1.0.6-50099.patch --]
[-- Type: text/x-diff, Size: 1705 bytes --]

From 0b619f8eb0d24d4746170c398f44ae289ebc9189 Mon Sep 17 00:00:00 2001
From: kshade <kshade@crct.de>
Date: Sun, 28 Apr 2024 18:47:07 +0200
Subject: [PATCH] Bump because mpv-0.38.0_1 broke python3-mpv-1.0.3_2, also
 added missing dependencies and updated failing test name

---
 srcpkgs/python3-mpv/template | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/python3-mpv/template b/srcpkgs/python3-mpv/template
index eb94673d7ca188..f624f4a5b4a96f 100644
--- a/srcpkgs/python3-mpv/template
+++ b/srcpkgs/python3-mpv/template
@@ -1,17 +1,17 @@
 # Template file for 'python3-mpv'
 pkgname=python3-mpv
-version=1.0.3
-revision=2
+version=1.0.6
+revision=1
 build_style=python3-pep517
 # this test takes too long and has a low chance of failure
 # https://github.com/jaseg/python-mpv/issues/209#issuecomment-1180248112
-make_check_args="--deselect tests/test_mpv.py::TestLifecycle::test_wait_for_prooperty_event_overflow"
+make_check_args="-v --deselect tests/test_mpv.py::TestLifecycle::test_wait_for_property_event_overflow"
 hostmakedepends="python3-wheel"
-depends="python3 mpv"
-checkdepends="python3-pytest python3-xvfbwrapper mpv-devel"
+depends="python3 mpv python3-Pillow"
+checkdepends="python3-pytest python3-xvfbwrapper mpv-devel python3-PyVirtualDisplay"
 short_desc="Python3 interface to the MPV media player"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://github.com/jaseg/python-mpv"
 distfiles="https://github.com/jaseg/python-mpv/archive/v${version}.tar.gz"
-checksum=fe14008723fd3c380098e87a0fec811fca6e8885dd9501e20ee1db29aa4920a0
+checksum=652a4c35829f1faaa308314d1297911fdfdcd33c77dfac32d47a6f4dd958f11d

Re: [PR REVIEW] python3-mpv-1.0.6_1

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

New review comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/50099#discussion_r1586480959

Comment:
Is it mandatory that tests be run in verbose mode?

Re: python3-mpv-1.0.6_1

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/50099#issuecomment-2088729375

Comment:
Your commit message should be something like "python3-mpv: update to 1.0.6", please see ["Committing your changes" in CONTRIBUTING.md](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#committing-your-changes) for more details.

Re: [PR REVIEW] python3-mpv-1.0.6_1

[kshade]

[-- Attachment #1: Type: text/plain, Size: 397 bytes --]

New review comment by kshade on void-packages repository

https://github.com/void-linux/void-packages/pull/50099#discussion_r1586487845

Comment:
The package appears to have issues with at least one test hanging and never finishing, without verbose it's difficult to determine which one it is since it only outputs periods, one for each finished test. Is that enough to justify enabling the flag?

Re: python3-mpv-1.0.6_1

[kshade]

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

New comment by kshade on void-packages repository

https://github.com/void-linux/void-packages/pull/50099#issuecomment-2088737199

Comment:
> Your commit message should be something like "python3-mpv: update to 1.0.6", please see ["Committing your changes" in CONTRIBUTING.md](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#committing-your-changes) for more details.

Will amend the the commit after a decision about running test in verbose is made.

Re: [PR REVIEW] python3-mpv-1.0.6_1

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New review comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/50099#discussion_r1586491999

Comment:
Yes, that's sufficient to justify enabling verbose mode.

Re: [PR PATCH] [Updated] python3-mpv-1.0.6_1

[kshade]

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]

There is an updated pull request by kshade against master on the void-packages repository

https://github.com/kshade/void-packages python3-mpv-1.0.6
https://github.com/void-linux/void-packages/pull/50099

python3-mpv-1.0.6_1
#### Testing the changes
- I tested the changes in this PR: **briefly**



A patch file from https://github.com/void-linux/void-packages/pull/50099.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-mpv-1.0.6-50099.patch --]
[-- Type: text/x-diff, Size: 1618 bytes --]

From ae25d61b80e53e5da65149c4510bbc8d79f038b0 Mon Sep 17 00:00:00 2001
From: kshade <kshade@crct.de>
Date: Sun, 28 Apr 2024 18:47:07 +0200
Subject: [PATCH] python3-mpv: update to 1.0.6

---
 srcpkgs/python3-mpv/template | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/python3-mpv/template b/srcpkgs/python3-mpv/template
index eb94673d7ca188..f624f4a5b4a96f 100644
--- a/srcpkgs/python3-mpv/template
+++ b/srcpkgs/python3-mpv/template
@@ -1,17 +1,17 @@
 # Template file for 'python3-mpv'
 pkgname=python3-mpv
-version=1.0.3
-revision=2
+version=1.0.6
+revision=1
 build_style=python3-pep517
 # this test takes too long and has a low chance of failure
 # https://github.com/jaseg/python-mpv/issues/209#issuecomment-1180248112
-make_check_args="--deselect tests/test_mpv.py::TestLifecycle::test_wait_for_prooperty_event_overflow"
+make_check_args="-v --deselect tests/test_mpv.py::TestLifecycle::test_wait_for_property_event_overflow"
 hostmakedepends="python3-wheel"
-depends="python3 mpv"
-checkdepends="python3-pytest python3-xvfbwrapper mpv-devel"
+depends="python3 mpv python3-Pillow"
+checkdepends="python3-pytest python3-xvfbwrapper mpv-devel python3-PyVirtualDisplay"
 short_desc="Python3 interface to the MPV media player"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://github.com/jaseg/python-mpv"
 distfiles="https://github.com/jaseg/python-mpv/archive/v${version}.tar.gz"
-checksum=fe14008723fd3c380098e87a0fec811fca6e8885dd9501e20ee1db29aa4920a0
+checksum=652a4c35829f1faaa308314d1297911fdfdcd33c77dfac32d47a6f4dd958f11d

Re: [PR REVIEW] python3-mpv-1.0.6_1

[kshade]

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

New review comment by kshade on void-packages repository

https://github.com/void-linux/void-packages/pull/50099#discussion_r1586496007

Comment:
Alright, thank you!

Re: [PR PATCH] [Merged]: python3-mpv-1.0.6_1

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

There's a merged pull request on the void-packages repository

python3-mpv-1.0.6_1
https://github.com/void-linux/void-packages/pull/50099

Description:
#### Testing the changes
- I tested the changes in this PR: **briefly**