From: Stephane Chazelas <stephane@chazelas.org>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] Fix crash on unset-through-nameref
Date: Mon, 4 Mar 2024 19:34:09 +0000 [thread overview]
Message-ID: <20240304193409.lv725ah6eifiazzx@chazelas.org> (raw)
In-Reply-To: <CAH+w=7b9dcQ4f=71rFZSWBVEJ4bzj7NxzD2-zoj2TkpaCkaCjw@mail.gmail.com>
2024-03-04 00:39:30 -0800, Bart Schaefer:
> On Sun, Mar 3, 2024 at 10:29 PM Stephane Chazelas <stephane@chazelas.org> wrote:
> >
> > That shows an unset through a nameref in a different scope
> > doesn't do a full unset
>
> Try removing this line from the patch:
>
> + pm->node.flags |= PM_DECLARED;
>
> If that works, it'll also require updating the test.
That helps a bit but:
$ ./Src/zsh -c 'myunset() { typeset -n v=$1; unset v; }; export x=1; myunset x; typeset -p x; x=2; typeset -p x'
export x=2
It still retained its export attribute.
--
Stephane
next prev parent reply other threads:[~2024-03-04 19:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 5:37 Bart Schaefer
2024-03-04 6:29 ` Stephane Chazelas
2024-03-04 8:39 ` Bart Schaefer
2024-03-04 19:34 ` Stephane Chazelas [this message]
2024-03-04 19:36 ` Stephane Chazelas
2024-03-04 23:50 ` Bart Schaefer
2024-03-05 8:36 ` Stephane Chazelas
2024-03-04 23:18 ` Bart Schaefer
2024-03-05 8:18 ` Stephane Chazelas
2024-03-05 18:42 ` Bart Schaefer
2024-03-05 19:38 ` Stephane Chazelas
2024-03-05 23:16 ` Bart Schaefer
2024-03-06 18:21 ` Stephane Chazelas
2024-03-06 19:17 ` Bart Schaefer
2024-03-06 19:37 ` Bart Schaefer
2024-03-05 19:48 ` unset, POSIX and the export attribute (Was: [PATCH] Fix crash on unset-through-nameref) Stephane Chazelas
2024-03-05 19:51 ` [PATCH] Fix crash on unset-through-nameref Stephane Chazelas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240304193409.lv725ah6eifiazzx@chazelas.org \
--to=stephane@chazelas.org \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).