From: Jun T <takimoto-j@kba.biglobe.ne.jp>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] find RLIM_NLIMITS correctly on Cygwin
Date: Wed, 25 Mar 2020 09:16:55 +0900 [thread overview]
Message-ID: <452D3122-F904-4A39-9E2E-31F3285C8019@kba.biglobe.ne.jp> (raw)
In-Reply-To: <20200324024320.12bae9e9@tarpaulin.shahaf.local2>
> 2020/03/24 11:43, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
>
> Jun T wrote on Tue, 24 Mar 2020 10:33 +0900:
>>
>> I get the error message 'duplicate ulimit option letter' every time
>> I start zsh. This may be quite annoying for ordinary users.
>
> That message is printed by the DPUTS1() macro.
Whoops, sorry.
I think only someone here (zsh-workers) will add a new resource, and
I believe they will run the tests (but not sure they use
--enable-zsh-debug). So just adding a test is sufficient, I think.
# Typical use of DPUTS() is to find a not-easy-to-find bug (corner cases
# etc.) which can be detected only by running zsh under various situations.
# Duplicated option letter should/can be detected more earlier.
As for the test:
> 2020/03/21 2:02, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
>
>> + limit | grep UNKNOWN || print OK
>
> The "limit" builtin is provided by a module. As such, it can be
> unavailable if the module had been disabled in config.modules prior to
> building.
So what the fix for this? Is it enough to skip the tests if loading
rlimits module fails (because we are testing module features, not
module loading)?
next prev parent reply other threads:[~2020-03-25 0:17 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 10:39 Jun T
2020-01-08 21:33 ` Daniel Shahaf
2020-01-09 10:32 ` Jun T
2020-01-09 13:15 ` Daniel Shahaf
2020-01-10 10:24 ` Jun T
2020-01-11 20:15 ` Daniel Shahaf
2020-01-13 11:00 ` Jun T
2020-01-13 16:42 ` Daniel Shahaf
2020-01-14 4:44 ` Jun T
2020-01-14 16:25 ` Daniel Shahaf
2020-02-25 9:38 ` Jun T
2020-02-27 13:22 ` Daniel Shahaf
2020-02-27 18:46 ` Mikael Magnusson
2020-02-28 8:42 ` Jun T
2020-02-28 14:19 ` Daniel Shahaf
2020-02-28 14:31 ` Daniel Shahaf
2020-03-03 9:23 ` Jun T
2020-03-04 19:29 ` Daniel Shahaf
2020-03-05 10:26 ` Jun T
2020-03-05 14:58 ` Daniel Shahaf
2020-03-20 17:02 ` Daniel Shahaf
2020-03-20 17:20 ` Bart Schaefer
2020-03-20 17:39 ` Daniel Shahaf
2020-03-20 18:28 ` Daniel Shahaf
2020-03-20 18:36 ` Bart Schaefer
2020-03-20 19:38 ` Daniel Shahaf
2020-03-20 18:39 ` Bart Schaefer
2020-03-20 19:32 ` Daniel Shahaf
2020-03-20 19:18 ` Daniel Shahaf
2020-03-23 5:31 ` Jun T
2020-03-24 2:08 ` Daniel Shahaf
2020-03-23 5:41 ` Jun T
2020-03-24 1:33 ` Jun T
2020-03-24 2:43 ` Daniel Shahaf
2020-03-25 0:16 ` Jun T [this message]
2020-03-25 22:04 ` Daniel Shahaf
2020-03-25 23:42 ` [PATCH] find RLIM_NLIMITS correctly on CygwinjL Daniel Shahaf
2020-03-24 2:34 ` [PATCH] find RLIM_NLIMITS correctly on Cygwin Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=452D3122-F904-4A39-9E2E-31F3285C8019@kba.biglobe.ne.jp \
--to=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).