From: "Daniel Shahaf" <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] find RLIM_NLIMITS correctly on Cygwin
Date: Wed, 04 Mar 2020 19:29:37 +0000 [thread overview]
Message-ID: <b0b67dd8-932b-4438-b361-001e231febb0@www.fastmail.com> (raw)
In-Reply-To: <939538FA-A90B-44DA-AF85-C50D0F516BA0@kba.biglobe.ne.jp>
Jun T wrote on Tue, 03 Mar 2020 09:23 +00:00:
>
> > 2020/02/28 23:19, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> >
> > Jun T wrote on Fri, 28 Feb 2020 17:42 +0900:
> >>
> >> Currently each test chunk can have flags 'd' 'D' 'q' and 'f'.
> >> We can add a new flag, say 'n', to make the failure not fatal.
> >
> > If we add a new letter flag, we won't be able to make the non-fatalness
> > specific to only one platform, though. We a new parameter, we'd be
> > able to do «[[ $OSTYPE == cygwin* ]] && ZTST_failure_is_fatal=false».
>
> I feel just letting the test fail may be enough, but if we are going
> to add a new parameter/flag to ztst.zsh then it would be something like
> the patch below.
In this case, how about letting the test fail, as you say? If in the
future we change our mind about that, we can add the $ZTST_not_fatal
flag then.
> BTW, in B01cd.ztst, line 73:
>
> # . d Don't diff stdout against the expected stdout.
>
> What does this '.' mean? Is it just a typo?
>
It was added in 08f084ecdeaeb19e595441e3e0203be4562bd285 (no X-Seq) by
pws. The change isn't mentioned in the log message and broke alignment
of the description column, so I guess it was a typo.
> Test/B01cd.ztst | 7 +++++--
> Test/B12limit.ztst | 10 ++++++++++
> Test/ztst.zsh | 32 ++++++++++++++++++++++----------
> 3 files changed, 37 insertions(+), 12 deletions(-)
I reviewed the diff (without out-of-hunk contexts) and have no comments.
Cheers,
Daniel
next prev parent reply other threads:[~2020-03-04 19:31 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 10:39 Jun T
2020-01-08 21:33 ` Daniel Shahaf
2020-01-09 10:32 ` Jun T
2020-01-09 13:15 ` Daniel Shahaf
2020-01-10 10:24 ` Jun T
2020-01-11 20:15 ` Daniel Shahaf
2020-01-13 11:00 ` Jun T
2020-01-13 16:42 ` Daniel Shahaf
2020-01-14 4:44 ` Jun T
2020-01-14 16:25 ` Daniel Shahaf
2020-02-25 9:38 ` Jun T
2020-02-27 13:22 ` Daniel Shahaf
2020-02-27 18:46 ` Mikael Magnusson
2020-02-28 8:42 ` Jun T
2020-02-28 14:19 ` Daniel Shahaf
2020-02-28 14:31 ` Daniel Shahaf
2020-03-03 9:23 ` Jun T
2020-03-04 19:29 ` Daniel Shahaf [this message]
2020-03-05 10:26 ` Jun T
2020-03-05 14:58 ` Daniel Shahaf
2020-03-20 17:02 ` Daniel Shahaf
2020-03-20 17:20 ` Bart Schaefer
2020-03-20 17:39 ` Daniel Shahaf
2020-03-20 18:28 ` Daniel Shahaf
2020-03-20 18:36 ` Bart Schaefer
2020-03-20 19:38 ` Daniel Shahaf
2020-03-20 18:39 ` Bart Schaefer
2020-03-20 19:32 ` Daniel Shahaf
2020-03-20 19:18 ` Daniel Shahaf
2020-03-23 5:31 ` Jun T
2020-03-24 2:08 ` Daniel Shahaf
2020-03-23 5:41 ` Jun T
2020-03-24 1:33 ` Jun T
2020-03-24 2:43 ` Daniel Shahaf
2020-03-25 0:16 ` Jun T
2020-03-25 22:04 ` Daniel Shahaf
2020-03-25 23:42 ` [PATCH] find RLIM_NLIMITS correctly on CygwinjL Daniel Shahaf
2020-03-24 2:34 ` [PATCH] find RLIM_NLIMITS correctly on Cygwin Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0b67dd8-932b-4438-b361-001e231febb0@www.fastmail.com \
--to=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).