From: Sebastian Gniazdowski <sgniazdowski@gmail.com>
To: Roman Perepelitsa <roman.perepelitsa@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: A serious bug in execution – where to debug?
Date: Tue, 30 Jul 2019 20:53:13 +0200 [thread overview]
Message-ID: <CAKc7PVBeVzKHeeq_kFfbMhx7iF-nBnk2O4dSJVtXCoZW=517pQ@mail.gmail.com> (raw)
In-Reply-To: <CAN=4vMqYCXz79kVoUN6dN7psOdcGmF-i2XGtccXZgd+Ti1fkEg@mail.gmail.com>
On Tue, 30 Jul 2019 at 20:22, Roman Perepelitsa
<roman.perepelitsa@gmail.com> wrote:
>
> On Tue, Jul 30, 2019 at 8:16 PM Sebastian Gniazdowski
> <sgniazdowski@gmail.com> wrote:
> >
> > On Tue, 30 Jul 2019 at 20:12, Roman Perepelitsa
> > <roman.perepelitsa@gmail.com> wrote:
> > >
> > > On Tue, Jul 30, 2019 at 7:55 PM Sebastian Gniazdowski
> > > <sgniazdowski@gmail.com> wrote:
> > No. I guess that the temp-files removal can be easily added – by
> > shadowing mktemp call. I didn't think about killing of the background
> > processes. I guess this too can be added, but I suspect that most of
> > them will be invisible in $jobtexts, i.e. disowned, so it might get
> > hard. Thanks for the suggestions. How are you running the gitstatus
> > process in the plugin?
>
> Do you think it's possible to implement clean shutdown and reentrant
> initialization for a piece of code as blackbox?
What do you mean exactly? As a blackbox - as a regular, repeatable method?
> gitstatusd and p10k both have clean shutdown in their public APIs. It
> was quite difficult to implement. By using this API you release all
> resources and can initialize the plugins once again within the same
> shell. However, if you unset internal variables or close file
> descriptors, or fail to kill daemons, you are in undefined behavior
> land and all bets are off.
This might be a good use case for the proposed unload function
(http://zdharma.org/Zsh-100-Commits-Club/Zsh-Plugin-Standard.html#unload-fun).
If you would provide a function powerlevel10k_unload_plugin, then I
would call it in Zplugin when unloading the plugin, allowing the
function to close the background process.
--
Sebastian Gniazdowski
News: https://twitter.com/ZdharmaI
IRC: https://kiwiirc.com/client/chat.freenode.net:+6697/#zplugin
Blog: http://zdharma.org
next prev parent reply other threads:[~2019-07-30 21:00 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 17:00 Sebastian Gniazdowski
2019-07-30 17:05 ` Sebastian Gniazdowski
2019-07-30 17:41 ` Roman Perepelitsa
2019-07-30 17:55 ` Sebastian Gniazdowski
2019-07-30 18:12 ` Roman Perepelitsa
2019-07-30 18:16 ` Sebastian Gniazdowski
2019-07-30 18:22 ` Roman Perepelitsa
2019-07-30 18:53 ` Sebastian Gniazdowski [this message]
2019-07-30 19:23 ` Roman Perepelitsa
2019-07-30 19:34 ` Sebastian Gniazdowski
2019-07-30 19:41 ` Roman Perepelitsa
2019-07-30 19:59 ` Sebastian Gniazdowski
2019-07-30 20:08 ` Roman Perepelitsa
2019-07-30 20:38 ` Sebastian Gniazdowski
2019-07-30 18:27 ` Bart Schaefer
2019-07-30 18:46 ` Sebastian Gniazdowski
2019-07-30 21:02 ` Roman Perepelitsa
2019-07-30 21:38 ` Sebastian Gniazdowski
2019-07-30 21:45 ` Roman Perepelitsa
2019-07-30 21:54 ` Sebastian Gniazdowski
2019-07-30 22:11 ` Roman Perepelitsa
2019-07-30 22:18 ` Daniel Shahaf
2019-07-30 22:32 ` Roman Perepelitsa
2019-07-31 1:30 ` Sebastian Gniazdowski
2019-07-31 7:23 ` Roman Perepelitsa
2019-07-31 11:41 ` Sebastian Gniazdowski
2019-07-31 12:40 ` Roman Perepelitsa
2019-07-31 13:10 ` Sebastian Gniazdowski
2019-07-31 13:34 ` Roman Perepelitsa
2019-07-31 13:40 ` Sebastian Gniazdowski
2019-07-31 14:11 ` Roman Perepelitsa
2019-07-31 17:56 ` Sebastian Gniazdowski
2019-07-31 1:42 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKc7PVBeVzKHeeq_kFfbMhx7iF-nBnk2O4dSJVtXCoZW=517pQ@mail.gmail.com' \
--to=sgniazdowski@gmail.com \
--cc=roman.perepelitsa@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).