From: Roman Perepelitsa <roman.perepelitsa@gmail.com>
To: Sebastian Gniazdowski <sgniazdowski@gmail.com>
Cc: Bart Schaefer <schaefer@brasslantern.com>,
Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: A serious bug in execution – where to debug?
Date: Wed, 31 Jul 2019 00:11:53 +0200 [thread overview]
Message-ID: <CAN=4vMpAPEMAnGR8LnFRGn221sZOgPspLjwQr_g8LV_XoSHsoA@mail.gmail.com> (raw)
In-Reply-To: <CAKc7PVC__sg3j6ujohd1qU_chmRFECsE=VFamC3egBs4qhM2_w@mail.gmail.com>
On Tue, Jul 30, 2019 at 11:54 PM Sebastian Gniazdowski
<sgniazdowski@gmail.com> wrote:
>
> On Tue, 30 Jul 2019 at 23:45, Roman Perepelitsa
> <roman.perepelitsa@gmail.com> wrote:
> >
> > On Tue, Jul 30, 2019 at 11:38 PM Sebastian Gniazdowski
> > <sgniazdowski@gmail.com> wrote:
> I avoided localoptions for performance – it consumes some time, as it
> (probably, but the performance effect is confirmed) allocates a new
> table of options and fills it with defaults. So I've decided to write
> an option-transparent code. But turns out that this might be hard in
> case of such options as errreturn. I'll think about whether to replace
> inline conditions with if-then or to do emulate -L.
Keep in mind that 5.4 (I think it was 5.4) had a bug where a false
condition under `if` was causing the function to return if err_return
is set. Same with `while` -- it would return from the function at the
end of iteration. 5.4 is still very popular.
My solution for the performance problem is to call `emulate -L zsh`
only at the points of entry (public API) and then avoid calling too
many small functions.
Roman.
next prev parent reply other threads:[~2019-07-30 22:12 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 17:00 Sebastian Gniazdowski
2019-07-30 17:05 ` Sebastian Gniazdowski
2019-07-30 17:41 ` Roman Perepelitsa
2019-07-30 17:55 ` Sebastian Gniazdowski
2019-07-30 18:12 ` Roman Perepelitsa
2019-07-30 18:16 ` Sebastian Gniazdowski
2019-07-30 18:22 ` Roman Perepelitsa
2019-07-30 18:53 ` Sebastian Gniazdowski
2019-07-30 19:23 ` Roman Perepelitsa
2019-07-30 19:34 ` Sebastian Gniazdowski
2019-07-30 19:41 ` Roman Perepelitsa
2019-07-30 19:59 ` Sebastian Gniazdowski
2019-07-30 20:08 ` Roman Perepelitsa
2019-07-30 20:38 ` Sebastian Gniazdowski
2019-07-30 18:27 ` Bart Schaefer
2019-07-30 18:46 ` Sebastian Gniazdowski
2019-07-30 21:02 ` Roman Perepelitsa
2019-07-30 21:38 ` Sebastian Gniazdowski
2019-07-30 21:45 ` Roman Perepelitsa
2019-07-30 21:54 ` Sebastian Gniazdowski
2019-07-30 22:11 ` Roman Perepelitsa [this message]
2019-07-30 22:18 ` Daniel Shahaf
2019-07-30 22:32 ` Roman Perepelitsa
2019-07-31 1:30 ` Sebastian Gniazdowski
2019-07-31 7:23 ` Roman Perepelitsa
2019-07-31 11:41 ` Sebastian Gniazdowski
2019-07-31 12:40 ` Roman Perepelitsa
2019-07-31 13:10 ` Sebastian Gniazdowski
2019-07-31 13:34 ` Roman Perepelitsa
2019-07-31 13:40 ` Sebastian Gniazdowski
2019-07-31 14:11 ` Roman Perepelitsa
2019-07-31 17:56 ` Sebastian Gniazdowski
2019-07-31 1:42 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN=4vMpAPEMAnGR8LnFRGn221sZOgPspLjwQr_g8LV_XoSHsoA@mail.gmail.com' \
--to=roman.perepelitsa@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=sgniazdowski@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).