From: yaroslav <yarikos@gmail.com>
To: 9fans@9fans.net
Subject: Re: [9fans] u9fs(4) misuses Fcall.afid in its p9any authentication module
Date: Wed, 27 Nov 2013 15:38:18 +0200 [thread overview]
Message-ID: <09f98b3b362b408d3d18f16d26c3b671@isd.dp.ua> (raw)
> > /sys/src/cmd/unix/u9fs/authp9any.c
> > authp9any.c.orig:369,375 - /n/sources/patch/u9fs-afid/authp9any.c:369,378
> > fprint(2, "p9anyattach: afid %d state %d\n", rx->afid, sp->state);
> > if (sp->state == Established && strcmp(rx->uname, sp->uname) == 0
> > && strcmp(rx->aname, sp->aname) == 0)
> > + {
> > + rx->uname = sp->t.suid; /* will be valid until afid is clunked */
> > return nil;
> > + }
> > return "authentication failed";
> > }
>
> without commont on correctness, braces go on the
> line on which the if condition ends.
>
> - erik
>
The patch has been updated.
BTW, this change was after http://9fans.net/archive/2011/10/157 which
I hadn't then submitted; this time it slipped through.
It worth's to stay though, IMO.
next reply other threads:[~2013-11-27 13:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 13:38 yaroslav [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-11-27 10:00 yaroslav
2013-11-27 10:15 ` erik quanstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09f98b3b362b408d3d18f16d26c3b671@isd.dp.ua \
--to=yarikos@gmail.com \
--cc=9fans@9fans.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).