9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
* Re: [9fans] Question on mapping 0xfff00000
@ 2001-03-21  1:30 jmk
  2001-03-24  1:43 ` Ronald G Minnich
  0 siblings, 1 reply; 3+ messages in thread
From: jmk @ 2001-03-21  1:30 UTC (permalink / raw)
  To: 9fans

On Tue Mar 20 01:07:24 EST 2001, rminnich@lanl.gov wrote:
> 
> I need to map FLASH at 0xfff00000 into my flash driver. I have tried a
> number of variations, and keep coming back to:
> 
> flashbase = upamalloc(0xfff00000, 0x100000, 0);
> 
> Return value is 0xfff00000. But, any reference to this address provokes a
> fault, which leaves me believing I've got this wrong, even though a walk
> through that code also looks like it does set up the PTEs in the right
> way. The southbridge chip (PIIX4E) also has the right bits set to enable
> FLASH at these high addresses, and I've tested those settings in Linux.
> 
> The general problem is to map the last 2M of the 32-bit address space into
> memory, since on many boards that is the "reserved for BIOS flash" area.
> 
> What am I doing wrong? What's the right way to do this. I'm new to this
> kernel, needless to say. I'm also very happy it is now open source ...
> 
> ron

Looks like an arithmetic overflow problem. The clue is that the return
should be the ending address of the successfully mapped area. But if you
add 0xfff00000+0x100000 you get 0x100000000, which is 0 in 32-bits and the
mapping loop in mmu.c:^mmukmap() is

	pae = pa + size;
	lock(&mmukmaplock);
	while(pa < pae){

where pa = 0xfff00000 and size = 0x100000, so the loop will not be entered.

you could try rewriting the loop to be something like

	while(size > 0){
		...

and wherever you see
		pa += pgsz;
in the loop add
		size =- pgsz;
after it.

I think the comment in /sys/src/boot/pc/memory.c:^upamalloc() (which
contains the same mapping code) says it all. The whole memory thing is
slated for a rewrite but try the above suggestion and let me know how
it turns out.

--jim


^ permalink raw reply	[flat|nested] 3+ messages in thread
* [9fans] Question on mapping 0xfff00000
@ 2001-03-20  6:06 Ronald G Minnich
  0 siblings, 0 replies; 3+ messages in thread
From: Ronald G Minnich @ 2001-03-20  6:06 UTC (permalink / raw)
  To: 9fans


I need to map FLASH at 0xfff00000 into my flash driver. I have tried a
number of variations, and keep coming back to:

flashbase = upamalloc(0xfff00000, 0x100000, 0);

Return value is 0xfff00000. But, any reference to this address provokes a
fault, which leaves me believing I've got this wrong, even though a walk
through that code also looks like it does set up the PTEs in the right
way. The southbridge chip (PIIX4E) also has the right bits set to enable
FLASH at these high addresses, and I've tested those settings in Linux.

The general problem is to map the last 2M of the 32-bit address space into
memory, since on many boards that is the "reserved for BIOS flash" area.

What am I doing wrong? What's the right way to do this. I'm new to this
kernel, needless to say. I'm also very happy it is now open source ...

ron



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2001-03-24  1:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-03-21  1:30 [9fans] Question on mapping 0xfff00000 jmk
2001-03-24  1:43 ` Ronald G Minnich
  -- strict thread matches above, loose matches on Subject: below --
2001-03-20  6:06 Ronald G Minnich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).