9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
* Re: [9fans] Arg fix
@ 2001-05-28 17:11 rob pike
  0 siblings, 0 replies; 2+ messages in thread
From: rob pike @ 2001-05-28 17:11 UTC (permalink / raw)
  To: 9fans

I have now installed a correct wrap file.

-rob

===

Due to an editing mistake - mine - I omitted some cleanup code for the
newest wrap.  It was in the original code, I just dropped it from the wrap.
How embarrassing.

Add the following to newproc(), creating /sys/src/9/port/proc.c:347,349

	free(p->args);
	p->args = nil;
	p->nargs = 0;

It's not a huge problem, because sysexec frees the old args. The effect
of this mistake is to cause a process that forks without exec'ing to pick
up some stale, irrelevant arguments.

I'll update the files on the web later today.

-rob



^ permalink raw reply	[flat|nested] 2+ messages in thread

* [9fans] Arg fix
@ 2001-05-28 14:46 rob pike
  0 siblings, 0 replies; 2+ messages in thread
From: rob pike @ 2001-05-28 14:46 UTC (permalink / raw)
  To: 9fans

Due to an editing mistake - mine - I omitted some cleanup code for the
newest wrap.  It was in the original code, I just dropped it from the wrap.
How embarrassing.

Add the following to newproc(), creating /sys/src/9/port/proc.c:347,349

	free(p->args);
	p->args = nil;
	p->nargs = 0;

It's not a huge problem, because sysexec frees the old args. The effect
of this mistake is to cause a process that forks without exec'ing to pick
up some stale, irrelevant arguments.

I'll update the files on the web later today.

-rob



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2001-05-28 17:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-05-28 17:11 [9fans] Arg fix rob pike
  -- strict thread matches above, loose matches on Subject: below --
2001-05-28 14:46 rob pike

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).