Re: [9fans] lucio-

["Russ Cox" <rsc@plan9.bell-labs.com>]

[-- Attachment #1: Type: text/plain, Size: 1301 bytes --]

> No offense meant, but doesn't this show precisely what CVS's strength
> is?  Had you recorded the fix, we wouldn't be still looking for it :-)

It shows that I should keep better
records of what I do each day.

Even if I had the CVS source under
CVS, I probably would have thrown out
the repository when I ported the new one.
Further, I'm not sure whether the bug was
in CVS or in APE.

If I remembered what was broken,
I could run history to find it.

Case in point: I just found it, by
poking around for files in /sys/src/ape
modified about the same date as when I
ported the new CVS (which I remember being
near when I found the bug).

CVS wouldn't have helped any more than the
dump here.

The bug is in /sys/src/ape/lib/ap/plan9/getcwd.c.
Replace the entire file with:

#include "lib.h"
#include <stddef.h>
#include <stdlib.h>
#include <unistd.h>
#include <errno.h>
#include <string.h>
#include <stdio.h>
#include "sys9.h"
#include "dir.h"

char*
getcwd(char *buf, size_t len)
{
	int fd;

	fd = _OPEN(".", OREAD);
	if(fd < 0) {
		errno = EACCES;
		return 0;
	}
	if(_FD2PATH(fd, buf, len) < 0) {
		errno = EIO;
		_CLOSE(fd);
		return 0;
	}
	_CLOSE(fd);

	return buf;
}

Exercise to the reader: find the fd leak in the
original.

Russ

[-- Attachment #2: Type: message/rfc822, Size: 2436 bytes --]

From: Lucio De Re <lucio@proxima.alt.za>
To: 9fans@cse.psu.edu
Subject: Re: [9fans] lucio-
Date: Wed, 9 Jan 2002 06:52:59 +0200
Message-ID: <20020109065259.G12098@cackle.proxima.alt.za>

On Tue, Jan 08, 2002 at 10:06:45PM -0500, Russ Cox wrote:
>
> For the list, I've fixed this bug before.
> I remember it being a neat bug, but I don't
> remember what it was.  Once Lucio and I figure
> it out again, one of us will post what the
> problem was.  Perhaps it was cvs, perhaps APE,
> perhaps some weird interaction between the
> two.  I've been trying to remember all day.
>
No offense meant, but doesn't this show precisely what CVS's strength
is?  Had you recorded the fix, we wouldn't be still looking for it :-)

But I agree wholeheartedly that CVS is only a partial solution and
that the needs it attempts to address vary widely.  I'm tempted to
create a mailing list specially to discuss a CVS-like development
that merges the Plan 9 backup technology into it.  Any takers?

++L