[9fans] ape strtod crash

[9fans] ape strtod crash

[roger peppe]

this ape program gives a floating point exception error:

#include <stdlib.h>
void
main(){
	strtod("421567849e316", 0);
}

this made awk crash when i was running dumpvacroots.
it dies at /sys/src/ape/lib/ap/stdio/strtod.c:473
but it looks a bit involved for me to dive into right now,
i'm afraid.

Re: [9fans] ape strtod crash

[erik quanstrom]

On Thu Jul 30 04:42:29 EDT 2009, rogpeppe@gmail.com wrote:
> this ape program gives a floating point exception error:
>
> #include <stdlib.h>
> void
> main(){
> 	strtod("421567849e316", 0);
> }
>
> this made awk crash when i was running dumpvacroots.
> it dies at /sys/src/ape/lib/ap/stdio/strtod.c:473
> but it looks a bit involved for me to dive into right now,
> i'm afraid.
>

fixed,

http://9fans.net/archive/2009/01/234

- erik

Re: [9fans] ape strtod crash

[roger peppe]

2009/7/30 erik quanstrom <quanstro@quanstro.net>:
> fixed,
>
> http://9fans.net/archive/2009/01/234

ok, thanks, i had a very vague memory of this, but obviously
my googling was inadequate.

did you submit a patch? i can't see one.
i will if not - it's an annoying error.

(and, as you say, why not just use the usual strtod?)

Re: [9fans] ape strtod crash

[erik quanstrom]

On Thu Jul 30 08:18:45 EDT 2009, rogpeppe@gmail.com wrote:
> 2009/7/30 erik quanstrom <quanstro@quanstro.net>:
> > fixed,
> >
> > http://9fans.net/archive/2009/01/234
>
> ok, thanks, i had a very vague memory of this, but obviously
> my googling was inadequate.
>
> did you submit a patch? i can't see one.
> i will if not - it's an annoying error.

i'm sorry.  i wasn't sure this patch met the standards,
and then i forgot about it.  i've found that patches
like this are hard to go far enough yet not go too
far.

/n/sources/patch/apestrtod.

here's a demonstration of the fix.  awk is sufficient
to demonstrate the problem with the number you mention.

; echo 421567849e316 | /n/sources/plan9/386/bin/awk '{print}'
421567849e316
; 9fs sources
; ; echo 421567849e316 | /n/sources/plan9/386/bin/awk '{print}'
/n/sources/plan9/386/bin/awk: floating point exception 6
 source line 1

>
> (and, as you say, why not just use the usual strtod?)
>

a partial answer is in /sys/src/ape/lib/fmt/strtod.c's comments.
there are cases were ERANGE is appropriate in unix land.

this is the hard question.  perhaps dumping ape stdio's strtod
and editing the usual one to fit unix's model would be the right
plan.

- erik

Re: [9fans] ape strtod crash

[erik quanstrom]

!> ; echo 421567849e316 | awk '{print}'
> 421567849e316
> ; 9fs sources
> ; ; echo 421567849e316 | /n/sources/plan9/386/bin/awk '{print}'
> /n/sources/plan9/386/bin/awk: floating point exception 6
>  source line 1

- erik