[9fans] duplicate uid in fossil

[9fans] duplicate uid in fossil

[Kenji Arisawa]

Hello,

I'm stupid enough to add a user that is already registered in fossil.
The result is:

hera# fossil/fossil -c '. '$v/flproto
nuser 4
diskThread 782
fs->ehi 4789 fs->elo 1 active=76750
got fs source
got file root
nuser 28
duplicate uid 'alice'
assert failed: box->nuser == nuser
fossil 777: suicide: sys: trap: fault read addr=0x0 pc=0x0002a89f

How can I remove duplicate uid?

Kenji Arisawa

Re: [9fans] duplicate uid in fossil

[boyd, rounin]

gaijin dakara wakaranai ...

Re: [9fans] duplicate uid in fossil

[andrey mirtchovski]

do you have a venti to restore from? or scores from fossil snapshots?

by the way, fossil-related man pages don't appear on the web at the moment
(http://plan9.bell-labs.com/sys/man/index.html) but i think it may be
possible to reset the user groups with '-d'(?).. or somesuch argument to
fossil. sorry, no access to a plan9 installation to verify right now.

On Fri, 22 Aug 2003, Kenji Arisawa wrote:

> Hello,
>
> I'm stupid enough to add a user that is already registered in fossil.
> The result is:
>
> hera# fossil/fossil -c '. '$v/flproto
> nuser 4
> diskThread 782
> fs->ehi 4789 fs->elo 1 active=76750
> got fs source
> got file root
> nuser 28
> duplicate uid 'alice'
> assert failed: box->nuser == nuser
> fossil 777: suicide: sys: trap: fault read addr=0x0 pc=0x0002a89f
>
> How can I remove duplicate uid?
>
> Kenji Arisawa
>

Re: [9fans] duplicate uid in fossil

[jmk]

If you can recompile fossil somewhere, then just take that assert out.
The code for reading the users file strips out duplicates so only the first
instance will be used. Once the system is up you will have to write the
file back out with 'users -w' to permanently remove the duplicate. The
decision to automatically read the users file on opening main was arguably
wrong.

However, you are not supposed to be able to create duplicate entries
if you use the console commands - how did you do it?

On Fri Aug 22 00:21:29 EDT 2003, arisawa@ar.aichi-u.ac.jp wrote:
> Hello,
>
> I'm stupid enough to add a user that is already registered in fossil.
> The result is:
>
> hera# fossil/fossil -c '. '$v/flproto
> nuser 4
> diskThread 782
> fs->ehi 4789 fs->elo 1 active=76750
> got fs source
> got file root
> nuser 28
> duplicate uid 'alice'
> assert failed: box->nuser == nuser
> fossil 777: suicide: sys: trap: fault read addr=0x0 pc=0x0002a89f
>
> How can I remove duplicate uid?
>
> Kenji Arisawa

Re: [9fans] duplicate uid in fossil

[Kenji Arisawa]

Hello,

  >i think it may be possible to reset the user groups with '-d'(?).. or

Thanks, but it seems '-d' is no help because:
	Users -r /active/adm/users is automatically executed when
           the file system main is opened.
and then suicide.

I think duplicate lines in adm/users should be ignored by fossil.

Kenji Arisawa

Re: [9fans] duplicate uid in fossil

[Kenji Arisawa]

Hello,

> If you can recompile fossil somewhere, then just take that assert out.

Thanks jim. I tried to recompile fossil, but...

hera# mk
8c -FVw fossil.c
8c -FVw 9p.c
8c -FVw 9auth.c
8c -FVw 9dir.c
8c -FVw 9excl.c
8c -FVw 9fid.c
8c -FVw 9fsys.c
9fsys.c:359 not enough function arguments: snapGetTimes
9fsys.c:393 not enough function arguments: snapSetTimes
9fsys.c:394 not enough function arguments: snapGetTimes
9fsys.c:468 argument prototype mismatch "IND STRUCT Fs" for "IND STRUCT
File": fileClri
mk: 8c -FVw 9fsys.c  : exit status=rc 881: 8c 883: error
hera#

I did
	replica/pull
yesterday.

hera# ls -l
--rw-rw-r-- M 5531 bootes sys  4129 Jun 16 04:02 9.h
--rw-rw-r-- M 5531 bootes sys  3394 Apr 17 03:49 9auth.c
--rw-rw-r-- M 5531 bootes sys  1995 Jan  8  2003 9dir.c
--rw-rw-r-- M 5531 bootes sys  1887 Jan  8  2003 9excl.c
--rw-rw-r-- M 5531 bootes sys  5521 Feb 19  2003 9fid.c
--rw-rw-r-- M 5531 bootes sys 29755 Jun 16 04:02 9fsys.c
--rw-rw-r-- M 5531 bootes sys  2865 Jan  8  2003 9lstn.c
--rw-rw-r-- M 5531 bootes sys 21416 Jun 16 04:02 9p.c
--rw-rw-r-- M 5531 bootes sys  1563 Jan  8  2003 9ping.c
--rw-rw-r-- M 5531 bootes sys 15245 Apr 17 03:49 9proc.c
--rw-rw-r-- M 5531 bootes sys  3589 Jun 16 04:02 9srv.c
--rw-rw-r-- M 5531 bootes sys 17240 Jun 16 04:02 9user.c
--rw-rw-r-- M 5531 bootes sys  1624 Jan  8  2003 Ccli.c
--rw-rw-r-- M 5531 bootes sys  7246 Apr 17 03:49 Ccmd.c
--rw-rw-r-- M 5531 bootes sys  6620 Jun 16 04:02 Ccons.c
--rw-rw-r-- M 5531 bootes sys   591 Jan  8  2003 Clog.c
--rw-rw-r-- M 5531 bootes sys  9112 Feb 19  2003 archive.c
--rw-rw-r-- M 5531 bootes sys   449 Jan  8  2003 build
--rwxrwxr-x M 5531 bootes sys   561 Jan  8  2003 buildsh
--rw-rw-r-- M 5531 bootes sys  6754 Jan  8  2003 bwatch.c
--rw-rw-r-- M 5531 bootes sys 42854 Jun 16 04:02 cache.c
--rwxrwxr-x M 5531 bootes sys  1407 Jun 16 04:02 conf.rc
--rw-rw-r-- M 5531 bootes sys  7855 Apr 17 03:49 dat.h
--rwxrwxr-x M 5531 bootes sys   413 Jan  8  2003 deadlock
--rw-rw-r-- M 5531 bootes sys  5809 Jun 16 04:02 disk.c
--rw-rw-r-- M 5531 bootes sys  1340 Jan  8  2003 dump.c
--rw-rw-r-- M 5531 bootes sys   997 Feb 19  2003 epoch.c
--rw-rw-r-- M 5531 bootes sys  1367 Jan  8  2003 error.c
--rw-rw-r-- M 5531 bootes sys   744 Jan  8  2003 error.h
--rw-rw-r-- M 5531 bootes sys 27846 Jun 16 04:02 file.c
--rw-rw-r-- M 5531 bootes sys 14275 Mar 28 22:49 flchk.c
--rw-rw-r-- M 5531 bootes sys 10368 Mar 28 22:49 flfmt.c
--rw-rw-r-- M 5531 bootes sys   210 Jan  8  2003 flproto
--rw-rw-r-- M 5531 bootes sys  3039 Jun 16 04:02 fns.h
--rw-rw-r-- M 5531 bootes sys  3965 Jan  8  2003 fossil-acid
--rw-rw-r-- M 5531 bootes sys  2113 Jun 16 04:02 fossil.c
--rw-rw-r-- M 5531 bootes sys 21075 Jun 16 04:02 fs.c
--rw-rw-r-- M 5531 bootes sys  1398 Jun 16 04:02 fs.h
--rw-rw-r-- M 5531 bootes sys  1400 Jun 16 04:03 history
--rw-rw-r-- M 5531 bootes sys  4073 Jan  8  2003 invariants
--rw-rw-r-- M 5531 bootes sys  1842 Jun 16 04:02 mkfile
--rw-rw-r-- M 5531 bootes sys   329 Jan  8  2003 nobwatch.c
--rw-rw-r-- M 5531 bootes sys  4683 Jan  8  2003 pack.c
--rw-rw-r-- M 5531 bootes sys  1091 Jan  8  2003 periodic.c
--rw-rw-r-- M 5531 bootes sys 18778 Jun 16 04:02 source.c
--rw-rw-r-- M 5531 bootes sys  4178 Jan  8  2003 srcload.c
--rw-rw-r-- M 5531 bootes sys   155 Jan  8  2003 stdinc.h
--rw-rw-r-- M 5531 bootes sys   280 Jan  8  2003 trunc.c
--rwxrwxr-x M 5531 bootes sys   286 Jan  8  2003 unpack
--rw-rw-r-- M 5531 bootes sys 12497 Jan  8  2003 vac.c
--rw-rw-r-- M 5531 bootes sys  2782 Jan  8  2003 vac.h
--rw-rw-r-- M 5531 bootes sys 19708 Jan  8  2003 view.c
--rw-rw-r-- M 5531 bootes sys   963 Jan  8  2003 walk.c
hera#

What wrong? And what should I do?

Kenji Arisawa

Re: [9fans] duplicate uid in fossil

[jmk]

[-- Attachment #1: Type: text/plain, Size: 92 bytes --]

i've updated sources with what is in our /sys/src (i checked it
compiled first). try again.

[-- Attachment #2: Type: message/rfc822, Size: 5687 bytes --]

From: Kenji Arisawa <arisawa@ar.aichi-u.ac.jp>
To: 9fans@cse.psu.edu
Subject: Re: [9fans] duplicate uid in fossil
Date: Fri, 22 Aug 2003 14:36:13 +0900
Message-ID: <8ACFF52D-D462-11D7-A9CA-000393A941BC@ar.aichi-u.ac.jp>

Hello,

> If you can recompile fossil somewhere, then just take that assert out.

Thanks jim. I tried to recompile fossil, but...

hera# mk
8c -FVw fossil.c
8c -FVw 9p.c
8c -FVw 9auth.c
8c -FVw 9dir.c
8c -FVw 9excl.c
8c -FVw 9fid.c
8c -FVw 9fsys.c
9fsys.c:359 not enough function arguments: snapGetTimes
9fsys.c:393 not enough function arguments: snapSetTimes
9fsys.c:394 not enough function arguments: snapGetTimes
9fsys.c:468 argument prototype mismatch "IND STRUCT Fs" for "IND STRUCT
File": fileClri
mk: 8c -FVw 9fsys.c  : exit status=rc 881: 8c 883: error
hera#

I did
	replica/pull
yesterday.

hera# ls -l
--rw-rw-r-- M 5531 bootes sys  4129 Jun 16 04:02 9.h
--rw-rw-r-- M 5531 bootes sys  3394 Apr 17 03:49 9auth.c
--rw-rw-r-- M 5531 bootes sys  1995 Jan  8  2003 9dir.c
--rw-rw-r-- M 5531 bootes sys  1887 Jan  8  2003 9excl.c
--rw-rw-r-- M 5531 bootes sys  5521 Feb 19  2003 9fid.c
--rw-rw-r-- M 5531 bootes sys 29755 Jun 16 04:02 9fsys.c
--rw-rw-r-- M 5531 bootes sys  2865 Jan  8  2003 9lstn.c
--rw-rw-r-- M 5531 bootes sys 21416 Jun 16 04:02 9p.c
--rw-rw-r-- M 5531 bootes sys  1563 Jan  8  2003 9ping.c
--rw-rw-r-- M 5531 bootes sys 15245 Apr 17 03:49 9proc.c
--rw-rw-r-- M 5531 bootes sys  3589 Jun 16 04:02 9srv.c
--rw-rw-r-- M 5531 bootes sys 17240 Jun 16 04:02 9user.c
--rw-rw-r-- M 5531 bootes sys  1624 Jan  8  2003 Ccli.c
--rw-rw-r-- M 5531 bootes sys  7246 Apr 17 03:49 Ccmd.c
--rw-rw-r-- M 5531 bootes sys  6620 Jun 16 04:02 Ccons.c
--rw-rw-r-- M 5531 bootes sys   591 Jan  8  2003 Clog.c
--rw-rw-r-- M 5531 bootes sys  9112 Feb 19  2003 archive.c
--rw-rw-r-- M 5531 bootes sys   449 Jan  8  2003 build
--rwxrwxr-x M 5531 bootes sys   561 Jan  8  2003 buildsh
--rw-rw-r-- M 5531 bootes sys  6754 Jan  8  2003 bwatch.c
--rw-rw-r-- M 5531 bootes sys 42854 Jun 16 04:02 cache.c
--rwxrwxr-x M 5531 bootes sys  1407 Jun 16 04:02 conf.rc
--rw-rw-r-- M 5531 bootes sys  7855 Apr 17 03:49 dat.h
--rwxrwxr-x M 5531 bootes sys   413 Jan  8  2003 deadlock
--rw-rw-r-- M 5531 bootes sys  5809 Jun 16 04:02 disk.c
--rw-rw-r-- M 5531 bootes sys  1340 Jan  8  2003 dump.c
--rw-rw-r-- M 5531 bootes sys   997 Feb 19  2003 epoch.c
--rw-rw-r-- M 5531 bootes sys  1367 Jan  8  2003 error.c
--rw-rw-r-- M 5531 bootes sys   744 Jan  8  2003 error.h
--rw-rw-r-- M 5531 bootes sys 27846 Jun 16 04:02 file.c
--rw-rw-r-- M 5531 bootes sys 14275 Mar 28 22:49 flchk.c
--rw-rw-r-- M 5531 bootes sys 10368 Mar 28 22:49 flfmt.c
--rw-rw-r-- M 5531 bootes sys   210 Jan  8  2003 flproto
--rw-rw-r-- M 5531 bootes sys  3039 Jun 16 04:02 fns.h
--rw-rw-r-- M 5531 bootes sys  3965 Jan  8  2003 fossil-acid
--rw-rw-r-- M 5531 bootes sys  2113 Jun 16 04:02 fossil.c
--rw-rw-r-- M 5531 bootes sys 21075 Jun 16 04:02 fs.c
--rw-rw-r-- M 5531 bootes sys  1398 Jun 16 04:02 fs.h
--rw-rw-r-- M 5531 bootes sys  1400 Jun 16 04:03 history
--rw-rw-r-- M 5531 bootes sys  4073 Jan  8  2003 invariants
--rw-rw-r-- M 5531 bootes sys  1842 Jun 16 04:02 mkfile
--rw-rw-r-- M 5531 bootes sys   329 Jan  8  2003 nobwatch.c
--rw-rw-r-- M 5531 bootes sys  4683 Jan  8  2003 pack.c
--rw-rw-r-- M 5531 bootes sys  1091 Jan  8  2003 periodic.c
--rw-rw-r-- M 5531 bootes sys 18778 Jun 16 04:02 source.c
--rw-rw-r-- M 5531 bootes sys  4178 Jan  8  2003 srcload.c
--rw-rw-r-- M 5531 bootes sys   155 Jan  8  2003 stdinc.h
--rw-rw-r-- M 5531 bootes sys   280 Jan  8  2003 trunc.c
--rwxrwxr-x M 5531 bootes sys   286 Jan  8  2003 unpack
--rw-rw-r-- M 5531 bootes sys 12497 Jan  8  2003 vac.c
--rw-rw-r-- M 5531 bootes sys  2782 Jan  8  2003 vac.h
--rw-rw-r-- M 5531 bootes sys 19708 Jan  8  2003 view.c
--rw-rw-r-- M 5531 bootes sys   963 Jan  8  2003 walk.c
hera#

What wrong? And what should I do?

Kenji Arisawa

Re: [9fans] duplicate uid in fossil

[Kenji Arisawa]

Hello,

I said:
hera# mk
8c -FVw fossil.c
...
mk: 8c -FVw 9fsys.c  : exit status=rc 881: 8c 883: error
hera#

However this was my mistake.
Sorry.

I will soon examine new fossil

Kenji Arisawa

Re: [9fans] duplicate uid in fossil

[lucio]

>
> I edited /n/fossil/adm/users directly.
>
That's curious (no offence intended).  You'd think duplication would
be easy to spot, but perhaps you have a large number of users?  In
which case, can I recommend that you keep the file sorted, at least
below the default users?  It will make spotting duplications a whole
lot easier.  And with the new string identifiers instead of numeric
ones, it is less jarring to the eye.

++L

Re: [9fans] duplicate uid in fossil

[Kenji Arisawa]

Hello,

 >If you can recompile fossil somewhere, then just take that assert out.

Thanks jim, that is OK.

cpu% diff 9user.c 9user.c.bak
612c612
< //        assert(box->nuser == nuser);
---
 >       assert(box->nuser == nuser);


> However, you are not supposed to be able to create duplicate entries
> if you use the console commands - how did you do it?

I edited /n/fossil/adm/users directly.

Thanks again.

Kenji Arisawa

Re: [9fans] duplicate uid in fossil

[andrey mirtchovski]

On Fri, 22 Aug 2003 lucio@proxima.alt.za wrote:

> That's curious (no offence intended).  You'd think duplication would
> be easy to spot, but perhaps you have a large number of users?  In
> which case, can I recommend that you keep the file sorted, at least
> below the default users?  It will make spotting duplications a whole
> lot easier.  And with the new string identifiers instead of numeric
> ones, it is less jarring to the eye.
>

fossil keeps the file sorted (look at /adm/users on sources).

andrey

Re: [9fans] duplicate uid in fossil

[lucio]

>
> I said:
> 	I'm stupid ...
> but someone can also be stupid.
>
Not at all.  You made a mistake and it may be beneficial for others to
avoid making the same mistake.  Hence my curiosity.  It could easily
have happened to anyone else (I have a single user of my system, so
I'm an unlikely one, at least in the foreseeable future).

To be honest, I would not have figured out a solution, so I'm pleased
you raised the flag in the first place.

++L

Re: [9fans] duplicate uid in fossil

[Kenji Arisawa]

Hello,

>>
>> I edited /n/fossil/adm/users directly.
>>
> That's curious (no offence intended).  You'd think duplication would
> be easy to spot, but perhaps you have a large number of users?  In
> which case, can I recommend that you keep the file sorted, at least
> below the default users?  It will make spotting duplications a whole
> lot easier.  And with the new string identifiers instead of numeric
> ones, it is less jarring to the eye.

I said:
	I'm stupid ...
but someone can also be stupid.

Kenji Arisawa

Re: [9fans] duplicate uid in fossil

[jmk]

On Fri Aug 22 01:26:28 EDT 2003, uncover@beat.cc.titech.ac.jp wrote:
> > Thanks, but it seems '-d' is no help because:
> > 	Users -r /active/adm/users is automatically executed when
> >            the file system main is opened.
> > and then suicide.
>
> What if change the name `main' to other fs name like `other',
> create new `main' on some other fossil partition (could be a 1MB
> file on kfs), change /active/adm/users on `other'?
> --
> YAMANASHI Takeshi

An approach like that should also work. There's no need to
have a filesystem "main", just boot and use "other" directly.
Having a filesystem "main" just introduces some shortcuts
for the common attaches and, as we now know, an automatic
read on the users file.

Re: [9fans] duplicate uid in fossil

[YAMANASHI Takeshi]

> Thanks, but it seems '-d' is no help because:
> 	Users -r /active/adm/users is automatically executed when
>            the file system main is opened.
> and then suicide.

What if change the name `main' to other fs name like `other',
create new `main' on some other fossil partition (could be a 1MB
file on kfs), change /active/adm/users on `other'?
--
YAMANASHI Takeshi