From: erik quanstrom <quanstro@coraid.com>
To: 9fans@9fans.net
Subject: Re: [9fans] segattach off-by-one?
Date: Fri, 25 Sep 2009 14:32:05 -0400 [thread overview]
Message-ID: <466e12306dfbbfa15a65f17233b253e9@coraid.com> (raw)
In-Reply-To: <c9ec513f16d4318316f9c8d8883b6ca9@coraid.com>
the patch i posted yesterday was wrong. i forgot about
automatic address assigment with segattach. this works,
but perhaps it would be better to round va before checking
if va == 0?
/n/quanstro//sys/src/9/port/segment.c:642,648 - segment.c:642,648
Segment *s, *os;
Physseg *ps;
- if((va !=0 && va < BY2PG) || va >= USTKTOP)
+ if(va != 0 && va >= USTKTOP)
error(Ebadarg);
validaddr((ulong)name, 1, 0);
- erik
next prev parent reply other threads:[~2009-09-25 18:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <<f75780240909242033k11fb23a0o237f7dbedf9a7bee@mail.gmail.com>
2009-09-25 4:34 ` erik quanstrom
2009-09-25 18:01 ` Venkatesh Srinivas
2009-09-25 18:18 ` erik quanstrom
2009-09-25 18:32 ` erik quanstrom [this message]
2009-09-25 3:33 Venkatesh Srinivas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=466e12306dfbbfa15a65f17233b253e9@coraid.com \
--to=quanstro@coraid.com \
--cc=9fans@9fans.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).