Re: [9fans] corrections to /sys/src/cmd/8l/l.h

Re: [9fans] corrections to /sys/src/cmd/8l/l.h

[erik quanstrom]

On Wed Sep 30 00:30:19 EDT 2009, lucio@proxima.alt.za wrote:
> At the tail end of the module there is a shorter set of "#pragma
> varargck"s that repeats the entries earlier in the file, disagreeing
> with one of them.  The disagreeing entry matches the #pragma in
> /sys/src/cmd/vl/l.h so I'm not sure which ought to be used (or what
> effect the conflict has).
>

it's okay to have varargchk type's specify different types for the same
format letter, as long as each is valid.  for example, since uintptr and
void* are both valid arguments for #p, libc properly declares both okay.
in your case uint and int are both declared okay.  and it looks good
to me as the argument is used an index into a name array.  in fact,
due to c type promotion rules, one could also declare char, uchar,
short, ushort to be acceptable.  though evidently that's not needed.

duplicate entries should probablly deleted.  while you're at it, add
#pragma	varargck	argpos	diag		1

you will then be magicly informed of a few vararg botches.

- erik

Re: [9fans] corrections to /sys/src/cmd/8l/l.h

[sqweek]

2009/9/30  <lucio@proxima.alt.za>:
> PS: ELF output and other such issues is also on my list of things to
> check out, but it adds even more complexity to something that really
> confuses me already.

http://gsoc.cat-v.org/projects/kencc/

[9fans] corrections to /sys/src/cmd/8l/l.h

[lucio]

At the tail end of the module there is a shorter set of "#pragma
varargck"s that repeats the entries earlier in the file, disagreeing
with one of them.  The disagreeing entry matches the #pragma in
/sys/src/cmd/vl/l.h so I'm not sure which ought to be used (or what
effect the conflict has).

I'd like to see these corrected; there are other differences that seem
gratuitous, I won't mind tidying the whole lot up if it's deemed worth
it.

I have 8[acl] and v[acl] compiling error free on p9p (UBUNTU
Jaunty/386 and gNewSense/MIPS respectively) although I'm not sure
where I'm going with it, I have some vague idea of cross-development,
but I can't grasp the full multidimensionality of the exercise and I
fall asleep whenever I try to figure it out :-(

++L

PS: ELF output and other such issues is also on my list of things to
check out, but it adds even more complexity to something that really
confuses me already.