[9fans] ftpfs & fmtinstall woe

[9fans] ftpfs & fmtinstall woe

[boyd, rounin]

while ziphos and i were puzzling over why ftpfs spits the
dummy on newly mkdir'd directories we also found a
mssing %M fmtinstall, which acts curiously.

fmtinstall:

brahma% cat f.c
#include <u.h>
#include <libc.h>
#include <fcall.h>

main()
{
 Dir *d;

 if (fmtinstall('M', dirmodefmt) < 0)
  exits("fmtinstall");

 if ((d = dirstat(".")) == 0)
  exits("dirstat");

 print(". %M\n", *d);

 exits("");
}
brahma% 8c f.c && 8l f.8
brahma% ./8.out
. d---x--xr-x
brahma% ls -ld .
d-rwxr-xr-x M 289907 boyd boyd 0 May 21 21:03 src

--
MGRS 31U DQ 52572 12604

Re: [9fans] ftpfs & fmtinstall woe

[Russ Cox]

     FCALL(3)                                                 FCALL(3)

          Dirfmt, fcallfmt, and dirmodefmt are formatting routines,
          suitable for fmtinstall(3). They convert Dir*, Fcall*, and
          long values into string representations of the directory
          buffer, Fcall buffer, or file mode value.  Fcallfmt assumes
          that dirfmt has been installed with format letter `D' and
          dirmodefmt with format letter `M'.

Re: [9fans] ftpfs & fmtinstall woe

[boyd, rounin]

strangely enough, i read that and added the missing %D and %M
fmt's to ftpfs, to no avail.

----- Original Message ----- 
From: "Russ Cox" <russcox@gmail.com>
To: "Fans of the OS Plan 9 from Bell Labs" <9fans@cse.psu.edu>
Sent: Sunday, May 22, 2005 3:52 AM
Subject: Re: [9fans] ftpfs & fmtinstall woe


     FCALL(3)                                                 FCALL(3)

          Dirfmt, fcallfmt, and dirmodefmt are formatting routines,
          suitable for fmtinstall(3). They convert Dir*, Fcall*, and
          long values into string representations of the directory
          buffer, Fcall buffer, or file mode value.  Fcallfmt assumes
          that dirfmt has been installed with format letter `D' and
          dirmodefmt with format letter `M'.

--
MGRS 31U DQ 52572 12604

Re: [9fans] ftpfs & fmtinstall woe

[Russ Cox]

i don't have any idea what bug you're searching for in ftpfs,
but in the program that you posted, your bug is that you
are passing %M a Dir when it is supposed to get a long.
even %D is supposed to get a Dir* not a Dir.

print(". %M\n", d->mode);
    not
print(". %M\n", *d);

russ

Re: [9fans] ftpfs & fmtinstall woe

[boyd, rounin]

i stand corrected:

brahma% 8c f.c && 8l f.8
brahma% ./8.out
. d-rwxr-xr-x
brahma% ls -ld .
d-rwxr-xr-x M 289907 boyd boyd 0 May 21 21:03 src
brahma% 

but i would suggest that fcall be better documented.

--
MGRS 31U DQ 52572 12604

----- Original Message ----- 
From: "Russ Cox" <russcox@gmail.com>
To: "Fans of the OS Plan 9 from Bell Labs" <9fans@cse.psu.edu>
Sent: Sunday, May 22, 2005 4:48 AM
Subject: Re: [9fans] ftpfs & fmtinstall woe


i don't have any idea what bug you're searching for in ftpfs,
but in the program that you posted, your bug is that you
are passing %M a Dir when it is supposed to get a long.
even %D is supposed to get a Dir* not a Dir.

print(". %M\n", d->mode);
    not
print(". %M\n", *d);

russ

Re: [9fans] ftpfs & fmtinstall woe

[jmk]

On Sat May 21 22:58:32 EDT 2005, boyd@insultant.net wrote:
> i stand corrected:
> 
> brahma% 8c f.c && 8l f.8
> brahma% ./8.out
> . d-rwxr-xr-x
> brahma% ls -ld .
> d-rwxr-xr-x M 289907 boyd boyd 0 May 21 21:03 src
> brahma% 
> 
> but i would suggest that fcall be better documented.
> 
> --
> MGRS 31U DQ 52572 12604
> 

project!

(but maybe we should have a meeting about it first, no?)

Re: [9fans] ftpfs & fmtinstall woe

[boyd, rounin]

> (but maybe we should have a meeting about it first, no?)

oh, hilarious ...

i'd rather kill the bug first, before documenting it.
--
MGRS 31U DQ 52572 12604

Re: [9fans] ftpfs & fmtinstall woe

[jmk]

On Sun May 22 00:16:07 EDT 2005, boyd@insultant.net wrote:
> > (but maybe we should have a meeting about it first, no?)
> 
> oh, hilarious ...
> 
> i'd rather kill the bug first, before documenting it.
> --
> MGRS 31U DQ 52572 12604

are you sure? maybe you're rushing into this without thinking
about it enough. i suggest you take a few breaths, call a meeting
and discuss it first.

Re: [9fans] ftpfs & fmtinstall woe

[Russ Cox]

> i'd rather kill the bug first, before documenting it.

meetings aside, you have yet to demonstrate a bug,
except in your test program!

Re: [9fans] ftpfs & fmtinstall woe

[boyd, rounin]

> are you sure? maybe you're rushing into this without thinking
> about it enough. i suggest you take a few breaths, call a meeting
> and discuss it first.
>
mqybe not, i"ll relax with some 20 mike-mike vulcan right along the treeline ...

--
MGRS 31U DQ 52572 12604

Re: [9fans] ftpfs & fmtinstall woe

[jmk]

On Sun May 22 00:37:36 EDT 2005, boyd@insultant.net wrote:
> > are you sure? maybe you're rushing into this without thinking
> > about it enough. i suggest you take a few breaths, call a meeting
> > and discuss it first.
> >
> mqybe not, i"ll relax with some 20 mike-mike vulcan right along the treeline ...
> 
> --
> MGRS 31U DQ 52572 12604

huh? i'm sure that means something to the macho men out there but
i don't understand. i do remember something about guns and inadequacy
though.

Re: [9fans] ftpfs & fmtinstall woe

[boyd, rounin]

> meetings aside, you have yet to demonstrate a bug,
> except in your test program!

220 ProFTPD 1.2.0rc3 Server (ftp.insultant.net) [207.36.129.208]
USER rounin
331 Password required for rounin.
PASS [deleted]
230 User rounin logged in.
SYST
215 UNIX Type: L8
PWD
257 "/u361/rounin" is current directory.
<-Tversion tag 65535 msize 8216 version '9P2000'
->Rversion tag 65535 msize 8216 version '9P2000'
<-Tattach tag 1 fid 1497 afid -1 uname boyd aname
->Rattach tag 1 qid (0000000000000001 0 d)
brahma% cd /n/ftp
brahma% whatis f
fn f {ftpfs -d ftp.insultant.net && cd /n/ftp}
brahma% cd /n/ftp
brahma% mkdir xXx
<-Twalk tag 1 fid 1497 newfid 1574 nwname 1 0:xXx
CWD /u361/rounin/xXx
550 /u361/rounin/xXx: No such file or directory
->Rwalk tag 1 nwqid 1 0:(0000000000000002 0 )
<-Tstat tag 1 fid 1574
PASV
227 Entering Passive Mode (207,36,129,208,8,225).
LIST -l
150 Opening ASCII mode data connection for file list
drwxr-xr-x   2 rounin   user         4096 May 28  2003 GLC
drwxr-xr-x   2 rounin   user         4096 Jul 12  2004 Hellhangover
drwxr-xr-x   6 rounin   user         4096 Oct  9  2004 HellsHangover
drwxr-xr-x   6 rounin   user         4096 May 16  2004 PabloAvocado
drwxr-xr-x   2 rounin   user         4096 Jul  5  2004 TDOS
drwx------   2 rounin   user         4096 May 10  2003 _private
drwxr-xr-x   2 rounin   user         4096 May 21 17:27 a
drwxr-xr-x   3 rounin   user         4096 Dec 21  2003 au
drwxr-xr-x   2 rounin   user         4096 May 21 17:30 b
drwxr-xr-x   2 rounin   user         4096 May 15  2004 bad
drwxr-xr-x   4 rounin   user         4096 May 16  2003 banks
drwxr-xr-x   3 rounin   user         4096 Jun 15  2003 barstow
drwxr-xr-x   3 rounin   user         4096 Feb 27 16:33 be
drwxr-xr-x   6 rounin   user         4096 Jun  7  2004 blog
drwxr-xr-x   2 rounin   user         4096 May 21 17:44 c
drwxr-xr-x   2 rounin   user         4096 May 10  2003 cgi-bin
drwxr-xr-x   5 rounin   user         4096 Apr  7 22:33 code
drwxr-xr-x   3 rounin   user         4096 May 12 06:18 cv
drwxr-xr-x   2 rounin   user         4096 May 21 19:36 d
drwxr-xr-x   2 rounin   user         4096 Aug 18  2004 doc
drwxr-xr-x   2 rounin   user         4096 May 21 19:38 e
drwxr-xr-x   5 rounin   user         4096 Oct 11  2004 fr
drwxr-xr-x   2 rounin   user         4096 Jan  9 04:59 grins
drwxr-xr-x   2 rounin   user         4096 Jun 24  2004 guitar
drwxr-xr-x   5 rounin   user         4096 Jan 16  2004 hk
drwxr-xr-x   2 rounin   user         4096 May 10  2003 htsdata
drwxr-xr-x   2 rounin   user         4096 Aug 31  2004 images
-rw-r--r--   1 rounin   user         8179 Jan  9 05:27 index.html
drwxr-xr-x   2 rounin   user         4096 Aug 31  2004 logs
drwxr-xr-x   3 rounin   user         4096 Dec 24 12:31 nl
drwxr-xr-x  10 rounin   user         4096 Apr 28  2004 paris
drwxr-xr-x   3 rounin   user         4096 Nov  8  2003 repo
drwxr-xr-x   3 rounin   user         4096 Apr 23  2004 ring
drwxr-xr-x   2 rounin   user         4096 May 16  2003 roy-hg
drwxr-xr-x   2 rounin   user         4096 Nov 19  2003 ru
drwxr-xr-x   2 rounin   user         4096 May 16  2003 shitlist
drwxr-xr-x   2 rounin   user         4096 May 24  2004 tab
drwxr-xr-x   6 rounin   user         4096 Jan 12 20:18 targets
drwxr-xr-x   6 rounin   user         4096 Jan  1 18:36 tj
drwxr-xr-x   5 rounin   user         4096 May  1 00:03 tmp
drwxr-xr-x   5 rounin   user         4096 Apr 22  2004 tools
drwxr-xr-x   7 rounin   user         4096 Oct  9  2004 uk
drwxr-xr-x   2 rounin   user         4096 Jun  2  2003 webcam
drwxr-xr-x   2 rounin   user         4096 May 21 15:33 x
drwxr-xr-x   2 rounin   user         4096 May 21 16:00 y
drwxr-xr-x   2 rounin   user         4096 May 21 16:04 z
226 Transfer complete.
->Rerror tag 1 ename file does not exist
<-Tclunk tag 1 fid 1574
->Rclunk tag 1
<-Twalk tag 1 fid 1497 newfid 1063 nwname 1 0:xXx
->Rerror tag 1 ename file does not exist
<-Twalk tag 1 fid 1497 newfid 1063 nwname 0
->Rwalk tag 1 nwqid 0
<-Tcreate tag 1 fid 1063 name xXx perm %M% mode -2147483137
MKD xXx
257 "/u361/rounin/xXx" - Directory successfully created.
->Rcreate tag 1 qid (0000000000000002 0 ) iounit 0
<-Tclunk tag 1 fid 1063
->Rclunk tag 1
brahma% cd xXx
<-Twalk tag 1 fid 1497 newfid 1687 nwname 1 0:xXx
CWD /u361/rounin/xXx
250 CWD command successful.
->Rwalk tag 1 nwqid 1 0:(0000000000000002 0 d)
brahma% lc
<-Twalk tag 1 fid 1687 newfid 1185 nwname 0
->Rwalk tag 1 nwqid 0
<-Tstat tag 1 fid 1185
CWD /u361/rounin
250 CWD command successful.
PASV
227 Entering Passive Mode (207,36,129,208,8,231).
LIST -l
150 Opening ASCII mode data connection for file list
drwxr-xr-x   2 rounin   user         4096 May 28  2003 GLC
drwxr-xr-x   2 rounin   user         4096 Jul 12  2004 Hellhangover
drwxr-xr-x   6 rounin   user         4096 Oct  9  2004 HellsHangover
drwxr-xr-x   6 rounin   user         4096 May 16  2004 PabloAvocado
drwxr-xr-x   2 rounin   user         4096 Jul  5  2004 TDOS
drwx------   2 rounin   user         4096 May 10  2003 _private
drwxr-xr-x   2 rounin   user         4096 May 21 17:27 a
drwxr-xr-x   3 rounin   user         4096 Dec 21  2003 au
drwxr-xr-x   2 rounin   user         4096 May 21 17:30 b
drwxr-xr-x   2 rounin   user         4096 May 15  2004 bad
drwxr-xr-x   4 rounin   user         4096 May 16  2003 banks
drwxr-xr-x   3 rounin   user         4096 Jun 15  2003 barstow
drwxr-xr-x   3 rounin   user         4096 Feb 27 16:33 be
drwxr-xr-x   6 rounin   user         4096 Jun  7  2004 blog
drwxr-xr-x   2 rounin   user         4096 May 21 17:44 c
drwxr-xr-x   2 rounin   user         4096 May 10  2003 cgi-bin
drwxr-xr-x   5 rounin   user         4096 Apr  7 22:33 code
drwxr-xr-x   3 rounin   user         4096 May 12 06:18 cv
drwxr-xr-x   2 rounin   user         4096 May 21 19:36 d
drwxr-xr-x   2 rounin   user         4096 Aug 18  2004 doc
drwxr-xr-x   2 rounin   user         4096 May 21 19:38 e
drwxr-xr-x   5 rounin   user         4096 Oct 11  2004 fr
drwxr-xr-x   2 rounin   user         4096 Jan  9 04:59 grins
drwxr-xr-x   2 rounin   user         4096 Jun 24  2004 guitar
drwxr-xr-x   5 rounin   user         4096 Jan 16  2004 hk
drwxr-xr-x   2 rounin   user         4096 May 10  2003 htsdata
drwxr-xr-x   2 rounin   user         4096 Aug 31  2004 images
-rw-r--r--   1 rounin   user         8179 Jan  9 05:27 index.html
drwxr-xr-x   2 rounin   user         4096 Aug 31  2004 logs
drwxr-xr-x   3 rounin   user         4096 Dec 24 12:31 nl
drwxr-xr-x  10 rounin   user         4096 Apr 28  2004 paris
drwxr-xr-x   3 rounin   user         4096 Nov  8  2003 repo
drwxr-xr-x   3 rounin   user         4096 Apr 23  2004 ring
drwxr-xr-x   2 rounin   user         4096 May 16  2003 roy-hg
drwxr-xr-x   2 rounin   user         4096 Nov 19  2003 ru
drwxr-xr-x   2 rounin   user         4096 May 16  2003 shitlist
drwxr-xr-x   2 rounin   user         4096 May 24  2004 tab
drwxr-xr-x   6 rounin   user         4096 Jan 12 20:18 targets
drwxr-xr-x   6 rounin   user         4096 Jan  1 18:36 tj
drwxr-xr-x   5 rounin   user         4096 May  1 00:03 tmp
drwxr-xr-x   5 rounin   user         4096 Apr 22  2004 tools
drwxr-xr-x   7 rounin   user         4096 Oct  9  2004 uk
drwxr-xr-x   2 rounin   user         4096 Jun  2  2003 webcam
drwxr-xr-x   2 rounin   user         4096 May 21 15:33 x
drwxr-xr-x   2 rounin   user         4096 May 22 00:40 xXx
drwxr-xr-x   2 rounin   user         4096 May 21 16:00 y
drwxr-xr-x   2 rounin   user         4096 May 21 16:04 z
226 Transfer complete.
->Rstat tag 1  stat 'xXx' 'rounin' 'user' 'rounin' q (0000000000000002 0 d) m 030000000755 at 1116736843 mt 1116736843 l 4096 t 0 d 
1
<-Tclunk tag 1 fid 1185
->Rclunk tag 1
<-Twalk tag 1 fid 1687 newfid 1185 nwname 0
->Rwalk tag 1 nwqid 0
<-Topen tag 1 fid 1185 mode 0
CWD /u361/rounin/xXx
250 CWD command successful.
PASV
227 Entering Passive Mode (207,36,129,208,8,232).
LIST -l
150 Opening ASCII mode data connection for file list
226 Transfer complete.
PASV
227 Entering Passive Mode (207,36,129,208,8,233).
NLST
550 No files found.
passive mode retrieve failed: 550 No files found.

PASV
227 Entering Passive Mode (207,36,129,208,8,234).
NLST
550 No files found.
passive mode retrieve failed: 550 No files found.

->Rerror tag 1 ename file does not exist
<-Tclunk tag 1 fid 1185
->Rclunk tag 1
ls: .: file does not exist
brahma%
--
MGRS 31U DQ 52572 12604

Re: [9fans] ftpfs & fmtinstall woe

[Russ Cox]

> <-Tcreate tag 1 fid 1063 name xXx perm %M% mode -2147483137
> MKD xXx

You could have just come out and said ftpfs needed to fmtinstall %M
in your original post and this whole thread could have been avoided.
The manual seems plenty explicit here.  Fixed on sources.

Russ

Re: [9fans] ftpfs & fmtinstall woe

[Bruce Ellis]

why can't everyone wake up at 3am totally confused?  and why all
this tension.  it's nice on Vashon.  and star wars sucks, but at
least there is enough white space in it to debug code in your head.

brucee

On 5/22/05, Russ Cox <russcox@gmail.com> wrote:
> > <-Tcreate tag 1 fid 1063 name xXx perm %M% mode -2147483137
> > MKD xXx
> 
> You could have just come out and said ftpfs needed to fmtinstall %M
> in your original post and this whole thread could have been avoided.
> The manual seems plenty explicit here.  Fixed on sources.
> 
> Russ
>

Re: [9fans] ftpfs & fmtinstall woe

[Skip Tavakkolian]

> star wars sucks

"Aniken I don't know you anymore..."

Re: [9fans] ftpfs & fmtinstall woe

[Bruce Ellis]

You're either with me our your leaving the theatre.

On 5/22/05, Skip Tavakkolian <9nut@9netics.com> wrote:
> > star wars sucks
> 
> "Aniken I don't know you anymore..."

Re: [9fans] ftpfs & fmtinstall woe

[Skip Tavakkolian]

Shouldn't we have a meeting about this?

> You're either with me our your leaving the theatre.
> 
> On 5/22/05, Skip Tavakkolian <9nut@9netics.com> wrote:
>> > star wars sucks
>> 
>> "Aniken I don't know you anymore..."

Re: [9fans] ftpfs & fmtinstall woe

[Skip Tavakkolian]

> star wars sucks

painful, it is.

Re: [9fans] ftpfs & fmtinstall woe

[Bruce Ellis]

excile i must.  failed i have.  fridge beer is in.  brabie on roo is.
and yeah just fix the bloody thing.  as presto once said
"are you proposing a solution or just whining".

On 5/22/05, Skip Tavakkolian <9nut@9netics.com> wrote:
> > star wars sucks
> 
> painful, it is.

Re: [9fans] ftpfs & fmtinstall woe

[Charles Forsyth]

going back a little bit, there's an option to check format parameters:

term% 8c -wF f.c
warning: f.c:15 format mismatch M STRUCT Dir, arg 2
warning: f.c:17 no return at end of function: main

Re: [9fans] ftpfs & fmtinstall woe

[Bruce Ellis]

indeed. on a serious note - the format checking is good.

brucee

On 5/22/05, Charles Forsyth <forsyth@terzarima.net> wrote:
> going back a little bit, there's an option to check format parameters:
> 
> term% 8c -wF f.c
> warning: f.c:15 format mismatch M STRUCT Dir, arg 2
> warning: f.c:17 no return at end of function: main

Re: [9fans] ftpfs & fmtinstall woe

[Ronald G. Minnich]

On Sun, 22 May 2005, Bruce Ellis wrote:

> and star wars sucks

and we all knew it would. I feel so used, somehow.

ron

Re: [9fans] ftpfs & fmtinstall woe

[rog]

bitten by this in the past, i wondered if there was a good
reason why -F was separate from -w. are there many times when
you want warnings but want the compiler to ignore the varargs
pragmas?

Re: [9fans] ftpfs & fmtinstall woe

[Bruce Ellis]

It was a pragmatic decision (pun inteneded) in development of the new code.
It would be wrong to break -w by adding the varargs code.  It is now
just a relic.

brucee

On 5/25/05, rog@vitanuova.com <rog@vitanuova.com> wrote:
> bitten by this in the past, i wondered if there was a good
> reason why -F was separate from -w. are there many times when
> you want warnings but want the compiler to ignore the varargs
> pragmas?