From: erik quanstrom <quanstro@quanstro.net>
To: 9fans@9fans.net
Subject: Re: [9fans] bug in procwired() for x86 scheduler?
Date: Sun, 22 Jun 2014 20:57:44 -0400 [thread overview]
Message-ID: <77de0edfefe533821fb5106a4d24052b@mikro.quanstro.net> (raw)
In-Reply-To: <CAOw7k5iqEseXUW18L8Ww6E5xUgRdvQTSjB5pvCEUmaTWMSdtvQ@mail.gmail.com>
> On 22 June 2014 23:25, Yoann Padioleau <pad@fb.com> wrote:
>
> > if(up != p && (p->wired == nil || p->wired == MACHP(m->machno))
> > m->readied = p;
> >
>
> yes, because on 386 m is effectively a constant. the code was written with
> extern register Mach *m in mind.
>
9atom has had it as
if(up != p && (p->wired == nil || p->wired->machno == m->machno))
which i believe is equivalent, and less obnoxious. the pc kernel should be rewritten
with the GS extern register bit, and then we could get rid of MACHP.
- erik
next prev parent reply other threads:[~2014-06-23 0:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <EC073287-823A-4F0C-ACFD-2831DE775D53@fb.com>
2014-06-22 22:25 ` Yoann Padioleau
2014-06-22 23:20 ` cinap_lenrek
2014-06-22 23:25 ` Charles Forsyth
2014-06-23 0:57 ` erik quanstrom [this message]
2014-06-23 8:08 ` cinap_lenrek
2014-06-23 16:20 ` Yoann Padioleau
2014-06-23 16:39 ` erik quanstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77de0edfefe533821fb5106a4d24052b@mikro.quanstro.net \
--to=quanstro@quanstro.net \
--cc=9fans@9fans.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).