* Re: [9fans] six-ty seven ^fprints on the wall, six-ty seven ^fprints
@ 2003-10-12 14:57 Russ Cox
2003-10-12 15:39 ` David Presotto
2003-10-12 18:24 ` Jim Choate
0 siblings, 2 replies; 6+ messages in thread
From: Russ Cox @ 2003-10-12 14:57 UTC (permalink / raw)
To: 9fans
I really think you want a lot of those fprints.
Perhaps instead of removing them they should be
fixed up to give more context and thus make sense
to more people.
If you remove, for example, the fprints in drawterm
or in vac, when disaster strikes it will just sit
there rather than tell you what happened. I'd rather
have it talk to me.
Russ
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [9fans] six-ty seven ^fprints on the wall, six-ty seven ^fprints
2003-10-12 14:57 [9fans] six-ty seven ^fprints on the wall, six-ty seven ^fprints Russ Cox
@ 2003-10-12 15:39 ` David Presotto
2003-10-12 17:15 ` matt
2003-10-12 18:24 ` Jim Choate
1 sibling, 1 reply; 6+ messages in thread
From: David Presotto @ 2003-10-12 15:39 UTC (permalink / raw)
To: 9fans
If they're part of the code, unindent them.
I'm changing some (not venti/vac) to be syslog's, others I'm
putting under debug flags.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [9fans] six-ty seven ^fprints on the wall, six-ty seven ^fprints
2003-10-12 15:39 ` David Presotto
@ 2003-10-12 17:15 ` matt
0 siblings, 0 replies; 6+ messages in thread
From: matt @ 2003-10-12 17:15 UTC (permalink / raw)
To: 9fans
> If they're part of the code, unindent them.
>
> I'm changing some (not venti/vac) to be syslog's, others I'm
> putting under debug flags.
nice one guys
objection overuled
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [9fans] six-ty seven ^fprints on the wall, six-ty seven ^fprints
2003-10-12 14:57 [9fans] six-ty seven ^fprints on the wall, six-ty seven ^fprints Russ Cox
2003-10-12 15:39 ` David Presotto
@ 2003-10-12 18:24 ` Jim Choate
1 sibling, 0 replies; 6+ messages in thread
From: Jim Choate @ 2003-10-12 18:24 UTC (permalink / raw)
To: 9fans
On Sun, 12 Oct 2003, Russ Cox wrote:
> I really think you want a lot of those fprints.
> Perhaps instead of removing them they should be
> fixed up to give more context and thus make sense
> to more people.
>
> If you remove, for example, the fprints in drawterm
> or in vac, when disaster strikes it will just sit
> there rather than tell you what happened. I'd rather
> have it talk to me.
I'm in here 100%, if it breaks tell me why don't make me go hunt for it.
-- --
God exists because mathematics is consistent, and the Devil exist because we
can't prove it.
Andre Weil, in H. Eves, Mathematical Circles Adieu
ravage@ssz.com jchoate@open-forge.com
www.ssz.com www.open-forge.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [9fans] six-ty seven ^fprints on the wall, six-ty seven ^fprints
2003-10-12 12:17 matt
@ 2003-10-12 12:40 ` David Presotto
0 siblings, 0 replies; 6+ messages in thread
From: David Presotto @ 2003-10-12 12:40 UTC (permalink / raw)
To: 9fans
The ones in w32.c will stay, I'm not done writing it yet.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [9fans] six-ty seven ^fprints on the wall, six-ty seven ^fprints
@ 2003-10-12 12:17 matt
2003-10-12 12:40 ` David Presotto
0 siblings, 1 reply; 6+ messages in thread
From: matt @ 2003-10-12 12:17 UTC (permalink / raw)
To: 9fans
Here's a list of the ^fprints I have found on a fresh pull (with ones that looked kind of legititmate (8) removed)
/sys/src/cmd/9nfs/unixnames.c:46: fprint(2, "looking for %lux\n", clientip);
/sys/src/cmd/9nfs/unixnames.c:51: fprint(2, "dom is %s\n", dom);
/sys/src/cmd/aux/olefs.c:443: fprint(2, "nt nil: create %s: %r\n", buf);
/sys/src/cmd/disk/format.c:681: fprint(2, "add %s at clust %lux\n", d->name, x);
/sys/src/cmd/ip/imap4d/mbox.c:207: fprint(2, "imap4d at %lud: upas/fs stat of %s/%s aka %s failed: %r\n", time(nil), username, box->name, box->fsDir);
/sys/src/cmd/ip/ppp/ppp.c:1307: fprint(2, "remreq\n");
/sys/src/cmd/ip/ppp/ppp.c:1324: fprint(2, "remack\n");
/sys/src/cmd/ip/snoopy/ip6.c:189: fprint(2, "hlen0: %d\n", plen);nstr);
/sys/src/cmd/postscript/tr2post/ps_include.c:148: fprint(2, "prolog=(%d,%d)\n", prolog.start, prolog.end);
/sys/src/cmd/postscript/tr2post/ps_include.c:149: fprint(2, "page=(%d,%d)\n", page.start, page.end);
/sys/src/cmd/postscript/tr2post/ps_include.c:152: fprint(2, "trailer=(%d,%d)\n", trailer.start, trailer.end);
/sys/src/cmd/rc/win32.c:248: fprint(2, "forkexec %s", file);
/sys/src/cmd/rc/win32.c:250: fprint(2, " %d %d %d\n", sin, sout, serr);
/sys/src/cmd/rc/win32.c:254: fprint(2, "forking\n");
/sys/src/cmd/rc/win32.c:271: fprint(2, "execing\n");
/sys/src/cmd/rc/win32.c:273: fprint(2, "exec: %r\n");
/sys/src/cmd/unix/drawterm/irix.c:111: fprintf(stderr, "signal %d to %ld; looping\n", s, getpid());
/sys/src/cmd/unix/drawterm/irix.c:538: fprintf(stderr, "abort %ld\n", getpid());
/sys/src/cmd/unix/drawterm/linux.c:121: fprintf(stderr, "signal %d to %d; looping\n", s, getpid());
/sys/src/cmd/unix/drawterm/linux.c:623: fprintf(stderr, "abort %d\n", getpid());
/sys/src/cmd/unix/drawterm/posix.c:95: fprintf(stderr, "signal %d to %d; looping\n", s, getpid());
/sys/src/cmd/unix/drawterm/posix.c:563: fprintf(stderr, "abort %d\n", getpid());
/sys/src/cmd/unix/drawterm/solaris.c:105: fprintf(stderr, "signal %d to %d; looping\n", s, getpid());
/sys/src/cmd/unix/drawterm/solaris.c:557: fprintf(stderr, "abort %d\n", getpid());
/sys/src/cmd/upas/bayes/msgtok.c:119: fprint(2, "«%s» %.2ux", p, p[0]);
/sys/src/cmd/vac/cache.c:335: fprint(2, "cache is full\n");
/sys/src/cmd/vac/cache.c:451: fprint(2, "vtRead failed: %V %d %d: %R\n", score, type, size);
/sys/src/cmd/vac/cache.c:637: fprint(2, "block is free %V!\n", v->score);
/sys/src/cmd/vac/cache.c:683: fprint(2, "lumpWalk: parent changed under foot\n");
/sys/src/cmd/vac/file.c:1085: fprint(2, "gen mismatch\n");
/sys/src/cmd/vac/source.c:39: fprint(2, "bad flags %#ux %V\n", d.flags, d.score);
/sys/src/cmd/vac/srcload.c:93: fprint(2, "deleting\n");
/sys/src/cmd/vac/srcload.c:224: fprint(2, "%lud: %R\n", i);
/sys/src/cmd/vac/srcload.c:301: fprint(2, "count = %d top = %d depth=%d maxcount %d\n", cc, n, maxdepth, max);
/sys/src/cmd/vac/vac.c:244: fprint(2, "vtSha1Check: n = %d %V %V\n", n, score, score2);
/sys/src/cmd/vac/vacfs.c:511: fprint(2, "write failed: %s\n", vtGetError());
/sys/src/cmd/vac/vacfs.c:842: fprint(2, "open fid: %d\n", f->fid);
/sys/src/cmd/vac/vactest.c:130: fprint(2, "vac file: %s\n", path2);
/sys/src/cmd/venti/checkindex.c:123: fprint(2, "found %lld entries in sorted list\n", found);
/sys/src/cmd/venti/dumparena.c:81: fprint(2, "pos = %d\n", pos);
/sys/src/cmd/venti/sortientry.c:79: fprint(2, "got %lld clumps - starting sort\n", clumps);
/sys/src/cmd/venti/sortientry.c:229: fprint(2, "ib->max = %lld\n", ib->max);
/sys/src/cmd/venti/sortientry.c:230: fprint(2, "ib->chunks = %ud\n", ib->chunks);
/sys/src/cmd/venti/sortientry.c:323: fprint(2, "%d total = %lld\n", b, ib->bucks[b].total);
/sys/src/cmd/venti/sortientry.c:326: fprint(2, "n = %ud\n", n);
/sys/src/cmd/venti/sortientry.c:334: fprint(2, "n = %ud\n", n);
/sys/src/cmd/venti/ventifs.c:103: fprint(2, "dirsize %d\n", n);
/sys/src/cmd/venti/ventifs.c:106: fprint(2, "%d...", i);
/sys/src/cmd/venti/ventifs.c:109: fprint(2, "done %p %d %p\n", p, dsize, ep);
/sys/src/cmd/vnc/devdraw.c:898: fprint(2, "bad memimaged: %r\n");
/sys/src/cmd/fossil/9proc.c:196: fprint(2, "msgFlush %F\n", &m->t);
/sys/src/cmd/fossil/9proc.c:213: fprint(2, "\tmsgFlush found %F\n", &old->t);
/sys/src/cmd/fossil/cache.c:316: fprint(2, "cacheCheck: nheap %d refed %d nblocks %ld\n", c->nheap, refed, c->nblocks);
/sys/src/cmd/fossil/cache.c:475: fprint(2, "_cacheLocal want epoch %ud got %ud\n", epoch, b->l.epoch);
/sys/src/cmd/fossil/cache.c:526: fprint(2, "_cacheLocal want epoch %ud got %ud\n", epoch, b->l.epoch);
/sys/src/cmd/fossil/cache.c:1048: fprint(2, "unlinkBlock: strange epoch :%ud %ud\n", b->l.epoch, epoch);
/sys/src/cmd/fossil/disk.c:306: fprint(2, "diskReadRaw failed: part=%d addr=%ux: %r\n", b->part, b->addr);
/sys/src/cmd/fossil/disk.c:314: fprint(2, "diskWriteRaw failed: date=%s part=%d addr=%ux: %r\n", ctime(times(0)), b->part, b->addr);
/sys/src/cmd/fossil/file.c:217: fprint(2, "fileOpenSource: dir mismatch %d %d\n", r->dir, dir);
/sys/src/cmd/fossil/file.c:946: fprint(2, "fileMetaFlush moving entry from %ud -> %ud\n", f->boff, boff);
/sys/src/cmd/fossil/file.c:992: fprint(2, "U\n");
/sys/src/cmd/fossil/file.c:997: fprint(2, "S\n");
/sys/src/cmd/fossil/file.c:1497: fprint(2, "f->elem = %s\n", f->dir.elem);
/sys/src/cmd/fossil/fs.c:130: fprint(2, "fsOpen error\n");
/sys/src/cmd/fossil/pack.c:78: fprint(2, "labelUnpack %.2ux %.2ux %.8ux %.8ux %.8ux\n",
/sys/src/cmd/fossil/srcload.c:88: fprint(2, "deleting\n");
/sys/src/cmd/fossil/srcload.c:270: fprint(2, "count = %d top = %d depth=%d maxcount %d\n", cc, n, maxdepth, max);
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2003-10-12 18:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-10-12 14:57 [9fans] six-ty seven ^fprints on the wall, six-ty seven ^fprints Russ Cox
2003-10-12 15:39 ` David Presotto
2003-10-12 17:15 ` matt
2003-10-12 18:24 ` Jim Choate
-- strict thread matches above, loose matches on Subject: below --
2003-10-12 12:17 matt
2003-10-12 12:40 ` David Presotto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).