[9fans] nvidia driver fix

[9fans] nvidia driver fix

[Nicholas Waples]

 Just updated my system from the net and my Geforce 2 MX no longer worked.
The following changes fixed it.


% diff nvidia.c nvidia.c.orig
41c41
< 	0x19, 0x1A, 0x25, 0x28, 0x2D, 0x30, 0x31, -1
---
> 	0x19, 0x1A, 0x21, 0x25, 0x28, 0x2D, 0x30, 0x31, 0x53, 0x54, -1
255a256,258
> 		vga->crt[0x21] = 0xFA;
> 		vga->crt[0x53] = 0;
> 		vga->crt[0x54] = 0;
499,501d501
< 		vgaxo(Crtx, 0x21, 0xFA);
< 		vgaxo(Crtx, 0x53, 0);
< 		vgaxo(Crtx, 0x54, 0);

Re: [9fans] nvidia driver fix

[Nicholas Waples]

On Thu, 18 Jul 2002 jmk@plan9.bell-labs.com wrote:

> i'm not disputing there is a problem with the addition of the lcd
> code, but your fix is confusing. unless you are using a flat panel,
> the path through the orig code and your fixed code should be the same,
> with the exception that the orig code reads crt registers 0x21, 0x53
> and 0x54. there's only the xfree86 code to go on here, and that doesn't
> read those registers and only sets them if it's a flat panel; that
> might be the right answer.

 Thats confusing because thats what I thought I did (set the registers
only if its a lcd). Unless Im working off a different version of the
source file.

> in what way didn't it work?

 It didnt like those registers being set.

> On Thu Jul 18 08:50:48 EDT 2002, nickw@pobox.com wrote:
> >
> >  Just updated my system from the net and my Geforce 2 MX no longer worked.
> > The following changes fixed it.
> >
> >
> > % diff nvidia.c nvidia.c.orig
> > 41c41
> > < 	0x19, 0x1A, 0x25, 0x28, 0x2D, 0x30, 0x31, -1
> > ---
> > > 	0x19, 0x1A, 0x21, 0x25, 0x28, 0x2D, 0x30, 0x31, 0x53, 0x54, -1
> > 255a256,258
> > > 		vga->crt[0x21] = 0xFA;
> > > 		vga->crt[0x53] = 0;
> > > 		vga->crt[0x54] = 0;
> > 499,501d501
> > < 		vgaxo(Crtx, 0x21, 0xFA);
> > < 		vgaxo(Crtx, 0x53, 0);
> > < 		vgaxo(Crtx, 0x54, 0);
> >
>

Re: [9fans] nvidia driver fix

[jmk]

i'm not disputing there is a problem with the addition of the lcd
code, but your fix is confusing. unless you are using a flat panel,
the path through the orig code and your fixed code should be the same,
with the exception that the orig code reads crt registers 0x21, 0x53
and 0x54. there's only the xfree86 code to go on here, and that doesn't
read those registers and only sets them if it's a flat panel; that
might be the right answer.

in what way didn't it work?

On Thu Jul 18 08:50:48 EDT 2002, nickw@pobox.com wrote:
> 
>  Just updated my system from the net and my Geforce 2 MX no longer worked.
> The following changes fixed it.
> 
> 
> % diff nvidia.c nvidia.c.orig
> 41c41
> < 	0x19, 0x1A, 0x25, 0x28, 0x2D, 0x30, 0x31, -1
> ---
> > 	0x19, 0x1A, 0x21, 0x25, 0x28, 0x2D, 0x30, 0x31, 0x53, 0x54, -1
> 255a256,258
> > 		vga->crt[0x21] = 0xFA;
> > 		vga->crt[0x53] = 0;
> > 		vga->crt[0x54] = 0;
> 499,501d501
> < 		vgaxo(Crtx, 0x21, 0xFA);
> < 		vgaxo(Crtx, 0x53, 0);
> < 		vgaxo(Crtx, 0x54, 0);
>