9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: underspecified <underspecified@gmail.com>
To: inferno-list@vitanuova.com,
	"Fans of the OS Plan 9 from Bell Labs" <9fans@cse.psu.edu>
Subject: [9fans] PATCHES Window overlaps dock in Drawterm and Emu for OS X
Date: Fri, 26 Oct 2007 02:54:31 +0900	[thread overview]
Message-ID: <ab4cf6420710251054s7372f63agddbd3c8e75f38afc@mail.gmail.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 533 bytes --]

Greetings,

Currently, in Mac OS XDrawterm, Emu, and Acme SAC all overlap the dock when
the window is dragged over them or
the dock zooms. The cause of this error is that a new window group is being
created with a higher level than the dock.
An easy fix is to just comment out the code that creates the new group. I
have attached patches for Drawterm and Emu.
A new Acme SAC release will be forthcoming. It would be nice to see this
small, but significant change make its way
back into these programs.

--underspecified

[-- Attachment #1.2: Type: text/html, Size: 561 bytes --]

[-- Attachment #2: drawterm-wingroup.diff --]
[-- Type: application/octet-stream, Size: 697 bytes --]

--- drawterm.orig/gui-osx/screen.c	2007-10-26 02:30:36.000000000 +0900
+++ drawterm.new/gui-osx/screen.c	2007-10-26 02:29:52.000000000 +0900
@@ -53,7 +53,7 @@
 	kFullScreenCmd = 2,
 };
 
-static WindowGroupRef winGroup = NULL;
+//static WindowGroupRef winGroup = NULL;
 static WindowRef theWindow = NULL;
 static CGContextRef context;
 static CGDataProviderRef dataProviderRef;
@@ -184,8 +184,8 @@
 		;
 
 	CreateNewWindow(kDocumentWindowClass, windowAttrs, &winRect, &theWindow);
-	CreateWindowGroup(0, &winGroup);
-	SetWindowGroup(theWindow, winGroup);
+//	CreateWindowGroup(0, &winGroup);
+//	SetWindowGroup(theWindow, winGroup);
 
 	SetWindowTitleWithCFString(theWindow, CFSTR("Drawterm"));
 

[-- Attachment #3: inferno-wingroup.diff --]
[-- Type: application/octet-stream, Size: 694 bytes --]

--- inferno.orig/emu/MacOSX/win.c	2007-08-17 13:07:16.000000000 +0900
+++ inferno.new/emu/MacOSX/win.c	2007-10-26 02:48:49.000000000 +0900
@@ -55,7 +55,7 @@
 	kFullScreenCmd = 2,
 };
 
-static WindowGroupRef winGroup = NULL;
+//static WindowGroupRef winGroup = NULL;
 static WindowRef theWindow = NULL;
 static CGContextRef context;
 static CGDataProviderRef dataProviderRef;
@@ -167,8 +167,8 @@
 		;
 
 	CreateNewWindow(kDocumentWindowClass, windowAttrs, &winRect, &theWindow);
-	CreateWindowGroup(0, &winGroup);
-	SetWindowGroup(theWindow, winGroup);
+//	CreateWindowGroup(0, &winGroup);
+//	SetWindowGroup(theWindow, winGroup);
 
 	SetWindowTitleWithCFString(theWindow, CFSTR("Inferno"));
 

                 reply	other threads:[~2007-10-25 17:54 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab4cf6420710251054s7372f63agddbd3c8e75f38afc@mail.gmail.com \
    --to=underspecified@gmail.com \
    --cc=9fans@cse.psu.edu \
    --cc=inferno-list@vitanuova.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).