9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
* [9fans] PATCHES Window overlaps dock in Drawterm and Emu for OS X
@ 2007-10-25 17:54 underspecified
  0 siblings, 0 replies; only message in thread
From: underspecified @ 2007-10-25 17:54 UTC (permalink / raw)
  To: inferno-list, Fans of the OS Plan 9 from Bell Labs


[-- Attachment #1.1: Type: text/plain, Size: 533 bytes --]

Greetings,

Currently, in Mac OS XDrawterm, Emu, and Acme SAC all overlap the dock when
the window is dragged over them or
the dock zooms. The cause of this error is that a new window group is being
created with a higher level than the dock.
An easy fix is to just comment out the code that creates the new group. I
have attached patches for Drawterm and Emu.
A new Acme SAC release will be forthcoming. It would be nice to see this
small, but significant change make its way
back into these programs.

--underspecified

[-- Attachment #1.2: Type: text/html, Size: 561 bytes --]

[-- Attachment #2: drawterm-wingroup.diff --]
[-- Type: application/octet-stream, Size: 697 bytes --]

--- drawterm.orig/gui-osx/screen.c	2007-10-26 02:30:36.000000000 +0900
+++ drawterm.new/gui-osx/screen.c	2007-10-26 02:29:52.000000000 +0900
@@ -53,7 +53,7 @@
 	kFullScreenCmd = 2,
 };
 
-static WindowGroupRef winGroup = NULL;
+//static WindowGroupRef winGroup = NULL;
 static WindowRef theWindow = NULL;
 static CGContextRef context;
 static CGDataProviderRef dataProviderRef;
@@ -184,8 +184,8 @@
 		;
 
 	CreateNewWindow(kDocumentWindowClass, windowAttrs, &winRect, &theWindow);
-	CreateWindowGroup(0, &winGroup);
-	SetWindowGroup(theWindow, winGroup);
+//	CreateWindowGroup(0, &winGroup);
+//	SetWindowGroup(theWindow, winGroup);
 
 	SetWindowTitleWithCFString(theWindow, CFSTR("Drawterm"));
 

[-- Attachment #3: inferno-wingroup.diff --]
[-- Type: application/octet-stream, Size: 694 bytes --]

--- inferno.orig/emu/MacOSX/win.c	2007-08-17 13:07:16.000000000 +0900
+++ inferno.new/emu/MacOSX/win.c	2007-10-26 02:48:49.000000000 +0900
@@ -55,7 +55,7 @@
 	kFullScreenCmd = 2,
 };
 
-static WindowGroupRef winGroup = NULL;
+//static WindowGroupRef winGroup = NULL;
 static WindowRef theWindow = NULL;
 static CGContextRef context;
 static CGDataProviderRef dataProviderRef;
@@ -167,8 +167,8 @@
 		;
 
 	CreateNewWindow(kDocumentWindowClass, windowAttrs, &winRect, &theWindow);
-	CreateWindowGroup(0, &winGroup);
-	SetWindowGroup(theWindow, winGroup);
+//	CreateWindowGroup(0, &winGroup);
+//	SetWindowGroup(theWindow, winGroup);
 
 	SetWindowTitleWithCFString(theWindow, CFSTR("Inferno"));
 

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-10-25 17:54 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-10-25 17:54 [9fans] PATCHES Window overlaps dock in Drawterm and Emu for OS X underspecified

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).