9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: pwfmfx@cna.ne.jp
To: 9fans@cse.psu.edu
Subject: Re: [9fans] factotum problem fix
Date: Thu,  5 Dec 2002 12:29:28 +0900	[thread overview]
Message-ID: <b6e9c50657c8d2c11465ddb563ad594d@cna.ne.jp> (raw)

Hello,
I've forgot to tell you that
there was a small resource leak in factotum:

term% diff /sys/src/cmd/auth/fctotum/util.c util.c
15,17c15,17
< 		if((srvfd = open("#s/cs", ORDWR)) >= 0){
< 			if(mount(srvfd, -1, "/net", MBEFORE, "") >= 0)
< 				return 0;
---
> 		if((srvfd = open("#s/cs", ORDWR)) < 0)
> 			return -1;
> 		if(mount(srvfd, -1, "/net", MBEFORE, "") < 0){
18a19
> 			return -1;
20c21
< 		return -1;
---
> 		close(srvfd);
term%

--
Mamoru Sato


             reply	other threads:[~2002-12-05  3:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-05  3:29 pwfmfx [this message]
  -- strict thread matches above, loose matches on Subject: below --
2002-12-07  8:53 pwfmfx
2002-12-06 16:07 Russ Cox
2002-12-06 13:12 pwfmfx
2002-12-05  3:42 Russ Cox
2002-11-20  4:24 pwfmfx
2002-11-19 16:27 presotto
2002-11-19  5:10 pwfmfx

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b6e9c50657c8d2c11465ddb563ad594d@cna.ne.jp \
    --to=pwfmfx@cna.ne.jp \
    --cc=9fans@cse.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).