9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: pwfmfx@cna.ne.jp
To: 9fans@cse.psu.edu
Subject: [9fans] factotum problem fix
Date: Tue, 19 Nov 2002 14:10:54 +0900	[thread overview]
Message-ID: <d8a8608f096fd8e975b6e8e6ce899018@cna.ne.jp> (raw)

Hello,
I couldn't access to an auth server from /net.alt,
because factotum used only /net.

Here's my fix.
Replace bindnetcs(void) in factotum/util.c by the following:

-- from here --
/* bind in a specified network and cs */
static int
bindnetcseach(char *net, char *ipdev, char *cssrv)
{
	int srvfd;
	char buf[40];

	snprint(buf, sizeof buf, "%s/cs", net);
	if(access(buf, AEXIST) >= 0)
		return 0;

	if((srvfd = open(cssrv, ORDWR)) < 0)
		return -1;
	if(mount(srvfd, -1, net, MAFTER, "") < 0)
		return -1;
	close(srvfd);

	snprint(buf, sizeof buf, "%s/tcp", net);
	if(access(buf, AEXIST) < 0)
		bind(ipdev, net, MAFTER);
	return 0;
}

/* bind in the default network and cs */
static int
bindnetcs(void)
{
	if(bindnetcseach("/net", "#I", "#s/cs") < 0)
		return -1;
	bindnetcseach("/net.alt", "#I1", "#s/cs_net.alt");
	return 0;
}
-- end --

By the way, fd in _asgetticket() could be closed twice.
When an error occurs, _asgetticket() close(fd),
and a caller (auth/debug, factotum/p9sk1.c, ...) closes it again.

Thanks.
---
Mamoru Sato
pwfmfx@cna.ne.jp
pwfmfx@nurs.or.jp


             reply	other threads:[~2002-11-19  5:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-19  5:10 pwfmfx [this message]
2002-11-19 16:27 presotto
2002-11-20  4:24 pwfmfx
2002-12-05  3:29 pwfmfx
2002-12-05  3:42 Russ Cox
2002-12-06 13:12 pwfmfx
2002-12-06 16:07 Russ Cox
2002-12-07  8:53 pwfmfx

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8a8608f096fd8e975b6e8e6ce899018@cna.ne.jp \
    --to=pwfmfx@cna.ne.jp \
    --cc=9fans@cse.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).