[9fans] create() and mtime

[9fans] create() and mtime

[Fco.J.Ballesteros]

It looks like a create of an existing file is not updating mtime. As a result
news prints old news because the mtime of $home/lib/newstime gets fixed to
the actual creation (not truncation) time.


I changed
create(newstime)

to
remove(newstime)
create(newstime)

in our news program, but that's  probably wrong.

BTW, the file server where newstime lives on in fossil backed up by venti.

Re: [9fans] create() and mtime

[rob pike, esq.]

> It looks like a create of an existing file is not updating mtime. As a result
> news prints old news because the mtime of $home/lib/newstime gets fixed to
> the actual creation (not truncation) time.

i just noticed this myself.  you need to write to a file to get its mtime updated.
i believe this is a mistake; the manual says mtime is time of change of content,
not time of write.

i would change your news program to create and write a byte.

-rob

Re: [9fans] create() and mtime

[jmk]

On Wed Oct 22 14:08:39 EDT 2003, r@geekmail.cc wrote:
> > It looks like a create of an existing file is not updating mtime. As a result
> > news prints old news because the mtime of $home/lib/newstime gets fixed to
> > the actual creation (not truncation) time.
>
> i just noticed this myself.  you need to write to a file to get its mtime updated.
> i believe this is a mistake; the manual says mtime is time of change of content,
> not time of write.
>
> i would change your news program to create and write a byte.
>
> -rob

i would fix the bug. new version of /sys/src/cmd/fossil/file.c on sources.

--jim

Re: [9fans] create() and mtime

[Fco.J.Ballesteros]

[-- Attachment #1: Type: text/plain, Size: 139 bytes --]

I was not sure of the correct behaviour, so I couldnt fix it.
For me it was not clear if it was a feature or not.

Thanks for the fix.

[-- Attachment #2: Type: message/rfc822, Size: 2313 bytes --]

From: jmk@plan9.bell-labs.com
To: 9fans@cse.psu.edu
Subject: Re: [9fans] create() and mtime
Date: Wed, 22 Oct 2003 14:56:41 -0400
Message-ID: <2457b115760b955da8e1e96de8434eea@plan9.bell-labs.com>

On Wed Oct 22 14:08:39 EDT 2003, r@geekmail.cc wrote:
> > It looks like a create of an existing file is not updating mtime. As a result
> > news prints old news because the mtime of $home/lib/newstime gets fixed to
> > the actual creation (not truncation) time.
>
> i just noticed this myself.  you need to write to a file to get its mtime updated.
> i believe this is a mistake; the manual says mtime is time of change of content,
> not time of write.
>
> i would change your news program to create and write a byte.
>
> -rob

i would fix the bug. new version of /sys/src/cmd/fossil/file.c on sources.

--jim