Building go1.12.14

Building go1.12.14

[Steven Stallion]

All,

I was updating my golang installation this morning and I ran into a
couple of failures building go1.12.14 - I was curious if any on the
list have run into issues as well:

	--- FAIL: TestContextCancel (1.02s)
	    exec_test.go:1096: echo
	    : 
	    exec_test.go:1122: canceling context did not stop program
	FAIL
	FAIL	os/exec	4.824s

and:

	go test proxy starting
	go proxy_test: invalid module path encoding "example.com/invalidpath/v1": malformed module path "example.com/invalidpath/v1": invalid version
	go test proxy running at GOPROXY=http://127.0.0.1:59211/mod
	panic: test timed out after 9m0s
	:
	FAIL	cmd/go	589.840s

All other tests pass.  I'm running a vanilla labs installation with
patches applied from https://github.com/golang/go/wiki/Plan9.

Assuming this is a new issue with the plan9 port, is there a dashboard
available of working release builds that could be used to avoid
playing update-whackamole?

Any ideas?
Steve

Re: [9fans] Building go1.12.14

[David du Colombier]

> Assuming this is a new issue with the plan9 port, is there a dashboard
> available of working release builds that could be used to avoid
> playing update-whackamole?

Generally speaking, your best bet is running the master branch
on Plan 9, or at least the latest release.

I think the second issue has been fixed in Go 1.13.

You can follow the issues their resolution on https://github.com/golang/go/labels/OS-Plan9.

-- 
David du Colombier

Re: [9fans] Building go1.12.14

[Steven Stallion]

> I think the second issue has been fixed in Go 1.13.
> 
> You can follow the issues their resolution on https://github.com/golang/go/labels/OS-Plan9.

Thanks.  I'm beginning to suspect there may be some additional patches
needed that I may not have applied.  I've noticed when attempting to
hget files from GitHub that I'm running into issues with TLS:

	tlsClient: protocol version not supported
	
I've double checked, and libsec-x509-sha2.diff is indeed applied.  Do
you know of any additional patches that are needed to update TLS
support?

Cheers,
Steve

Re: [9fans] Building go1.12.14

[David du Colombier]

> Thanks.  I'm beginning to suspect there may be some additional patches
> needed that I may not have applied.  I've noticed when attempting to
> hget files from GitHub that I'm running into issues with TLS:
> 
>         tlsClient: protocol version not supported
>         
> I've double checked, and libsec-x509-sha2.diff is indeed applied.  Do
> you know of any additional patches that are needed to update TLS
> support?

It seems that GitHub now rejects TLS version < 1.2.

You could try to apply these patches to add TLS 1.2 support to devtls and tlshand:

http://9legacy.org/9legacy/patch/tls-devtls12.diff
http://9legacy.org/9legacy/patch/tls-tlshand12.diff

-- 
David du Colombier

Re: [9fans] Building go1.12.14

[David du Colombier]

Also keep in mind that Go doesn't use any of the Plan 9 libraries
and uses its own TLS implementation. So fixing the Plan 9
tools to support TLS 1.2 will have no impact on Go.

-- 
David du Colombier

Re: [9fans] Building go1.12.14

[Steven Stallion]

> Also keep in mind that Go doesn't use any of the Plan 9 libraries
> and uses its own TLS implementation. So fixing the Plan 9
> tools to support TLS 1.2 will have no impact on Go.

Makes sense.  It looks like those patches at least got things moving
again on the Plan 9 side.

I updated my bootstrap compiler and rebuilt the latest release
(1.13.5); I'm still seeing the same failures.  Some digging around
online shows that the same issues are being seen on the 9front builder
for amd64 periodically.  These don't appear to be show-stoppers, so
I'll swing back around later and see if I can suss out what's going
on.

Cheers,
Steve

Re: [9fans] Building go1.12.14

[David du Colombier]

In the error message you posted, I can see the cmd/go tests are timing out.

It may just be too slow to finish in less that 9 minutes on your machine.
There are a lot of cmd/go tests, especially in the recent releases,
and they are quite slow to run on Plan 9.

You may want to set GO_TEST_TIMEOUT_SCALE=2, for example,
before running all.rc, to increase the timeout to 18 minutes.

-- 
David du Colombier

Re: [9fans] Building go1.12.14

[Steven Stallion]

> You may want to set GO_TEST_TIMEOUT_SCALE=2, for example,
> before running all.rc, to increase the timeout to 18 minutes.

Gotcha.  I'll crank this up and rebuild to see if that clears the
issue.  With repsect to the failure in exec_test.go, I came across
this failure on the amd64 builder but haven't found a fix yet:
https://20191016t122939-dot-build-dot-golang-org.appspot.com/log/5cb857c582e994206fe624231401985967694144

Cheers,
Steve

Re: [9fans] Building go1.12.14

[Steven Stallion]

>> You may want to set GO_TEST_TIMEOUT_SCALE=2, for example,
>> before running all.rc, to increase the timeout to 18 minutes.
> 
> Gotcha.  I'll crank this up and rebuild to see if that clears the
> issue.  With repsect to the failure in exec_test.go, I came across
> this failure on the amd64 builder but haven't found a fix yet:
> https://20191016t122939-dot-build-dot-golang-org.appspot.com/log/5cb857c582e994206fe624231401985967694144

It turns out that Richard posted a patch (exec-postnote-race) some
time ago that I was missing, which resolves the issue in os/exec.
Once applied, tests are now passing normally.  I'll update the wiki
later this evening.

Cheers,
Steve