9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
* [9fans] missing diagnostic?
@ 2008-11-20 22:08 erik quanstrom
  2008-11-20 23:02 ` Charles Forsyth
  0 siblings, 1 reply; 3+ messages in thread
From: erik quanstrom @ 2008-11-20 22:08 UTC (permalink / raw)
  To: 9fans

i was expecting kenc to complain about the
a < 0 test, which can never be true.

int
fetchicmp(Fetchi *f1, Fetchi *f2)
{
	uvlong a, b;

	a = f1->uid;
	b = f2->uid;

	a -= b;
	if(a > 0)
		return 1;
	if(a < 0)
		return -1;
	return 0;
}

- erik



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [9fans] missing diagnostic?
  2008-11-20 23:02 ` Charles Forsyth
@ 2008-11-20 22:54   ` erik quanstrom
  0 siblings, 0 replies; 3+ messages in thread
From: erik quanstrom @ 2008-11-20 22:54 UTC (permalink / raw)
  To: 9fans

> doppio% 8c -w cm.c
> warning: cm.c:14 useless or misleading comparison: UVLONG < 0
> doppio% qc -w cm.c
> warning: cm.c:14 useless or misleading comparison: UVLONG < 0
> doppio% 5c -w cm.c
> warning: cm.c:14 useless or misleading comparison: UVLONG < 0

sorry for the noise.  forgot to recompile.

- erik




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [9fans] missing diagnostic?
  2008-11-20 22:08 [9fans] missing diagnostic? erik quanstrom
@ 2008-11-20 23:02 ` Charles Forsyth
  2008-11-20 22:54   ` erik quanstrom
  0 siblings, 1 reply; 3+ messages in thread
From: Charles Forsyth @ 2008-11-20 23:02 UTC (permalink / raw)
  To: 9fans

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

doppio% 8c -w cm.c
warning: cm.c:14 useless or misleading comparison: UVLONG < 0
doppio% qc -w cm.c
warning: cm.c:14 useless or misleading comparison: UVLONG < 0
doppio% 5c -w cm.c
warning: cm.c:14 useless or misleading comparison: UVLONG < 0

[-- Attachment #2: Type: message/rfc822, Size: 1738 bytes --]

From: erik quanstrom <quanstro@quanstro.net>
To: 9fans@9fans.net
Subject: [9fans] missing diagnostic?
Date: Thu, 20 Nov 2008 17:08:13 -0500
Message-ID: <d7d3103ea912c0ef5a4afbd07ef27904@quanstro.net>

i was expecting kenc to complain about the
a < 0 test, which can never be true.

int
fetchicmp(Fetchi *f1, Fetchi *f2)
{
	uvlong a, b;

	a = f1->uid;
	b = f2->uid;

	a -= b;
	if(a > 0)
		return 1;
	if(a < 0)
		return -1;
	return 0;
}

- erik

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-11-20 23:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-11-20 22:08 [9fans] missing diagnostic? erik quanstrom
2008-11-20 23:02 ` Charles Forsyth
2008-11-20 22:54   ` erik quanstrom

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).