9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
* [9fans] pata pio mode vs. flash
@ 2008-09-10 13:02 erik quanstrom
  0 siblings, 0 replies; only message in thread
From: erik quanstrom @ 2008-09-10 13:02 UTC (permalink / raw)
  To: 9fans

it appears that for pio reads and writes, sdata.c (the plan 9 ata driver)
omits waiting for Drdy.  normally drives assert Drdy very quickly, but its
in the spec and i've tripped on a few slow parts that are not ready when
we send them data:

Sep  8 13:00:49 EDT 2008 sdata.c 54744 [quanstro]
sdata.c:1421 c /n/dump/2008/0909/sys/src/9/pc/sdata.c:1421
< 	if(ataready(cmdport, ctlport, drive->dev, Bsy|Drq, Drdy, 101*1000) < 0)
---
> 	if(ataready(cmdport, ctlport, drive->dev, Bsy|Drq, 0, 101*1000) < 0)

i'm pretty sure that the same test needs to be in atapktio as well.
(could this be the disagreement with vmware?)

it is interesting that it's been that way for a long time.

- erik




^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-09-10 13:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-09-10 13:02 [9fans] pata pio mode vs. flash erik quanstrom

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).