FQA contributing?

FQA contributing?

[ori]

I've answered at least a couple of these questions,
so I was thinking it may be worth covering this in the
FQA.

Does this look reasonable? (Do we want people to do
something other than this?)

diff -r 16ccbad027f4 fqa2.ms
--- a/fqa2.ms	Sun Apr 19 22:16:56 2020 -0400
+++ b/fqa2.ms	Mon May 11 19:40:05 2020 -0700
@@ -507,6 +507,65 @@
 % snap 882285 > rssread.snap
 .P2
 
+.ihtml a
+.bp
+.html - <a name="2.4" />
+.ihtml h2 <h2>
+.SH
+2.5 - Sending Fixes
+.R
+.ihtml h2
+
+We take fixes.
+
+.html - <a name="2.5.1" />
+.ihtml h3 <h3>
+.SH
+2.5.1 - How do I write good patches?
+.R
+.ihtml h3
+Explain the problem that your change solves.
+Explain why your change solves the problem well.
+If applicable, explain how you tested the patch, and
+give us a way of reproducing the issue.
+
+.LP
+Before Before making the patch, make sure your system is up to
+date.
+
+.LP
+Make your code match the rest of the system. Look at
+.IR style (6)
+for a summary of our code style.
+
+.LP
+If your patch includes new features or flags, be sure to update
+the documentation.
+
+.LP
+If the patch is intrusive or significantly changes the design of
+aspects of the system, it may be worth discussing it first.
+Email works for this, but IRC works better.
+
+.html - <a name="2.5.2" />
+.ihtml h3 <h3>
+.SH
+2.5.2 - How do I send in my patches?
+.R
+.ihtml h3
+To send changes, email 9front@9front.org with your patch attached inline.
+Generate the patch using
+.P1
+% cd /sys/src/your/changed/code
+% hg diff . > /tmp/mypatch.diff
+.P2
+and paste the change into your email client of choice.
+
+.LP
+This project is run by hobbyists.
+It may take some time for people to respond.
+If you don't hear anything for more than a week or so, send a ping.
+
 .html - <hr />
 .html - <a href="fqa.html">FQA INDEX</a> |
 .html - <a href="fqa1.html">FQA 1 - Introduction To 9front</a> |

Re: [9front] FQA contributing?

[sl]

thanks Ori_B, this is applied.

sl

Re: [9front] FQA contributing?

[theinicke]

Nice work. I just noticed a minor issue: The man page reference should have been

+.ihtml a <a href="http://man.9front.org/6/style">
+.CW style (6)
+.ihtml a

instead of

+.IR style (6)

Below is a proper patch for convenience.

--
Tobias Heinicke

diff -r 8caa695ebe93 fqa2.ms
--- a/fqa2.ms	Mon May 11 23:32:01 2020 -0400
+++ b/fqa2.ms	Wed May 13 15:42:37 2020 +0200
@@ -535,7 +535,9 @@
 
 .LP
 Make your code match the rest of the system. Look at
-.IR style (6)
+.ihtml a <a href="http://man.9front.org/6/style">
+.CW style (6)
+.ihtml a
 for a summary of our code style.
 
 .LP

Re: [9front] FQA contributing?

[umbraticus]

Also in 2.5.2 you may want to add

% bind -ac /dist/plan9front /

before the other commands.

umbraticus

Re: [9front] FQA contributing?

[sl]

thanks, fixed the link to style(6).

sl