9front - general discussion about 9front
 help / color / mirror / Atom feed
From: unobe@cpan.org
To: 9front@9front.org
Subject: Re: [9front] [PATCH 2/6] cifsd: clarify SMBv1 is supported, not SMB 2/3.
Date: Mon, 18 Dec 2023 10:55:31 -0800	[thread overview]
Message-ID: <05E9D82D70FB9C02C0095FA5B87BAF99@smtp.pobox.com> (raw)
In-Reply-To: <9B894E6543CF0EDCADBB82B46A9C2129@felloff.net>

Quoth cinap_lenrek@felloff.net:
> ok, applied.
> 
> i removed the following tho:
> 
> +	logit("processing [%.2x] command", cmd);
> 
> this is very dangerous and will just fill up your dump with
> pointless log messages.
> 
> if you want to debug, pass the -d flag (it already logs the
> commands in that case).

Thanks, cinap.  I don't recall at this point, but I think I had added
the logit() at the beginning of the sub because the command that was
problematic.  I do not think it was greater than nelems(optab) and yet
wasn't defined, so the 'if' condition would die.  There are now more
added commands, so maybe that won't even be an issue going forward.


  reply	other threads:[~2023-12-18 18:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-28  6:34 Romano
2023-09-28  7:14 ` unobe
2023-12-11 18:57   ` unobe
2023-12-11 19:31   ` unobe
2023-12-15  0:01     ` Roberto E. Vargas Caballero
2023-12-18 12:41 ` cinap_lenrek
2023-12-18 18:05 ` cinap_lenrek
2023-12-18 18:55   ` unobe [this message]
2023-12-19 17:36     ` cinap_lenrek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05E9D82D70FB9C02C0095FA5B87BAF99@smtp.pobox.com \
    --to=unobe@cpan.org \
    --cc=9front@9front.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).