From: theinicke@bss-wf.de
To: 9front@9front.org
Subject: Re: [9front] commit 1a09421f7db897e1d2e2a9210f79ca4389362c3a
Date: Mon, 21 Jun 2021 19:53:28 +0200 [thread overview]
Message-ID: <17D4B7589780B6A5C8E1B53851F04C46@bss-wf.de> (raw)
In-Reply-To: <YNBLzJoLBatVq6U6@alice>
Quoth Anthony Martin <ality@pbrane.org>:
> > kencc: clarify warning for unused assignments
> >
> > [...]
> >
> > - warn(Z, "set and not used: %B", bit);
> > + warn(Z, "assignment not used: %B", bit);
>
> What is unclear about "set and not used"?
>
> This looks to me like change for change's sake.
> Now it's even more tedious to compare the various
> compiler forks, the symmetry with "used and not
> set" is gone, and the reference to this specific
> warning in /sys/doc/comp.ms is stale.
>
> For what gain?
>
> Anthony
I totally agree with what Anthony wrote;
also in addition to all of this the change is half-assed:
Just looking at the diff one can see that there is
still the line with the typo "set an not used".
s/set an not used/set and not used/ would have been a
better substitution!
--
Tobias Heinicke
prev parent reply other threads:[~2021-06-21 19:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 8:20 Anthony Martin
2021-06-21 12:37 ` Noam Preil
2021-06-21 15:20 ` Noam Preil
2021-06-21 18:27 ` hiro
2021-06-21 17:53 ` theinicke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17D4B7589780B6A5C8E1B53851F04C46@bss-wf.de \
--to=theinicke@bss-wf.de \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).