new awk breaks joynes

new awk breaks joynes

[qwx]

Hello,

The recent changes to awk(1) seem to have broken
/sys/src/games/nes/joynes.

Specifically, printf's seem to be no longer buffered, but individual
writes.  This causes /sys/src/games/nes/nes.c:/^joyproc to read each of
joynes' printf's as a separate message rather than a single line, and
results in any keys being cleared before they may be parsed in mem.c.

I don't know awk well enough nor whether this behavior is desirable or
not, but in case it is, the inlined patch below fixes joynes.

Thanks,

qwx

diff -r 3539dab16880 sys/src/games/nes/joynes
--- a/sys/src/games/nes/joynes	Fri May 20 09:56:45 2016 +0200
+++ b/sys/src/games/nes/joynes	Thu May 26 23:46:53 2016 +0200
@@ -1,7 +1,7 @@
 #!/bin/rc
 # run as "nusb/joy epX.Y | joynes N", where N=[1,2]
 
-awk -safe -v 'joy='$1 '
+awk -safe -v 'joy='joy$1 '
 	BEGIN { k[0] = "" }
 
 	/^axis 0 0/   { k[0] = "left " }
@@ -22,12 +22,5 @@
 	/^up 1$/ { k[4] = "" }
 	/^up 2$/ { k[5] = "" }
 
-	{
-		if(joy != "")
-			printf "joy%s ", joy
-		for(i = 0; i <= 5; i++)
-			printf k[i]
-		printf "\n"
-		fflush
-	}
+	{ print joy " " k[0] k[1] k[2] k[3] k[4] k[5] }
 '

Re: [9front] new awk breaks joynes

[cinap_lenrek]

you should also put a fflush at the end, so it would work
even with old awk no? but seems fine to me.

--
cinap

Re: [9front] new awk breaks joynes

[qwx]

On Fri, May 27, 2016 at 06:07:29PM +0200, cinap_lenrek@felloff.net wrote:
> 
> you should also put a fflush at the end, so it would work
> even with old awk no? but seems fine to me.
> 
> --
> cinap

I didn't understand what you meant by this, but the commit you did is
better than just patching random awk scripts anyway.

Thank you for the work,

qwx